linux.git/include/media/lirc_dev.h, branch v4.15-rc2

media: lirc_dev: remove min_timeout and max_timeout

2017-10-11T16:37:36+00:00

There are no users of this functionality (ir-lirc-codec.c has its own
implementation and lirc_zilog.c doesn't use it) so remove it.

This only affects users of the lirc kapi, not rc-core drivers.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: merge struct irctl into struct lirc_dev

2017-10-04T17:53:07+00:00

The use of two separate structs (lirc_dev aka lirc_driver and irctl) makes
it much harder to follow the proper lifetime of the various structs and
necessitates hacks such as keeping a copy of struct lirc_dev inside
struct irctl.

Merging the two structs means that lirc_dev can properly manage the
lifetime of the resulting struct and simplifies the code at the same time.

[mchehab@s-opensource.com: fix merge conflict]
Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: introduce lirc_allocate_device and lirc_free_device

2017-10-04T17:19:17+00:00

Introduce two new functions so that the API for lirc_dev matches that
of the rc-core and input subsystems.

This means that lirc_dev structs are managed using the usual four
functions:

lirc_allocate_device
lirc_free_device
lirc_register_device
lirc_unregister_device

The functions are pretty simplistic at this point, later patches will put
more flesh on the bones of both.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young

[media] media: rename struct lirc_driver to struct lirc_dev

2017-10-04T17:13:08+00:00

This is in preparation for the later patches which do away with
struct irctl entirely.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: use an IDA instead of an array to keep track of registered devices

2017-10-04T17:03:21+00:00

Using the kernel-provided IDA simplifies the code and makes it possible
to remove the lirc_dev_lock mutex.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: make chunk_size and buffer_size mandatory

2017-10-04T16:53:32+00:00

Make setting chunk_size and buffer_size mandatory for drivers which
expect lirc_dev to allocate the lirc_buffer (i.e. ir-lirc-codec) and
don't set them in lirc-zilog (which creates its own buffer).

Also remove an unnecessary copy of chunk_size in struct irctl (the
same information is already available from struct lirc_buffer).

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: make better use of file->private_data

2017-10-04T16:52:12+00:00

By making better use of file->private_data in lirc_dev we can avoid
digging around in the irctls[] array, thereby simplifying the code.

External drivers need to use lirc_get_pdata() instead of mucking around
in file->private_data.

The newly introduced lirc_init_pdata() function isn't very elegant, but
it's a stopgap measure which can be removed once lirc_zilog is converted
to rc-core.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] media: lirc_dev: remove support for manually specifying minor number

2017-10-04T16:50:42+00:00

All users of lirc_register_driver() uses dynamic minor allocation,
therefore we can remove the ability to explicitly request a given number.

This changes the function prototype of lirc_unregister_driver() to also
take a struct lirc_driver pointer as the sole argument.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: cleanup header

2017-06-06T12:07:26+00:00

Remove some stuff from lirc_dev.h which is not used anywhere.

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab

[media] lirc_dev: make fops mandatory

2017-06-06T12:02:20+00:00

Every caller of lirc_register_driver() passes their own fops and there
are no users of lirc_dev_fop_write() in the kernel tree. Thus we can
make fops mandatory and remove lirc_dev_fop_write().

Signed-off-by: David Härdeman 
Signed-off-by: Sean Young 
Signed-off-by: Mauro Carvalho Chehab