linux.git/include/linux/sunrpc, branch v6.3

SUNRPC: Remove ->xpo_secure_port()

2023-02-20T14:20:55+00:00

There's no need for the cost of this extra virtual function call
during every RPC transaction: the RQ_SECURE bit can be set properly
in ->xpo_recvfrom() instead.

Reviewed-by: Jeff Layton 
Signed-off-by: Chuck Lever

SUNRPC: Move remaining internal definitions to gss_krb5_internal.h

2023-02-20T14:20:46+00:00

The goal is to leave only protocol-defined items in gss_krb5.h so
that it can be easily replaced by a generic header. Implementation
specific items are moved to the new internal header.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Support the Camellia enctypes

2023-02-20T14:20:43+00:00

RFC 6803 defines two encryption types that use Camellia ciphers (RFC
3713) and CMAC digests. Implement support for those in SunRPC's GSS
Kerberos 5 mechanism.

There has not been an explicit request to support these enctypes.
However, this new set of enctypes provides a good alternative to the
AES-SHA1 enctypes that are to be deprecated at some point.

As this implementation is still a "beta", the default is to not
build it automatically.

Tested-by: Scott Mayhew 
Signed-off-by: Chuck Lever

SUNRPC: Add gk5e definitions for RFC 8009 encryption types

2023-02-20T14:20:43+00:00

Fill in entries in the supported_gss_krb5_enctypes array for the
encryption types defined in RFC 8009. These new enctypes use the
SHA-256 and SHA-384 message digest algorithms (as defined in
FIPS-180) instead of the deprecated SHA-1 algorithm, and are thus
more secure.

Note that NIST has scheduled SHA-1 for deprecation:

https://www.nist.gov/news-events/news/2022/12/nist-retires-sha-1-cryptographic-algorithm

Thus these new encryption types are placed under a separate CONFIG
option to enable distributors to separately introduce support for
the AES-SHA2 enctypes and deprecate support for the current set of
AES-SHA1 encryption types as their user space allows.

As this implementation is still a "beta", the default is to not
build it automatically.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Add new subkey length fields

2023-02-20T14:20:42+00:00

The aes256-cts-hmac-sha384-192 enctype specifies the length of its
checksum and integrity subkeys as 192 bits, but the length of its
encryption subkey (Ke) as 256 bits. Add new fields to struct
gss_krb5_enctype that specify the key lengths individually, and
where needed, use the correct new field instead of ->keylength.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Hoist KDF into struct gss_krb5_enctype

2023-02-20T14:20:42+00:00

Each Kerberos enctype can have a different KDF. Refactor the key
derivation path to support different KDFs for the enctypes
introduced in subsequent patches.

In particular, expose the key derivation function in struct
gss_krb5_enctype instead of the enctype's preferred random-to-key
function. The latter is usually the identity function and is only
ever called during key derivation, so have each KDF call it
directly.

A couple of extra clean-ups:
- Deduplicate the set_cdata() helper
- Have ->derive_key return negative errnos, in accordance with usual
  kernel coding conventions

This patch is a little bigger than I'd like, but these are all
mechanical changes and they are all to the same areas of code. No
behavior change is intended.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Rename .encrypt_v2 and .decrypt_v2 methods

2023-02-20T14:20:42+00:00

Clean up: there is now only one encrypt and only one decrypt method,
thus there is no longer a need for the v2-suffixed method names.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Remove ->encrypt and ->decrypt methods from struct gss_krb5_enctype

2023-02-20T14:20:41+00:00

Clean up: ->encrypt is set to only one value. Replace the two
remaining call sites with direct calls to krb5_encrypt().

There have never been any call sites for the ->decrypt() method.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Replace KRB5_SUPPORTED_ENCTYPES macro

2023-02-20T14:20:39+00:00

Now that all consumers of the KRB5_SUPPORTED_ENCTYPES macro are
within the SunRPC layer, the macro can be replaced with something
private and more flexible.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever

SUNRPC: Remove another switch on ctx->enctype

2023-02-20T14:20:35+00:00

Replace another switch on encryption type so that it does not have
to be modified when adding or removing support for an enctype.

Tested-by: Scott Mayhew 
Reviewed-by: Simo Sorce 
Signed-off-by: Chuck Lever