linux.git/include/linux/nfs_xdr.h, branch vsnprintf

nfs: Annotate struct pnfs_commit_array with __counted_by()

2024-11-08T19:26:20+00:00

Add the __counted_by compiler attribute to the flexible array member
buckets to improve access bounds-checking via CONFIG_UBSAN_BOUNDS and
CONFIG_FORTIFY_SOURCE.

Compile-tested only.

Signed-off-by: Thorsten Blum 
Signed-off-by: Trond Myklebust

nfs: factor out {encode,decode}_opaque_fixed to nfs_xdr.h

2024-09-23T19:03:29+00:00

Eliminates duplicate functions in various files to allow for
additional callers.

Signed-off-by: Mike Snitzer 
Reviewed-by: NeilBrown 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

nfs: simplify and guarantee owner uniqueness.

2024-09-23T19:03:12+00:00

I have evidence of an Linux NFS client getting NFS4ERR_BAD_SEQID to a
v4.0 LOCK request to a Linux server (which had fixed the problem with
RELEASE_LOCKOWNER bug fixed).
The LOCK request presented a "new" lock owner so there are two seq ids
in the request: that for the open file, and that for the new lock.
Given the context I am confident that the new lock owner was reported to
have the wrong seqid.  As lock owner identifiers are reused, the server
must still have a lock owner active which the client thinks is no longer
active.

I wasn't able to determine a root-cause but the simplest fix seems to be
to ensure lock owners are always unique much as open owners are (thanks
to a time stamp).  The easiest way to ensure uniqueness is with a 64bit
counter for each server.  That will never cycle (if updated once a
nanosecond the last 584 years.  A single NFS server would not handle
open/lock requests nearly that fast, and a Linux node is unlikely to
have an uptime approaching that).

This patch removes the 2 ida and instead uses a per-server
atomic64_t to provide uniqueness.

Note that the lock owner already encodes the id as 64 bits even though
it is a 32bit value.  So changing to a 64bit value does not change the
encoding of the lock owner.  The open owner encoding is now 4 bytes
larger.

Signed-off-by: NeilBrown 
Signed-off-by: Anna Schumaker

NFSv4.1: constify the stateid argument in nfs41_test_stateid()

2024-07-08T17:47:26+00:00

Signed-off-by: Trond Myklebust 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

Return the delegation when deleting sillyrenamed files

2024-07-08T17:47:26+00:00

Add a callback to return the delegation in order to allow generic NFS
code to return the delegation when appropriate.

Signed-off-by: Trond Myklebust 
Signed-off-by: Lance Shelton 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute

2024-07-08T17:47:25+00:00

Query the server for the OPEN arguments that it supports so that
we can figure out which extensions we can use.

Signed-off-by: Trond Myklebust 
Signed-off-by: Lance Shelton 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4: Add recovery of attribute delegations

2024-07-08T17:47:25+00:00

After a reboot of the NFSv4.2 server, the recovery code needs to specify
whether the delegation to be recovered is an attribute delegation or
not.

Signed-off-by: Trond Myklebust 
Signed-off-by: Lance Shelton 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4: Add a flags argument to the 'have_delegation' callback

2024-07-08T17:47:25+00:00

This argument will be used to allow the caller to specify whether or not
they need to know that this is an attribute delegation.

Signed-off-by: Trond Myklebust 
Signed-off-by: Lance Shelton 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4: Plumb in XDR support for the new delegation-only setattr op

2024-07-08T17:47:25+00:00

We want to send the updated atime and mtime as part of the delegreturn
compound. Add a special structure to hold those variables.

Signed-off-by: Trond Myklebust 
Signed-off-by: Lance Shelton 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4: Clean up open delegation return structure

2024-07-08T17:47:25+00:00

Instead of having the fields open coded in the struct nfs_openres,
add a separate structure for them so that we can reuse that code
for the WANT_DELEGATION case.

Signed-off-by: Trond Myklebust 
Signed-off-by: Lance Shelton 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker