linux.git/include/linux/mtd/rawnand.h, branch v5.0-rc2

mtd: rawnand: Deprecate the dummy_controller field

2018-12-07T09:58:11+00:00

We try to force NAND controller drivers to properly separate the NAND
controller object from the NAND chip one, so let's deprecate the dummy
controller object embedded in nand_chip to encourage them to create
their own instance.

Signed-off-by: Boris Brezillon 
Signed-off-by: Miquel Raynal

mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops

2018-12-07T09:38:27+00:00

->setup_data_interface() is a controller specific method and should
thus be placed in nand_controller_ops.

In order to make that work with controllers that support keeping
pre-configured timings we need to add a new NAND_KEEP_TIMINGS flag to
inform the core it should skip the timings selection step.

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Move the ->exec_op() method to nand_controller_ops

2018-12-07T09:38:27+00:00

->exec_op() is a controller method and has nothing to do in the
nand_chip struct. Let's move it to the nand_controller_ops struct and
adjust the core and drivers accordingly.

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Deprecate the ->select_chip() hook

2018-12-07T09:38:27+00:00

Now that the CS line to be selected is passed to ->exec_op() and
stored in chip->cur_cs and after patching all drivers implementing
->exec_op() to stop implementing this method, we can deprecate it by
moving it to the nand_legacy structure.

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Pass the CS line to be selected in struct nand_operation

2018-12-07T09:38:25+00:00

In order to deprecate the ->select_chip hook we need to pass the CS
line a NAND operations are targeting. This is done through the
addition of a cs field to the nand_operation struct.

We also need to keep track of the currently selected target to
properly initialize op->cs, hence the ->cur_cs field addition to the
nand_chip struct.

Note that op->cs is not assigned in nand_exec_op() because we might
rework the way we execute NAND operations in the future (adopt a
queuing mechanism instead of the serialization we have right now).

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Add nand_[de]select_target() helpers

2018-12-07T09:38:25+00:00

Add a wrapper to prevent drivers and core code from directly calling
the ->select_chip hook which we are about to deprecate.

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Remove unused NAND_CONTROLLER_ALLOC flag

2018-12-07T09:38:24+00:00

Looks like NAND_CONTROLLER_ALLOC has been introduced a long time ago
back when the dummy nand_hw_ctrl object was dynamically allocated
instead of being embedded in nand_chip.

We can safely get rid of this unused flag.

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Move nand_exec_op() to internal.h

2018-12-07T09:38:24+00:00

nand_exec_op() is only used by core code (nand_xxx.c files). Let's
move this inline function in drivers/mtd/nand/raw/internals.h.

Signed-off-by: Boris Brezillon 
Tested-by: Janusz Krzysztofik 
Signed-off-by: Miquel Raynal

mtd: rawnand: Provide helper for polling GPIO R/B pin

2018-11-05T09:57:00+00:00

Each controller driver having access to NAND R/B pin over GPIO would
have to reimplement the polling loop otherwise.

Suggested-by: Boris Brezillon 
Signed-off-by: Janusz Krzysztofik 
Reviewed-by: Boris Brezillon 
Signed-off-by: Miquel Raynal

mtd: rawnand: Allow selection of ECC byte ordering at runtime

2018-10-03T09:12:25+00:00

Currently, the selection of ECC byte ordering for software hamming is
done at compilation time, which doesn't make sense when ECC byte
calculation is done in hardware and byte ordering is forced by the
hardware engine.
In this case, only the correction is done in software and we want to
force the byte-ordering no matter the value of CONFIG_MTD_NAND_ECC_SMC.

This is typically the case for the FSMC (Smart Media ordering), TMIO and
TXX9NDFMC (regular byte ordering) blocks.

For all other use cases (pure software implementation, SM FTL and
nandecctest), we keep selecting the byte ordering based on the
CONFIG_MTD_NAND_ECC_SMC value. It might not be ideal for SM FTL (I'd
expect Smart Media ordering to be employed by the Smart Media FTL), but
this option doesn't seem to be enabled in the existing _defconfig, so
I can't tell setting sm_order to true is the right choice.

Signed-off-by: Boris Brezillon 
Signed-off-by: Miquel Raynal