linux.git/include/linux/libata.h, branch v6.6-rc2

ata: libata: disallow dev-initiated LPM transitions to unsupported states

2023-09-11T06:09:11+00:00

In AHCI 1.3.1, the register description for CAP.SSC:
"When cleared to ‘0’, software must not allow the HBA to initiate
transitions to the Slumber state via agressive link power management nor
the PxCMD.ICC field in each port, and the PxSCTL.IPM field in each port
must be programmed to disallow device initiated Slumber requests."

In AHCI 1.3.1, the register description for CAP.PSC:
"When cleared to ‘0’, software must not allow the HBA to initiate
transitions to the Partial state via agressive link power management nor
the PxCMD.ICC field in each port, and the PxSCTL.IPM field in each port
must be programmed to disallow device initiated Partial requests."

Ensure that we always set the corresponding bits in PxSCTL.IPM, such that
a device is not allowed to initiate transitions to power states which are
unsupported by the HBA.

DevSleep is always initiated by the HBA, however, for completeness, set the
corresponding bit in PxSCTL.IPM such that agressive link power management
cannot transition to DevSleep if DevSleep is not supported.

sata_link_scr_lpm() is used by libahci, ata_piix and libata-pmp.
However, only libahci has the ability to read the CAP/CAP2 register to see
if these features are supported. Therefore, in order to not introduce any
regressions on ata_piix or libata-pmp, create flags that indicate that the
respective feature is NOT supported. This way, the behavior for ata_piix
and libata-pmp should remain unchanged.

This change is based on a patch originally submitted by Runa Guo-oc.

Signed-off-by: Niklas Cassel 
Fixes: 1152b2617a6e ("libata: implement sata_link_scr_lpm() and make ata_dev_set_feature() global")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal

ata: libata: remove deprecated EH callbacks

2023-08-02T08:45:42+00:00

Now that all libata drivers have migrated to use the error_handler
callback, remove the deprecated phy_reset and eng_timeout callbacks.

Also remove references to non-existent functions sata_phy_reset and
ata_qc_timeout from Documentation/driver-api/libata.rst.

Signed-off-by: Niklas Cassel 
Reviewed-by: John Garry 
Reviewed-by: Sergey Shtylyov 
Reviewed-by: Jason Yan 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata: libata-core: remove ata_bus_probe()

2023-08-02T08:45:36+00:00

Remove ata_bus_probe() as it is unused.

Also, remove references to ata_bus_probe and port_disable in
Documentation/driver-api/libata.rst, as neither exist anymore.

Signed-off-by: Niklas Cassel 
Reviewed-by: John Garry 
Reviewed-by: Jason Yan 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata,scsi: remove ata_sas_port_init()

2023-08-02T08:45:30+00:00

ata_sas_port_init() now only contains a single initialization.

Move this single initialization to ata_sas_port_alloc(), since:
1) ata_sas_port_alloc() already initializes some of the struct members.
2) ata_sas_port_alloc() is only used by libsas.

Suggested-by: John Garry 
Signed-off-by: Niklas Cassel 
Reviewed-by: John Garry 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata,scsi: cleanup __ata_port_probe()

2023-08-02T08:45:27+00:00

Rename __ata_port_probe() to ata_port_probe() and drop the wrapper
ata_sas_async_probe().

Signed-off-by: Hannes Reinecke 
Signed-off-by: Niklas Cassel 
Reviewed-by: Jason Yan 
Reviewed-by: John Garry 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata: libata-sata: remove ata_sas_sync_probe()

2023-08-02T08:45:18+00:00

Unused.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Niklas Cassel 
Reviewed-by: Jason Yan 
Reviewed-by: John Garry 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata,scsi: remove ata_sas_port_destroy()

2023-08-02T08:45:16+00:00

Is now a wrapper around kfree(), so call it directly.

Signed-off-by: Hannes Reinecke 
Signed-off-by: Niklas Cassel 
Reviewed-by: John Garry 
Reviewed-by: Jason Yan 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata,scsi: remove ata_sas_port_{start,stop} callbacks

2023-08-02T08:45:13+00:00

Callbacks are empty now, so remove them.

Also, remove the call to ap->ops->port_start() in ata_sas_port_init(),
as this would otherwise cause a NULL pointer dereference, now when the
callback is gone.

Signed-off-by: Hannes Reinecke 
[niklas: remove the call to ap->ops->port_start() in ata_sas_port_init()]
Signed-off-by: Niklas Cassel 
Reviewed-by: Jason Yan 
Reviewed-by: John Garry 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata: libata: remove references to non-existing error_handler()

2023-08-02T08:45:10+00:00

With commit 65a15d6560df ("scsi: ipr: Remove SATA support") all
libata drivers now have the error_handler() callback provided,
so we can stop checking for non-existing error_handler callback.

Signed-off-by: Hannes Reinecke 
[niklas: fixed review comments, rebased, solved conflicts during rebase,
fixed bug that unconditionally dumped all QCs, removed the now unused
function ata_dump_status(), removed the now unreachable failure paths in
atapi_qc_complete(), removed the non-EH function to request ATAPI sense]
Signed-off-by: Niklas Cassel 
Reviewed-by: John Garry 
Reviewed-by: Jason Yan 
Reviewed-by: Martin K. Petersen 
Signed-off-by: Damien Le Moal

ata: fix debounce timings type

2023-08-02T08:37:06+00:00

sata_deb_timing_{hotplug|long|normal}[] store 'unsigned long' debounce
timeouts in ms, while sata_link_debounce() eventually uses those timeouts
by calling ata_{deadline|msleep}( which take just 'unsigned int'.  Change
the debounce timeout table element's type to 'unsigned int' -- all these
timeouts happily fit into 'unsigned int'...

Signed-off-by: Sergey Shtylyov 
Signed-off-by: Damien Le Moal