linux.git/include/linux/if_vlan.h, branch v2.6.26-rc2

[VLAN]: Tag vlan_group_device with net device, not ifindex.

2008-04-16T07:48:04+00:00

Currently vlan group is searched using one key - the ifindex.
We'll have to lookup the vlan_group by two keys - ifindex and
net. Turning the vlan_group lookup key to struct net_device
pointer will make this process easier.

Besides, this will eliminate one more place in the networking,
that assumes that indexes are unique in the kernel.

Signed-off-by: Pavel Emelyanov 
Acked-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Reduce memory consumed by vlan_groups

2008-03-26T23:27:22+00:00

Currently each vlan_groupd contains 8 pointers on arrays with 512
pointers on struct net_device each  :)  Such a construction "in many
cases ... wastes memory".

My proposal is to allow for some of these arrays pointers be NULL,
meaning that there are no devices in it. When a new device is added
to the vlan_group, the appropriate array is allocated.

The check in vlan_group_get_device's is safe, since the pointer
vg->vlan_devices_arrays[x] can only switch from NULL to not-NULL.
The vlan_group_prealloc_vid() is guarded with rtnl lock and is
also safe.

I've checked (I hope that) all the places, that use these arrays
and found, that the register_vlan_dev is the only place, that can
put a vlan device on an empty vlan_group.

Rough calculations shows, that after the patch a setup with a
single vlan dev (or up to 512 vlans with sequential vids) will
occupy approximately 8 times less memory.

The question I have is - does this patch makes sense, or a totally
new structures are required to store the vlan_devs?

Signed-off-by: Pavel Emelyanov 
Signed-off-by: Patrick McHardy

[VLAN]: Constify skb argument to vlan_get_tag()

2008-02-06T00:20:22+00:00

Required by next patch to use it from the flow classifier.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Turn __constant_htons into htons where possible

2008-01-28T23:08:32+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Turn VLAN_DEV_INFO into inline function

2008-01-28T23:08:32+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Simplify vlan unregistration

2008-01-28T23:08:31+00:00

Keep track of the number of VLAN devices in a vlan group. This allows
to have the caller sense when the group is going to be destroyed and
stop using it, which in turn allows to remove the wrapper around
unregister_vlan_dev for the NETDEV_UNREGISTER notifier and avoid
iterating over all possible VLAN ids whenever a device in unregistered.

Also fix what looks like a use-after-free (but is actually safe since
we're holding the RTNL), the real_dev reference should not be dropped
while we still use it.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Use dev->stats

2008-01-28T23:08:25+00:00

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Kill useless VLAN_NAME define

2008-01-28T23:08:25+00:00

The only user already includes __FUNCTION__ (vlan_proto_init) in the
output, which is enough to identify what the message is about.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Clean up vlan_hdr/vlan_ethhdr structs

2008-01-28T23:08:24+00:00

Fix 3 space indentation and some overly long lines by moving the
comments to a kdoc structure description.

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller

[VLAN]: Remove unnecessary structure declarations

2008-01-28T23:08:23+00:00

- struct packet_type is not used
- struct vlan_group is declared later in the file before the first use
- struct net_device is not needed since netdevice.h is included
- struct vlan_collection does not exist
- struct vlan_dev_info is declared later in the file before the first use

Signed-off-by: Patrick McHardy 
Signed-off-by: David S. Miller