linux.git/include/linux/edac.h, branch v5.7-rc2

EDAC/mc: Remove per layer counters

2020-02-17T12:37:00+00:00

Looking at how mci->{ue,ce}_per_layer[EDAC_MAX_LAYERS] is used, it
turns out that only the leaves in the memory hierarchy are consumed
(in sysfs), but not the intermediate layers, e.g.:

  count = dimm->mci->ce_per_layer[dimm->mci->n_layers-1][dimm->idx];

These unused counters only add complexity, remove them. The error
counter values are directly stored in struct dimm_info now.

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Acked-by: Aristeu Rozanski 
Link: https://lkml.kernel.org/r/20200123090210.26933-11-rrichter@marvell.com

EDAC/mc: Remove enable_per_layer_report function argument

2020-02-17T12:13:16+00:00

Many functions carry the enable_per_layer_report argument. This is a
bool value indicating the error information contains some location
data where the error occurred. This can easily being determined by
checking the pos[] array for values. Negative values indicate there is
no location available. So if the top layer is negative, the error
location is unknown.

Just check if the top layer is negative and remove
enable_per_layer_report as function argument and also from struct
edac_raw_error_desc.

 [ bp: Reflow comments to 80 columns, while at it. ]

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Acked-by: Aristeu Rozanski 
Link: https://lkml.kernel.org/r/20200123090210.26933-8-rrichter@marvell.com

EDAC: Store error type in struct edac_raw_error_desc

2020-02-17T12:02:30+00:00

Store the error type in struct edac_raw_error_desc. This makes the
type parameter of edac_raw_mc_handle_error() obsolete.

[ kernel-doc typo ]
Reported-by: kbuild test robot 
Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Acked-by: Aristeu Rozanski 
Link: https://lkml.kernel.org/r/20200123090210.26933-4-rrichter@marvell.com

EDAC: Remove misleading comment in struct edac_raw_error_desc

2019-11-10T11:40:14+00:00

There never has been such function edac_raw_error_desc_clean() and in
function ghes_edac_report_mem_error() the whole struct is zero'ed
including the string arrays. Remove that comment.

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20191106093239.25517-9-rrichter@marvell.com

EDAC: Introduce an mci_for_each_dimm() iterator

2019-11-10T11:39:40+00:00

Introduce an mci_for_each_dimm() iterator. It returns a pointer to
a struct dimm_info. This makes the declaration and use of an index
obsolete and avoids access to internal data of struct mci (direct array
access etc).

 [ bp: push the struct dimm_info *dimm; declaration into the
   CONFIG_EDAC_DEBUG block. ]

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20191106093239.25517-4-rrichter@marvell.com

EDAC: Remove EDAC_DIMM_OFF() macro

2019-11-09T10:23:49+00:00

The EDAC_DIMM_OFF() macro takes 5 arguments to get the DIMM's index.
Simplify this by storing the index in struct dimm_info to avoid its
calculation and remove the EDAC_DIMM_OFF() macro. The index can be
directly used then.

Another advantage is that edac_mc_alloc() could be used even if the
exact size of the layers is unknown. Only the number of DIMMs would be
needed.

Rename iterator variable to idx, while at it. The name is more handy,
esp. when searching for it in the code.

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20191106093239.25517-3-rrichter@marvell.com

EDAC: Replace EDAC_DIMM_PTR() macro with edac_get_dimm() function

2019-11-09T09:32:32+00:00

The EDAC_DIMM_PTR() macro takes 3 arguments from struct mem_ctl_info.
Clean up this interface to only pass the mci struct and replace this
macro with a new function edac_get_dimm().

Also introduce an edac_get_dimm_by_index() function for later use.
This allows it to get a DIMM pointer only by a given index. This can
be useful if the DIMM's position within the layers of the memory
controller or the exact size of the layers are unknown.

Small style changes made for some hunks after applying the semantic
patch.

Semantic patch used:

@@ expression mci, a, b,c; @@

-EDAC_DIMM_PTR(mci->layers, mci->dimms, mci->n_layers, a, b, c)
+edac_get_dimm(mci, a, b, c)

 [ bp: Touchups. ]

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Jason Baron 
Cc: Qiuxu Zhuo 
Cc: Tero Kristo 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20191106093239.25517-2-rrichter@marvell.com

EDAC: Prefer 'unsigned int' to bare use of 'unsigned'

2019-09-03T17:21:19+00:00

Use of 'unsigned int' instead of bare use of 'unsigned'. Fix this for
edac_mc*, ghes and the i5100 driver as reported by checkpatch.pl.

While at it, struct member dev_ch_attribute->channel is always used as
unsigned int. Change type to unsigned int to avoid type casts.

 [ bp: Massage. ]

Signed-off-by: Robert Richter 
Signed-off-by: Borislav Petkov 
Reviewed-by: Mauro Carvalho Chehab 
Cc: "linux-edac@vger.kernel.org" 
Cc: James Morse 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20190902123216.9809-2-rrichter@marvell.com

EDAC: Drop per-memory controller buses

2018-11-13T20:55:24+00:00

... and use the single edac_subsys object returned from
subsys_system_register(). The idea is to have a single bus
and multiple devices on it.

Signed-off-by: Borislav Petkov 
Acked-by: Mauro Carvalho Chehab 
CC: Aristeu Rozanski Filho 
CC: Greg KH 
CC: Justin Ernst 
CC: linux-edac 
CC: Mauro Carvalho Chehab 
CC: Russ Anderson 
Cc: Tony Luck 
Link: https://lkml.kernel.org/r/20180926152752.GG5584@zn.tnic

EDAC: Raise the maximum number of memory controllers

2018-09-27T05:52:05+00:00

We observe an oops in the skx_edac module during boot:

  EDAC MC0: Giving out device to module skx_edac controller Skylake Socket#0 IMC#0
  EDAC MC1: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1
  EDAC MC2: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0
  ...
  EDAC MC13: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1
  EDAC MC14: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0
  EDAC MC15: Giving out device to module skx_edac controller Skylake Socket#1 IMC#1
  Too many memory controllers: 16
  EDAC MC: Removed device 0 for skx_edac Skylake Socket#0 IMC#0

We observe there are two memory controllers per socket, with a limit
of 16. Raise the maximum number of memory controllers from 16 to 2 *
MAX_NUMNODES (1024).

[ bp: This is just a band-aid fix until we've sorted out the whole issue
  with the bus_type association and handling in EDAC and can get rid of
  this arbitrary limit. ]

Signed-off-by: Justin Ernst 
Signed-off-by: Borislav Petkov 
Acked-by: Russ Anderson 
Cc: Mauro Carvalho Chehab 
Cc: linux-edac@vger.kernel.org
Link: https://lkml.kernel.org/r/20180925143449.284634-1-justin.ernst@hpe.com