linux.git/fs/xfs, branch master

xfs: Remove mention of PageWriteback

2026-05-30T06:26:18+00:00

Update a comment to refer to folios instead of pages.

Signed-off-by: Matthew Wilcox (Oracle) 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino

xfs: abort mount if xfs_fs_reserve_ag_blocks fails

2026-05-30T06:26:18+00:00

xfs_mountfs currently ignores all errors from xfs_fs_reserve_ag_blocks,
which can lead to the mount path continuing on corruption errors.
Fix the check to only ignore -ENOSPC as in other callers, and unwind for
all other errors.

Fixes: 81ed94751b15 ("xfs: fix log intent recovery ENOSPC shutdowns when inactivating inodes")
Signed-off-by: Christoph Hellwig 
Reviewed-by: "Darrick J. Wong" 
Signed-off-by: Carlos Maiolino

xfs: factor rtgroup geom write pointer reporting into a helper

2026-05-30T06:26:18+00:00

Sticks out a bit better if we add a separate helper for it.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Carlos Maiolino 
Reviewed-by: Wilfred Mallawa 
Reviewed-by: Damien Le Moal 
Signed-off-by: Carlos Maiolino

xfs: drop the RTG reference later in xfs_ioc_rtgroup_geometry

2026-05-30T06:26:18+00:00

Keep the rtgroup reference until after reporting the write pointer, as
that uses it.  Right now this is not a major issue as we don't support
shrinking file systems in a way that makes RTGs go away, but let's stick
to the proper reference counting to prepare for that.

Fixes: c6ce65cb17aa ("xfs: add write pointer to xfs_rtgroup_geometry")
Signed-off-by: Christoph Hellwig 
Reviewed-by: Carlos Maiolino 
Reviewed-by: Wilfred Mallawa 
Reviewed-by: Damien Le Moal 
Signed-off-by: Carlos Maiolino

xfs: fix rtgroup cleanup in CoW fork repair

2026-05-30T06:26:18+00:00

xrep_cow_find_bad_rt() initializes scrub rtgroup state before the
force-rebuild path calls xrep_cow_mark_file_range(). If that call
fails, the code jumps directly to out_rtg, which skips the scrub
rtgroup cleanup and only drops the local rtgroup reference.

Remove the unnecessary jump so the function falls through to out_sr,
ensuring the realtime cursors, lock state, and sr->rtg reference are
released before returning.

Fixes: fd97fe111208 ("xfs: fix CoW forks for realtime files")
Cc:  # v6.14
Signed-off-by: Yingjie Gao 
Reviewed-by: "Darrick J. Wong" 
Signed-off-by: Carlos Maiolino

xfs: fix error returns in CoW fork repair

2026-05-30T06:26:18+00:00

xrep_cow_find_bad() returns success after the cleanup labels even if
AG setup, btree queries, or bitmap updates failed. This can make
repair continue with an incomplete bad-file-offset bitmap instead of
stopping at the original error.

The force-rebuild path has a related cleanup problem. If
xrep_cow_mark_file_range() fails, the function returns directly and
skips the scrub AG context and perag cleanup.

Let the force-rebuild path fall through to the existing cleanup code
and return the saved error after cleanup.

Fixes: dbbdbd008632 ("xfs: repair problems in CoW forks")
Cc:  # v6.8
Signed-off-by: Yingjie Gao 
Reviewed-by: "Darrick J. Wong" 
Signed-off-by: Carlos Maiolino

xfs: fix overlapping extents returned for pNFS LAYOUTGET

2026-05-30T06:26:18+00:00

xfs_fs_map_blocks() currently passes XFS_BMAPI_ENTIRE to xfs_bmapi_read(),
which causes the bmap code to expand the mapping to cover the entire
extent rather than the requested range.

A single LAYOUTGET request from the client can cause the server to
issue multiple calls to xfs_fs_map_blocks() for different offsets
within the same extent. Because the use of XFS_BMAPI_ENTIRE flag,
these calls can produce overlapping mappings.

As a result, the LAYOUTGET reply sent to the NFS client may contain
overlapping extents. This creates ambiguity in extent selection for a
given file range, which can lead to incorrect device selection,
inconsistent handling of datastate, and ultimately data corruption or
protocol violations on the client side.

Problem discovered with xfstest generic/075 test using NFSv4.2 mount
with SCSI layout.

Fix this by replacing the XFS_BMAPI_ENTIRE flag with '0' so that
xfs_bmapi_read() returns only the mapping for the requested range.

Fixes: cc6c40e09d7b1 ("NFSD/blocklayout: Support multiple extents per LAYOUTGET").
Signed-off-by: Dai Ngo 
Reviewed-by: Carlos Maiolino 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino

xfs: fix use of uninitialized imap in xfs_fs_map_blocks error path

2026-05-30T06:26:17+00:00

xfs_fs_map_blocks() acquires the data map lock and then calls
xfs_bmapi_read(). If xfs_bmapi_read() fails, the function currently
still falls through to xfs_bmbt_to_iomap(), which consumes an
uninitialized imap record and may return invalid data to the caller.

Fix this by releasing the data map lock and returning immediately when
xfs_bmapi_read() reports an error. This prevents xfs_bmbt_to_iomap()
from being called with an uninitialized xfs_bmbt_irec.

Fixes: 527851124d10f ("xfs: implement pNFS export operations")
Signed-off-by: Dai Ngo 
Reviewed-by: Carlos Maiolino 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino

xfs: handle racing deletions in xfs_zone_gc_iter_irec

2026-05-30T06:26:17+00:00

Under heavy garbage collection pressure from RocksDB workloads,
filesystem shutdowns can occur in xfs_zone_gc_iter_irec when
xfs_iget() returns -EINVAL for deleted files.

Fix this by handling -EINVAL just like we handle -ENOENT, allowing
zone GC to safely ignore stale mappings.

Fixes: 080d01c41d44 ("xfs: implement zoned garbage collection")
Signed-off-by: Hans Holmberg 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Carlos Maiolino

xfs: fix a buffer lookup against removal race

2026-05-21T11:43:58+00:00

When a buffer is freed either by LRU eviction or because it is unset,
the lockref is marked as dead instantly, which prevents the buffer from
being used after finding it in the buffer hash in xfs_buf_lookup and
xfs_buf_find_insert.  But the latter will then not add the new buffer to
the hash because it already found an existing buffer.

Fix this using in two places:  Remove the buffer from the hash before
marking the lockref dead so that that no buffer with a dead lockref can
be found in the hash, but if we find one in xfs_buf_find_insert due to
store reordering, handle this case correctly instead of returning an
unhashed buffer.

Fixes: 67fe4303972e ("xfs: don't keep a reference for buffers on the LRU")
Reported-by: Andrey Albershteyn 
Reported-by: Carlos Maiolino 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Andrey Albershteyn 
Reviewed-by: Carlos Maiolino 
Signed-off-by: Carlos Maiolino