linux.git/fs/xfs/support/debug.h, branch master

xfs: kill support/debug.[ch]

2011-03-06T23:09:35+00:00

The remaining functionality in debug.[ch] is effectively just assert
handling, conditional debug definitions and hex dumping. The hex
dumping and assert function can be moved into the new printk module,
while the rest can be moved into top-level header files. This allows
fs/xfs/support/debug.[ch] to be completely removed from the
codebase.

Signed-off-by: Dave Chinner 
Reviewed-by: Alex Elder 
Reviewed-by: Christoph Hellwig

xfs: Convert remaining cmn_err() callers to new API

2011-03-06T23:08:35+00:00

Once converted, kill the remainder of the cmn_err() interface.

Signed-off-by: Dave Chinner 
Reviewed-by: Alex Elder 
Reviewed-by: Christoph Hellwig

xfs: convert xfs_fs_cmn_err to new error logging API

2011-03-06T23:05:35+00:00

Continue to clean up the error logging code by converting all the
callers of xfs_fs_cmn_err() to the new API. Once done, remove the
unused old API function.

Signed-off-by: Dave Chinner 
Reviewed-by: Alex Elder 
Reviewed-by: Christoph Hellwig

xfs: convert xfs_cmn_err to xfs_alert_tag

2011-03-06T23:02:35+00:00

Continue the conversion of the old cmn_err interface be converting
all the conditional panic tag errors to xfs_alert_tag() and then
removing xfs_cmn_err().

Signed-off-by: Dave Chinner 
Reviewed-by: Alex Elder 
Reviewed-by: Christoph Hellwig

xfs: prevent NMI timeouts in cmn_err

2011-01-12T14:46:41+00:00

We currently have a global error message buffer in cmn_err that is
protected by a spin lock that disables interrupts.  Recently there
have been reports of NMI timeouts occurring when the console is
being flooded by SCSI error reports due to cmn_err() getting stuck
trying to print to the console while holding this lock (i.e. with
interrupts disabled). The NMI watchdog is seeing this CPU as
non-responding and so is triggering a panic.  While the trigger for
the reported case is SCSI errors, pretty much anything that spams
the kernel log could cause this to occur.

Realistically the only reason that we have the intemediate message
buffer is to prepend the correct kernel log level prefix to the log
message. The only reason we have the lock is to protect the global
message buffer and the only reason the message buffer is global is
to keep it off the stack. Hence if we can avoid needing a global
message buffer we avoid needing the lock, and we can do this with a
small amount of cleanup and some preprocessor tricks:

	1. clean up xfs_cmn_err() panic mask functionality to avoid
	   needing debug code in xfs_cmn_err()
	2. remove the couple of "!" message prefixes that still exist that
	   the existing cmn_err() code steps over.
	3. redefine CE_* levels directly to KERN_*
	4. redefine cmn_err() and friends to use printk() directly
	   via variable argument length macros.

By doing this, we can completely remove the cmn_err() code and the
lock that is causing the problems, and rely solely on printk()
serialisation to ensure that we don't get garbled messages.

A series of followup patches is really needed to clean up all the
cmn_err() calls and related messages properly, but that results in a
series that is not easily back portable to enterprise kernels. Hence
this initial fix is only to address the direct problem in the lowest
impact way possible.

Signed-off-by: Dave Chinner 
Reviewed-by: Christoph Hellwig 
Signed-off-by: Alex Elder

xfs: kill the STATIC_INLINE macro

2009-12-11T21:11:22+00:00

Remove our own STATIC_INLINE macro.  For small function inside
implementation files just use STATIC and let gcc inline it, and for
those in headers do the normal static inline - they are all small
enough to be inlined for debug builds, too.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Dave Chinner 
Signed-off-by: Alex Elder

[XFS] avoid memory allocations in xfs_fs_vcmn_err

2008-12-22T07:02:01+00:00

xfs_fs_vcmn_err can be called under a spinlock, but does a sleeping memory
allocation to create buffer for it's internal sprintf.  Fortunately it's
the only caller of icmn_err, so we can merge the two and have one single
static buffer and spinlock protecting it.  While we're at it make sure
we proper __attribute__ format annotations so that the compiler can detect
mismatched format strings.

Reported-by: Alexander Beregalov 
Signed-off-by: Christoph Hellwig 
Reviewed-by: Eric Sandeen 
Signed-off-by: Lachlan McIlroy

[XFS] Include linux/random.h in all builds, not just debug.

2008-04-30T14:53:50+00:00

Noted-by: Stephen Rothwell 
Signed-off-by: Dave Chinner 
Signed-off-by: Linus Torvalds

[XFS] fix ASSERT and ASSERT_ALWAYS

2007-09-05T04:49:30+00:00

- remove the != 0 inside the unlikely in ASSERT_ALWAYS because sparse now
  complains about comparisons between pointers and 0
- add a standalone ASSERT implementation because defining it to
  ASSERT_ALWAYS means the string is expanded before the token passing
  stringification. This way we get the actual content of the
  assertion in the assfail message and don't overflow sparse's
  stringification buffer leading to sparse error messages.

SGI-PV: 968555
SGI-Modid: xfs-linux-melb:xfs-kern:29310a

Signed-off-by: Christoph Hellwig 
Signed-off-by: David Chinner 
Signed-off-by: Tim Shimmin

[XFS] reducing the number of random number functions.

2007-05-08T03:49:03+00:00

Patch provided by Joe Perches

SGI-PV: 961696
SGI-Modid: xfs-linux-melb:xfs-kern:28209a

Signed-off-by: Joe Perches 
Signed-off-by: Lachlan McIlroy 
Signed-off-by: Tim Shimmin