linux.git/fs/xattr.c, branch v3.17 Linux kernel source tree simple_xattr: permit 0-size extended attributes 2014-07-23T22:10:55+00:00 Hugh Dickins hughd@google.com 2014-07-23T21:00:17+00:00 4e66d445d0421a159135572a0ba44b75c7c4adfa If a filesystem uses simple_xattr to support user extended attributes, LTP setxattr01 and xfstests generic/062 fail with "Cannot allocate memory": simple_xattr_alloc()'s wrap-around test mistakenly excludes values of zero size. Fix that off-by-one (but apparently no filesystem needs them yet). Signed-off-by: Hugh Dickins <hughd@google.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Jeff Layton <jlayton@poochiereds.net> Cc: Aristeu Rozanski <aris@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
If a filesystem uses simple_xattr to support user extended attributes,
LTP setxattr01 and xfstests generic/062 fail with "Cannot allocate
memory": simple_xattr_alloc()'s wrap-around test mistakenly excludes
values of zero size.  Fix that off-by-one (but apparently no filesystem
needs them yet).

Signed-off-by: Hugh Dickins <hughd@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Jeff Layton <jlayton@poochiereds.net>
Cc: Aristeu Rozanski <aris@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
vfs: make lremovexattr retry once on ESTALE error 2012-12-20T23:50:11+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:18+00:00 b729d75d19777a5dd34672020516eada43ff026f Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: make removexattr retry once on ESTALE 2012-12-20T23:50:10+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:17+00:00 12f06212990400db1b54bd7b49b7f6f5f1b32469 Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: make llistxattr retry once on ESTALE error 2012-12-20T23:50:10+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:17+00:00 bd9bbc9842bde1b14046cdbda1153f0d49061135 Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: make listxattr retry once on ESTALE error 2012-12-20T23:50:10+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:16+00:00 10a90cf36efe0fca5c7719fd9b0299abd6be51aa Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: make lgetxattr retry once on ESTALE 2012-12-20T23:50:09+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:16+00:00 3a3e159dbfe405517584b09bbcefd72115d93342 Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: make getxattr retry once on an ESTALE error 2012-12-20T23:50:09+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:16+00:00 60e66b48ca20819d97ec4851007accc0b013985a Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: allow lsetxattr() to retry once on ESTALE errors 2012-12-20T23:50:09+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:15+00:00 49e09e1cc576daa99ea22f3a3c699062c34f8c0f Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
vfs: allow setxattr to retry once on ESTALE errors 2012-12-20T23:50:08+00:00 Jeff Layton jlayton@redhat.com 2012-12-11T17:10:15+00:00 68f1bb8bb89e0bb813c893a42373a26ebdab7f9c Signed-off-by: Jeff Layton <jlayton@redhat.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs, xattr: fix bug when removing a name not in xattr list 2012-10-18T19:35:58+00:00 David Rientjes rientjes@google.com 2012-10-18T03:41:15+00:00 43385846968b082bb6c174e8b17479e5123b8d73 Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved some code from tmpfs but introduced a subtle bug along the way. If the name passed to simple_xattr_remove() does not exist in the list of xattrs, then it is possible to call kfree(new_xattr) when new_xattr is actually initialized to itself on the stack via uninitialized_var(). This causes a BUG() since the memory was not allocated via the slab allocator and was not bypassed through to the page allocator because it was too large. Initialize the local variable to NULL so the kfree() never takes place. Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: David Rientjes <rientjes@google.com> Acked-by: Hugh Dickins <hughd@google.com> Acked-by: Aristeu Rozanski <aris@redhat.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
Commit 38f38657444d ("xattr: extract simple_xattr code from tmpfs") moved
some code from tmpfs but introduced a subtle bug along the way.

If the name passed to simple_xattr_remove() does not exist in the list of
xattrs, then it is possible to call kfree(new_xattr) when new_xattr is
actually initialized to itself on the stack via uninitialized_var().

This causes a BUG() since the memory was not allocated via the slab
allocator and was not bypassed through to the page allocator because it
was too large.

Initialize the local variable to NULL so the kfree() never takes place.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David Rientjes <rientjes@google.com>
Acked-by: Hugh Dickins <hughd@google.com>
Acked-by: Aristeu Rozanski <aris@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>