linux.git/fs/udf, branch v3.17

udf: saner calling conventions for udf_new_inode()

2014-09-04T19:37:41+00:00

Signed-off-by: Al Viro 
Signed-off-by: Jan Kara

udf: fix the udf_iget() vs. udf_new_inode() races

2014-09-04T19:37:41+00:00

Currently udf_iget() (triggered by NFS) can race with udf_new_inode()
leading to two inode structures with the same inode number:

nfsd: iget_locked() creates inode
nfsd: try to read from disk, block on that.
udf_new_inode(): allocate inode with that inumber
udf_new_inode(): insert it into icache, set it up and dirty
udf_write_inode(): write inode into buffer cache
nfsd: get CPU again, look into buffer cache, see nice and sane on-disk
  inode, set the in-core inode from it

Fix the problem by putting inode into icache in locked state (I_NEW set)
and unlocking it only after it's fully set up.

Signed-off-by: Al Viro 
Signed-off-by: Jan Kara

udf: merge the pieces inserting a new non-directory object into directory

2014-09-04T19:37:40+00:00

boilerplate code in udf_{create,mknod,symlink} taken to new helper

symlink case converted to unique id calculated by udf_new_inode() - no
point finding a new one.

Signed-off-by: Al Viro 
Signed-off-by: Jan Kara

udf: Set i_generation field

2014-09-04T19:37:40+00:00

Currently UDF doesn't initialize i_generation in any way and thus NFS
can easily get reallocated inodes from stale file handles. Luckily UDF
already has a unique object identifier associated with each inode -
i_unique. Use that for initialization of i_generation.

Signed-off-by: Jan Kara

udf: Properly detect stale inodes

2014-09-04T19:37:39+00:00

NFS can easily ask for inodes that are already deleted. Currently UDF
happily returns such inodes which is a bug. Return -ESTALE if
udf_read_inode() is asked to read deleted inode.

Signed-off-by: Jan Kara

udf: Make udf_read_inode() and udf_iget() return error

2014-09-04T19:36:35+00:00

Currently __udf_read_inode() wasn't returning anything and we found out
whether we succeeded reading inode by checking whether inode is bad or
not. udf_iget() returned NULL on failure and inode pointer otherwise.
Make these two functions properly propagate errors up the call stack and
use the return value in callers.

Signed-off-by: Jan Kara

udf: Avoid infinite loop when processing indirect ICBs

2014-09-04T12:12:29+00:00

We did not implement any bound on number of indirect ICBs we follow when
loading inode. Thus corrupted medium could cause kernel to go into an
infinite loop, possibly causing a stack overflow.

Fix the possible stack overflow by removing recursion from
__udf_read_inode() and limit number of indirect ICBs we follow to avoid
infinite loops.

Signed-off-by: Jan Kara

udf: Fold udf_fill_inode() into __udf_read_inode()

2014-09-04T11:32:50+00:00

There's no good reason to separate these since udf_fill_inode() is
called only from __udf_read_inode() and both do part of the same thing.

Signed-off-by: Jan Kara

udf: Avoid dir link count to go negative

2014-09-04T09:47:51+00:00

If we are writing back inode of unlinked directory, its link count ends
up being (u16)-1. Although the inode is deleted, udf_iget() can load the
inode when NFS uses stale file handle and get confused.

Signed-off-by: Jan Kara

udf: avoid unneeded up_write when fail to add entry in ->symlink

2014-08-19T16:29:30+00:00

We have released the ->i_data_sem before invoking udf_add_entry(),
so in following error path, we should not release this lock again.

Signed-off-by: Chao Yu 
Signed-off-by: Jan Kara