linux.git/fs/udf/unicode.c, branch v2.6.30

udf: Fix oops when invalid character in filename occurs

2009-04-02T10:29:53+00:00

Functions udf_CS0toNLS() and udf_NLStoCS0() didn't count with the fact that
NLS can return negative length when invalid character is given to it for
conversion. Thus interesting things could happen (such as overwriting random
memory with the rest of filename). Add appropriate checks.

Signed-off-by: Jan Kara

udf: reduce stack usage of udf_get_filename

2009-04-02T10:29:49+00:00

Allocate strings with kmalloc.

Checkstack output:
Before: udf_get_filename:          600
After:  udf_get_filename:          136

Signed-off-by: Marcin Slusarz 
Cc: Jan Kara 
Signed-off-by: Jan Kara

udf: use crc_itu_t from lib instead of udf_crc

2008-04-17T12:29:56+00:00

As pointed out by Sergey Vlasov, UDF implements its own version of
the CRC ITU-T V.41.  Convert it to use the one in the library.

Signed-off-by: Bob Copeland 
Cc: Sergey Vlasov 
Signed-off-by: Jan Kara

udf: udf_CS0toNLS cleanup

2008-04-17T12:22:24+00:00

- fix error handling - always zero output variable
- don't zero explicitely fields zeroed by memset
- mark "in" paramater as const

Signed-off-by: Marcin Slusarz 
Signed-off-by: Jan Kara

udf: fix udf_build_ustr

2008-04-17T12:22:24+00:00

udf_build_ustr was broken:

- size == 1:
    dest->u_len = ptr[1 - 1], but at ptr[0] there's cmpID,
    so we created string with wrong length
    it should not happen, so we BUG() it
- size > 1 and size < UDF_NAME_LEN:
    we set u_len correctly, but memcpy copied one needless byte
- size == UDF_NAME_LEN - 1:
    memcpy overwrited u_len - with correct value, but...
- size >= UDF_NAME_LEN:
    we copied UDF_NAME_LEN - 1 bytes, but dest->u_name is array
    of UDF_NAME_LEN - 2 bytes, so we were overwriting u_len with
    character from input string

nobody noticed because all callers set size
to acceptable values (constants within range)

Signed-off-by: Marcin Slusarz 
Signed-off-by: Jan Kara

udf: udf_CS0toUTF8 cleanup

2008-04-17T12:22:23+00:00

- fix error handling - always zero output variable
- don't zero explicitely fields zeroed by memset
- mark "in" paramater as const
- remove outdated comment

Signed-off-by: Marcin Slusarz 
Signed-off-by: Jan Kara

udf: move headers out include/linux/

2008-04-17T12:22:23+00:00

There's really no reason to keep udf headers in include/linux as they're
not used by anything but fs/udf/.

This patch merges most of include/linux/udf_fs_i.h into fs/udf/udf_i.h,
include/linux/udf_fs_sb.h into fs/udf/udf_sb.h and
include/linux/udf_fs.h into fs/udf/udfdecl.h.

The only thing remaining in include/linux/ is a stub of udf_fs_i.h
defining the four user-visible udf ioctls.  It's also moved from
unifdef-y to headers-y because it can be included unconditionally now.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jan Kara

udf: fix coding style

2008-02-08T17:22:35+00:00

fix coding style errors found by checkpatch:
- assignments in if conditions
- braces {} around single statement blocks
- no spaces after commas
- printks without KERN_*
- lines longer than 80 characters
- spaces between "type *" and variable name

before: 192 errors, 561 warnings, 8987 lines checked
after: 1 errors, 38 warnings, 9468 lines checked

Signed-off-by: Marcin Slusarz 
Cc: Jan Kara 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

UDF: coding style conversion - lindent fixups

2007-07-22T00:49:14+00:00

This patch fixes up sources after conversion by Lindent.

Signed-off-by: Cyrill Gorcunov 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

UDF: coding style conversion - lindent

2007-07-19T17:04:43+00:00

This patch converts UDF coding style to kernel coding style using Lindent.

Signed-off-by: Cyrill Gorcunov 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds