linux.git/fs/udf/misc.c, branch v5.7

udf: Fix signed/unsigned format specifiers

2017-10-17T10:00:58+00:00

Fix problems noted in compilion with -Wformat=2 -Wformat-signedness.
In particular, a mismatch between the signedness of a value and the
signedness of its format specifier can result in unsigned values being
printed as negative numbers, e.g.:

  Partition (0 type 1511) starts at physical 460, block length -1779968542

...which occurs when mounting a large (> 1 TiB) UDF partition.

Changes since V1:
* Fixed additional issues noted in udf_bitmap_free_blocks(),
  udf_get_fileident(), udf_show_options()

Signed-off-by: Steven J. Magnani 
Signed-off-by: Jan Kara

udf: Fix 64-bit sign extension issues affecting blocks > 0x7FFFFFFF

2017-10-17T09:56:45+00:00

Large (> 1 TiB) UDF filesystems appear subject to several problems when
mounted on 64-bit systems:

* readdir() can fail on a directory containing File Identifiers residing
  above 0x7FFFFFFF. This manifests as a 'ls' command failing with EIO.

* FIBMAP on a file block located above 0x7FFFFFFF can return a negative
  value. The low 32 bits are correct, but applications that don't mask the
  high 32 bits of the result can perform incorrectly.

Per suggestion by Jan Kara, introduce a udf_pblk_t type for representation
of UDF block addresses. Ultimately, all driver functions that manipulate
UDF block addresses should use this type; for now, deployment is limited
to functions with actual or potential sign extension issues.

Changes to udf_readdir() and udf_block_map() address the issues noted
above; other changes address potential similar issues uncovered during
audit of the driver code.

Signed-off-by: Steven J. Magnani 
Signed-off-by: Jan Kara

udf: remove empty condition

2017-01-10T10:37:31+00:00

loc & 0x02 is empty since first git version in 2005 in
udf_add_extendedattr()

Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: remove redundant buffer_head.h includes

2015-03-14T06:54:02+00:00

buffer_head.h was already included in udfdecl.h

Signed-off-by: Fabian Frederick 
Signed-off-by: Jan Kara

udf: Rename udf_error to udf_err

2011-10-10T17:29:01+00:00

Rename udf_error to udf_err for consistency with normal logging
uses of pr_err.

Rename function udf_err to _udf_err.
Remove __func__ from uses and move __func__ to a new udf_err
macro that calls _udf_err.
Some of the udf_error uses had \n terminations, some did not so
standardize \n's to udf_err uses, remove \n from _udf_err function.
Coalesce udf_err formats.
One message prefixed with udf_read_super is now prefixed with
udf_fill_super.

Reviewed-by: NamJae Jeon 
Signed-off-by: Joe Perches 
Signed-off-by: Jan Kara

udf: Promote some debugging messages to udf_error

2011-10-10T17:26:24+00:00

If there is a problem with a scratched disc or loader, it's valuable to know
which error occurred.

Convert some debug messages to udf_error, neaten those messages too.
Add the calculated tag checksum and the read checksum to error message.
Make udf_error a public function and move the logging prototypes together.

Original-patch-by: NamJae Jeon 
Reviewed-by: NamJae Jeon 
Signed-off-by: Joe Perches 
Signed-off-by: Jan Kara

Fix the udf code not to pass structs on stack where possible.

2009-04-02T10:29:47+00:00

Signed-off-by: Pekka Enberg 
Signed-off-by: Jan Kara

Remove struct typedefs from fs/udf/ecma_167.h et al.

2009-04-02T10:29:47+00:00

Signed-off-by: Pekka Enberg 
Signed-off-by: Jan Kara

udf: use crc_itu_t from lib instead of udf_crc

2008-04-17T12:29:56+00:00

As pointed out by Sergey Vlasov, UDF implements its own version of
the CRC ITU-T V.41.  Convert it to use the one in the library.

Signed-off-by: Bob Copeland 
Cc: Sergey Vlasov 
Signed-off-by: Jan Kara

udf: Fix handling of multisession media

2008-04-17T12:28:33+00:00

According to OSTA UDF specification, only anchor blocks and primary volume
descriptors are placed on media relative to the last session. All other block
numbers are absolute (in the partition or the whole media). This seems to be
confirmed by multisession media created by other systems.

Signed-off-by: Sebastian Manciulea 
Signed-off-by: Jan Kara