linux.git/fs/udf/ialloc.c, branch v2.6.28

udf: Fix error paths in udf_new_inode()

2008-08-19T09:05:05+00:00

I case we failed to allocate memory for inode when creating it, we did not
properly free block already allocated for this inode. Move memory allocation
before the block allocation which fixes this issue (thanks for the idea go to
Ingo Oeser ). Also remove a few superfluous
initializations already done in udf_alloc_inode().

Reviewed-by: Ingo Oeser 
Signed-off-by: Jan Kara

udf: Fix lock inversion between iprune_mutex and alloc_mutex (v2)

2008-08-19T09:04:36+00:00

A memory allocation inside alloc_mutex must not recurse back into the
filesystem itself because that leads to lock inversion between iprune_mutex and
alloc_mutex (and thus to deadlocks - see traces below). alloc_mutex is actually
needed only to update allocation statistics in the superblock so we can drop it
before we start allocating memory for the inode.

tar           D ffff81015b9c8c90     0  6614   6612
 ffff8100d5a21a20 0000000000000086 0000000000000000 00000000ffff0000
 ffff81015b9c8c90 ffff81015b8f0cd0 ffff81015b9c8ee0 0000000000000000
 0000000000000003 0000000000000000 0000000000000000 0000000000000000
Call Trace:
 [] __mutex_lock_slowpath+0x64/0x9b
 [] mutex_lock+0xa/0xb
 [] shrink_icache_memory+0x38/0x200
 [] shrink_slab+0xe3/0x15b
 [] try_to_free_pages+0x221/0x30d
 [] isolate_pages_global+0x0/0x31
 [] __alloc_pages_internal+0x252/0x3ab
 [] cache_alloc_refill+0x22e/0x47b
 [] kmem_cache_alloc+0x3b/0x61
 [] cache_alloc_refill+0x2fe/0x47b
 [] __kmalloc+0x76/0x9c
 [] :udf:udf_new_inode+0x202/0x2e2
 [] :udf:udf_create+0x2f/0x16d
 [] :udf:udf_lookup+0xa6/0xad
...
kswapd0       D ffff81015b9d9270     0   125      2
 ffff81015b903c28 0000000000000046 ffffffff8028cbb0 00000000fffffffb
 ffff81015b9d9270 ffff81015b8f0cd0 ffff81015b9d94c0 000000000271b490
 ffffe2000271b458 ffffe2000271b420 ffffe20002728dc8 ffffe20002728d90
Call Trace:
 [] __set_page_dirty+0xeb/0xf5
 [] get_dirty_limits+0x1d/0x22f
 [] __mutex_lock_slowpath+0x64/0x9b
 [] mutex_lock+0xa/0xb
 [] :udf:udf_bitmap_free_blocks+0x47/0x1eb
 [] :udf:udf_discard_prealloc+0xc6/0x172
 [] :udf:udf_clear_inode+0x1e/0x48
 [] clear_inode+0x6d/0xc4
 [] dispose_list+0x56/0xee
 [] shrink_icache_memory+0x1d0/0x200
 [] shrink_slab+0xe3/0x15b
 [] kswapd+0x346/0x447
...

Reported-by: Tibor Tajti 
Reviewed-by: Ingo Oeser 
Signed-off-by: Jan Kara

udf: replace all adds to little endians variables with le*_add_cpu

2008-04-17T12:22:28+00:00

replace all:
	little_endian_variable = cpu_to_leX(leX_to_cpu(little_endian_variable) +
	                                    expression_in_cpu_byteorder);
with:
	leX_add_cpu(&little_endian_variable, expression_in_cpu_byteorder);
sparse didn't generate any new warning with this patch

Signed-off-by: Marcin Slusarz

udf: move headers out include/linux/

2008-04-17T12:22:23+00:00

There's really no reason to keep udf headers in include/linux as they're
not used by anything but fs/udf/.

This patch merges most of include/linux/udf_fs_i.h into fs/udf/udf_i.h,
include/linux/udf_fs_sb.h into fs/udf/udf_sb.h and
include/linux/udf_fs.h into fs/udf/udfdecl.h.

The only thing remaining in include/linux/ is a stub of udf_fs_i.h
defining the four user-visible udf ioctls.  It's also moved from
unifdef-y to headers-y because it can be included unconditionally now.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Jan Kara

udf: cache struct udf_inode_info

2008-02-08T17:22:35+00:00

cache UDF_I(struct inode *) return values when there are
at least 2 uses in one function

Signed-off-by: Marcin Slusarz 
Acked-by: Jan Kara 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

udf: remove UDF_I_* macros and open code them

2008-02-08T17:22:35+00:00

Signed-off-by: Marcin Slusarz 
Acked-by: Jan Kara 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

udf: fix coding style

2008-02-08T17:22:35+00:00

fix coding style errors found by checkpatch:
- assignments in if conditions
- braces {} around single statement blocks
- no spaces after commas
- printks without KERN_*
- lines longer than 80 characters
- spaces between "type *" and variable name

before: 192 errors, 561 warnings, 8987 lines checked
after: 1 errors, 38 warnings, 9468 lines checked

Signed-off-by: Marcin Slusarz 
Cc: Jan Kara 
Cc: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

udf: remove some ugly macros

2008-02-08T17:22:34+00:00

remove macros:
- UDF_SB_PARTMAPS
- UDF_SB_PARTTYPE
- UDF_SB_PARTROOT
- UDF_SB_PARTLEN
- UDF_SB_PARTVSN
- UDF_SB_PARTNUM
- UDF_SB_TYPESPAR
- UDF_SB_TYPEVIRT
- UDF_SB_PARTFUNC
- UDF_SB_PARTFLAGS
- UDF_SB_VOLIDENT
- UDF_SB_NUMPARTS
- UDF_SB_PARTITION
- UDF_SB_SESSION
- UDF_SB_ANCHOR
- UDF_SB_LASTBLOCK
- UDF_SB_LVIDBH
- UDF_SB_LVID
- UDF_SB_UMASK
- UDF_SB_GID
- UDF_SB_UID
- UDF_SB_RECORDTIME
- UDF_SB_SERIALNUM
- UDF_SB_UDFREV
- UDF_SB_FLAGS
- UDF_SB_VAT
- UDF_UPDATE_UDFREV
- UDF_SB_FREE
and open code them

convert UDF_SB_LVIDIU macro to udf_sb_lvidiu function

rename some struct udf_sb_info fields:
- s_volident to s_volume_ident
- s_lastblock to s_last_block
- s_lvidbh to s_lvid_bh
- s_recordtime to s_record_time
- s_serialnum to s_serial_number;
- s_vat to s_vat_inode;

Signed-off-by: Marcin Slusarz 
Cc: Ben Fennema 
Cc: Jan Kara 
Acked-by: Christoph Hellwig 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

UDF: coding style conversion - lindent fixups

2007-07-22T00:49:14+00:00

This patch fixes up sources after conversion by Lindent.

Signed-off-by: Cyrill Gorcunov 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

UDF: coding style conversion - lindent

2007-07-19T17:04:43+00:00

This patch converts UDF coding style to kernel coding style using Lindent.

Signed-off-by: Cyrill Gorcunov 
Cc: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds