linux.git/fs/sysfs/inode.c, branch v2.6.33

sysfs: sysfs_sd_setattr set iattrs unconditionally

2010-02-16T23:42:42+00:00

There is currently a bug in sysfs_sd_setattr inherited from
sysfs_setattr in 2.6.32 where the first time we set the attributes
on a sysfs file we allocate backing store but do not set the
backing store attributes.  Resulting in overly restrictive
permissions on sysfs files.

The fix is to simply modify the code so that it always executes
when we update the sysfs attributes, as we did in 2.6.31 and earlier.

Signed-off-by: Eric W. Biederman 
Tested-by: Jean Delvare 
Cc: stable 
Signed-off-by: Greg Kroah-Hartman

sysfs: sysfs_setattr remove unnecessary permission check.

2009-12-11T19:24:54+00:00

inode_change_ok already clears the SGID bit when necessary
so there is no reason for sysfs_setattr to carry code to do
the same, and it is good to kill the extra copy because when
I moved the code last in certain corner cases the code will
look at the wrong gid.

Acked-by: Serge Hallyn 
Acked-by: Tejun Heo 
Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: Propagate renames to the vfs on demand

2009-12-11T19:24:54+00:00

By teaching sysfs_revalidate to hide a dentry for
a sysfs_dirent if the sysfs_dirent has been renamed,
and by teaching sysfs_lookup to return the original
dentry if the sysfs dirent has been renamed.  I can
show the results of renames correctly without having to
update the dcache during the directory rename.

This massively simplifies the rename logic allowing a lot
of weird sysfs special cases to be removed along with
a lot of now unnecesary helper code.

Acked-by: Tejun Heo 
Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: Implement sysfs_getattr & sysfs_permission

2009-12-11T19:24:54+00:00

With the implementation of sysfs_getattr and sysfs_permission
sysfs becomes able to lazily propogate inode attribute changes
from the sysfs_dirents to the vfs inodes.   This paves the way
for deleting significant chunks of now unnecessary code.

While doing this we did not reference sysfs_setattr from
sysfs_symlink_inode_operations so I added along with
sysfs_getattr and sysfs_permission.

Acked-by: Tejun Heo 
Acked-by: Serge Hallyn 
Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: Fix locking and factor out sysfs_sd_setattr

2009-12-11T19:24:53+00:00

Cleanly separate the work that is specific to setting the
attributes of a sysfs_dirent from what is needed to update
the attributes of a vfs inode.

Additionally grab the sysfs_mutex to keep any nasties from
surprising us when updating the sysfs_dirent.

Acked-by: Tejun Heo 
Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: Simplify iattr time assignments

2009-12-11T19:24:53+00:00

The granularity of sysfs time when we keep it is 1 ns.  Which
when passed to timestamp_trunc results in a nop.  So remove
the unnecessary function call making sysfs_setattr slightly
easier to read.

Acked-by: Tejun Heo 
Acked-by: Serge Hallyn 
Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: Update sysfs_setxattr so it updates secdata under the sysfs_mutex

2009-12-11T19:24:53+00:00

The sysfs_mutex is required to ensure updates are and will remain
atomic with respect to other inode iattr updates, that do not happen
through the filesystem.

Acked-by: Serge Hallyn 
Acked-by: Tejun Heo 
Signed-off-by: Eric W. Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: mark a locally-only used function static

2009-12-11T19:24:51+00:00

Signed-off-by: Stefan Richter 
Acked-by: David P. Quigley 
Signed-off-by: Greg Kroah-Hartman

Merge branch 'writeback' of git://git.kernel.dk/linux-2.6-block

2009-09-11T16:17:05+00:00

* 'writeback' of git://git.kernel.dk/linux-2.6-block:
  writeback: check for registered bdi in flusher add and inode dirty
  writeback: add name to backing_dev_info
  writeback: add some debug inode list counters to bdi stats
  writeback: get rid of pdflush completely
  writeback: switch to per-bdi threads for flushing data
  writeback: move dirty inodes from super_block to backing_dev_info
  writeback: get rid of generic_sync_sb_inodes() export

writeback: add name to backing_dev_info

2009-09-11T07:20:26+00:00

This enables us to track who does what and print info. Its main use
is catching dirty inodes on the default_backing_dev_info, so we can
fix that up.

Signed-off-by: Jens Axboe