linux.git/fs/sysfs/inode.c, branch v2.6.23

sysfs: make sysfs_init_inode() static

2007-07-18T22:49:49+00:00

With sysfs_fill_super() converted to use sysfs_get_inode(), there is
no user of sysfs_init_inode() outside of fs/sysfs/inode.c.  Make it
static.

Signed-off-by: Tejun Heo 
Acked-by: Jean Delvare 
Signed-off-by: Greg Kroah-Hartman

sysfs: move sysfs_drop_dentry() to dir.c and make it static

2007-07-11T23:09:09+00:00

After add/remove path restructuring, the only user of
sysfs_drop_dentry() is sysfs_addrm_finish().  Move sysfs_drop_dentry()
to dir.c and make it static.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: restructure add/remove paths and fix inode update

2007-07-11T23:09:09+00:00

The original add/remove code had the following problems.

* parent's timestamps are updated on dentry instantiation.  this is
  incorrect with reclaimable files.

* updating parent's timestamps isn't synchronized.

* parent nlink update assumes the inode is accessible which won't be
  true once directory dentries are made reclaimable.

This patch restructures add/remove paths to resolve the above
problems.  Add/removal are done in the following steps.

1. sysfs_addrm_start() : acquire locks including sysfs_mutex and other
   resources.

2-a. sysfs_add_one() : add new sd.  linking the new sd into the
     children list is caller's responsibility.

2-b. sysfs_remove_one() : remove a sd.  unlinking the sd from the
     children list is caller's responsibility.

3. sysfs_addrm_finish() : release all resources and clean up.

Steps 2-a and/or 2-b can be repeated multiple times.

Parent's inode is looked up during sysfs_addrm_start().  If available
(always at the moment), it's pinned and nlink is updated as sd's are
added and removed.  Timestamps are updated during finish if any sd has
been added or removed.  If parent's inode is not available during
start, sysfs_mutex ensures that parent inode is not created till
add/remove is complete.

All the complexity is contained inside the helper functions.
Especially, dentry/inode handling is properly hidden from the rest of
sysfs which now mostly operate on sysfs_dirents.  As an added bonus,
codes which use these helpers to add and remove sysfs_dirents are now
more structured and simpler.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: use sysfs_mutex to protect the sysfs_dirent tree

2007-07-11T23:09:08+00:00

As kobj sysfs dentries and inodes are gonna be made reclaimable,
i_mutex can't be used to protect sysfs_dirent tree.  Use sysfs_mutex
globally instead.  As the whole tree is protected with sysfs_mutex,
there is no reason to keep sysfs_rename_sem.  Drop it.

While at it, add docbook comments to functions which require
sysfs_mutex locking.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: consolidate sysfs spinlocks

2007-07-11T23:09:08+00:00

Replace sysfs_lock and kobj_sysfs_assoc_lock with sysfs_assoc_lock.
sysfs_lock was originally to be used to protect sysfs_dirent tree but
mutex seems better choice, so there is no reason to keep sysfs_lock
separate.  Merge the two spinlocks into one.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: make kobj point to sysfs_dirent instead of dentry

2007-07-11T23:09:08+00:00

As kobj sysfs dentries and inodes are gonna be made reclaimable,
dentry can't be used as naming token for sysfs file/directory, replace
kobj->dentry with kobj->sd.  The only external interface change is
shadow directory handling.  All other changes are contained in kobj
and sysfs.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: implement SYSFS_FLAG_REMOVED flag

2007-07-11T23:09:08+00:00

Implement SYSFS_FLAG_REMOVED flag which currently is used only to
improve sanity check in sysfs_deactivate().  The flag will be used to
make directory entries reclamiable.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: rename sysfs_dirent->s_type to s_flags and make room for flags

2007-07-11T23:09:08+00:00

Rename sysfs_dirent->s_type to s_flags, pack type into lower eight
bits and reserve the rest for flags.  sysfs_type() can used to access
the type.  All existing sd->s_type accesses are converted to use
sysfs_type().  While at it, type test is changed to equality test
instead of bit-and test where appropriate.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: make sysfs_drop_dentry() access inodes using ilookup()

2007-07-11T23:09:08+00:00

sysfs_drop_dentry() used to go through sd->s_dentry and
sd->s_parent->s_dentry to access the inodes.  This is incorrect
because inode can be cached without dentry.

This patch makes sysfs_drop_dentry() access inodes using ilookup() on
sd->s_ino.  This is both correct and simpler.

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: Fix oops in sysfs_drop_dentry on x86_64

2007-07-11T23:09:07+00:00

Fix oops on x86_64 caused by the dereference of dir in
sysfs_drop_dentry() made before checking if dir is not NULL
(cf. http://marc.info/?l=linux-kernel&m=118151626704924&w=2).

Signed-off-by: Rafael J. Wysocki 
Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman