linux.git/fs/sysfs/bin.c, branch v2.6.30

sysfs: use memdup_user()

2009-04-21T03:02:50+00:00

Remove open-coded memdup_user().

Signed-off-by: Li Zefan 
Signed-off-by: Al Viro

mm: page_mkwrite change prototype to match fault: fix sysfs

2009-04-01T15:59:14+00:00

Fix warnings and return values in sysfs bin_page_mkwrite(), fixing
fs/sysfs/bin.c: In function `bin_page_mkwrite':
fs/sysfs/bin.c:250: warning: passing argument 2 of `bb->vm_ops->page_mkwrite' from incompatible pointer type
fs/sysfs/bin.c: At top level:
fs/sysfs/bin.c:280: warning: initialization from incompatible pointer type

Expects to have my [PATCH next] sysfs: fix some bin_vm_ops errors

Signed-off-by: Hugh Dickins 
Cc: Nick Piggin 
Cc: "Eric W. Biederman" 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

sysfs: fix some bin_vm_ops errors

2009-03-24T23:38:26+00:00

Commit 86c9508eb1c0ce5aa07b5cf1d36b60c54efc3d7a
"sysfs: don't block indefinitely for unmapped files" in linux-next
crashes the PowerMac G5 when X starts up.  It's caught out by the way
powerpc's pci_mmap of legacy_mem uses shmem_zero_setup(), substituting
a new vma->vm_file whose private_data no longer points to the bin_buffer
(substitution done because some versions of X crash if that mmap fails).

The fix to this is straightforward: the original vm_file is fput() in
that case, so this mmap won't block sysfs at all, so just don't switch
over to bin_vm_ops if vm_file has changed.

But more fixes made before realizing that was the problem:-

It should not be an error if bin_page_mkwrite() finds no underlying
page_mkwrite().

Check that a file already mmap'ed has the same underlying vm_ops
_before_ pointing vma->vm_ops at bin_vm_ops.

If the file being mmap'ed is a shmem/tmpfs file, don't fail the mmap
on CONFIG_NUMA=y, just because that has a set_policy and get_policy:
provide bin_set_policy, bin_get_policy and bin_migrate.

Signed-off-by: Hugh Dickins 
Acked-by: Eric Biederman 
Signed-off-by: Greg Kroah-Hartman

sysfs: don't block indefinitely for unmapped files.

2009-03-24T23:38:26+00:00

Modify sysfs bin files so that we can remove the bin file while they are
still mapped.  When the kobject is removed we unmap the bin file and
arrange for future accesses to the mapping to receive SIGBUS.

Implementing this prevents a nasty DOS when pci devices are hot plugged
and unplugged.  Where if any of their resources were mmaped the kernel
could not free up their pci resources or release their pci data
structures.

[akpm@linux-foundation.org: remove unused var]
Signed-off-by: Eric W. Biederman 
Cc: Jesse Barnes 
Acked-by: Tejun Heo 
Cc: Kay Sievers 
Signed-off-by: Andrew Morton 
Signed-off-by: Greg Kroah-Hartman

sysfs: fix problems with binary files

2009-01-21T04:52:09+00:00

Some sysfs binary files don't like having 0 passed to them as a size.
Fix this up at the root by just returning to the vfs if userspace asks
us for a zero sized buffer.

Thanks to Pavel Roskin for pointing this out.

Reported-by: Pavel Roskin 
Signed-off-by: Greg Kroah-Hartman

sysfs: fix deadlock

2008-10-16T16:24:50+00:00

On Thu, Sep 11, 2008 at 10:27:10AM +0200, Ingo Molnar wrote:

> and it's working fine on most boxes. One testbox found this new locking
> scenario:
>
> PM: Adding info for No Bus:vcsa7
> EDAC DEBUG: MC0: i82860_check()
>
> =======================================================
> [ INFO: possible circular locking dependency detected ]
> 2.6.27-rc6-tip #1
> -------------------------------------------------------
> X/4873 is trying to acquire lock:
>  (&bb->mutex){--..}, at: [] mmap+0x40/0xa0
>
> but task is already holding lock:
>  (&mm->mmap_sem){----}, at: [] sys_mmap2+0x8e/0xc0
>
> which lock already depends on the new lock.
>
>
> the existing dependency chain (in reverse order) is:
>
> -> #1 (&mm->mmap_sem){----}:
>        [] validate_chain+0xa96/0xf50
>        [] __lock_acquire+0x2cb/0x5b0
>        [] lock_acquire+0x89/0xc0
>        [] might_fault+0x6b/0x90
>        [] copy_to_user+0x38/0x60
>        [] read+0xfb/0x170
>        [] vfs_read+0x95/0x110
>        [] sys_pread64+0x63/0x80
>        [] sysenter_do_call+0x12/0x43
>        [] 0xffffffff
>
> -> #0 (&bb->mutex){--..}:
>        [] validate_chain+0x6b7/0xf50
>        [] __lock_acquire+0x2cb/0x5b0
>        [] lock_acquire+0x89/0xc0
>        [] __mutex_lock_common+0xab/0x3c0
>        [] mutex_lock_nested+0x38/0x50
>        [] mmap+0x40/0xa0
>        [] mmap_region+0x14e/0x450
>        [] do_mmap_pgoff+0x2ef/0x310
>        [] sys_mmap2+0xad/0xc0
>        [] sysenter_do_call+0x12/0x43
>        [] 0xffffffff
>
> other info that might help us debug this:
>
> 1 lock held by X/4873:
>  #0:  (&mm->mmap_sem){----}, at: [] sys_mmap2+0x8e/0xc0
>
> stack backtrace:
> Pid: 4873, comm: X Not tainted 2.6.27-rc6-tip #1
>  [] print_circular_bug_tail+0x79/0xc0
>  [] validate_chain+0x6b7/0xf50
>  [] ? trace_hardirqs_off_caller+0x15/0xb0
>  [] __lock_acquire+0x2cb/0x5b0
>  [] lock_acquire+0x89/0xc0
>  [] ? mmap+0x40/0xa0
>  [] __mutex_lock_common+0xab/0x3c0
>  [] ? mmap+0x40/0xa0
>  [] mutex_lock_nested+0x38/0x50
>  [] ? mmap+0x40/0xa0
>  [] mmap+0x40/0xa0
>  [] mmap_region+0x14e/0x450
>  [] ? arch_get_unmapped_area_topdown+0xf8/0x160
>  [] do_mmap_pgoff+0x2ef/0x310
>  [] sys_mmap2+0xad/0xc0
>  [] sysenter_do_call+0x12/0x43
>  [] ? __switch_to+0x130/0x220
>  =======================
> evbug.c: Event. Dev: input3, Type: 20, Code: 0, Value: 500
> warning: `sudo' uses deprecated v2 capabilities in a way that may be insecure.
>
> i've attached the config.
>
> at first sight it looks like a genuine bug in fs/sysfs/bin.c?

Yes, it is a real bug by the looks. bin.c takes bb->mutex under mmap_sem
when it is mmapped, and then does its copy_*_user under bb->mutex too.

Here is a basic fix for the sysfs lor.


From: Nick Piggin 
Signed-off-by: Ingo Molnar 
Signed-off-by: Greg Kroah-Hartman

sysfs: add copyrights

2007-10-12T21:51:12+00:00

Sysfs has gone through considerable amount of reimplementation.  Add
copyrights.  Any objections?  :-)

Signed-off-by: Tejun Heo 
Signed-off-by: Greg Kroah-Hartman

sysfs: make s_elem an anonymous union

2007-10-12T21:51:10+00:00

Make s_elem an anonymous union.  Prefixing with s_elem makes things
needlessly longer without any advantage.

Signed-off-by: Tejun Heo 
Acked-by: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman

sysfs: make bin attr open get active reference of parent too

2007-10-12T21:51:10+00:00

All bin attr operations require active references of itself and its
parent.  There's no reason to allow open when its parent has been
deactivated and allowing it is inconsistent with regular sysfs file.
Use sysfs_get_active_two() in bin attribute open function.

Signed-off-by: Tejun Heo 
Acked-by: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman

sysfs: kill unnecessary sysfs_get() in open paths

2007-10-12T21:51:10+00:00

There's no reason to get an extra reference to sysfs_dirent for an
open file.  Open file has a reference to the dentry which in turn has
a reference to sysfs_dirent.  This is fairly obvious as otherwise open
itself won't be able to access the sysfs_dirent.  Kill the extra
sysfs_get() and matching sysfs_put().

Signed-off-by: Tejun Heo 
Acked-by: Cornelia Huck 
Signed-off-by: Greg Kroah-Hartman