linux.git/fs/splice.c, branch v2.6.19

[PATCH] splice: fix problem introduced with inode diet

2006-11-04T16:45:39+00:00

After the inode slimming patch that unionised i_pipe/i_bdev/i_cdev, it's
no longer enough to check for existance of ->i_pipe to verify that this
is a pipe.

Original patch from Eric Dumazet 
Final solution suggested by Linus.

Signed-off-by: Jens Axboe 
Signed-off-by: Linus Torvalds

[PATCH] mm: clean up pagecache allocation

2006-10-28T18:30:50+00:00

- Consolidate page_cache_alloc

- Fix splice: only the pagecache pages and filesystem data need to use
  mapping_gfp_mask.

- Fix grab_cache_page_nowait: same as splice, also honour NUMA placement.

Signed-off-by: Nick Piggin 
Cc: Jens Axboe 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[PATCH] Remove SUID when splicing into an inode

2006-10-19T18:53:09+00:00

Originally from Mark Fasheh 

generic_file_splice_write() does not remove S_ISUID or S_ISGID. This is
inconsistent with the way we generally write to files.

Signed-off-by: Mark Fasheh 
Signed-off-by: Jens Axboe

[PATCH] Introduce generic_file_splice_write_nolock()

2006-10-19T18:53:08+00:00

This allows file systems to manage their own i_mutex locking while
still re-using the generic_file_splice_write() logic.

OCFS2 in particular wants this so that it can order cluster locks within
i_mutex.

Signed-off-by: Mark Fasheh 
Signed-off-by: Jens Axboe

[PATCH] Take i_mutex in splice_from_pipe()

2006-10-19T18:53:08+00:00

The splice_actor may be calling ->prepare_write() and ->commit_write(). We
want i_mutex on the inode being written to before calling those so that we
don't race i_size changes.

The double locking behavior is done elsewhere in splice.c, and if we
eventually want _nolock variants of generic_file_splice_write(), fs modules
might have to replicate the nasty locking code. We introduce
inode_double_lock() and inode_double_unlock() to consolidate the locking
rules into one set of functions.

Signed-off-by: Mark Fasheh 
Signed-off-by: Jens Axboe

[PATCH] splice: fix pipe_to_file() ->prepare_write() error path

2006-10-12T13:08:51+00:00

Don't jump to the unlock+release path, we already did that.

Signed-off-by: Jens Axboe

[PATCH] Update axboe@suse.de email address

2006-09-30T18:52:34+00:00

As people often look for the copyright in files to see who to mail,
update the link to a neutral one.

Signed-off-by: Jens Axboe

[PATCH] splice: fix problems with sys_tee()

2006-07-10T09:00:01+00:00

Several issues noticed/fixed:

- We cannot reliably block in link_pipe() while holding both input and output
  mutexes. So do preparatory checks before locking down both mutexes and doing
  the link.

- The ipipe->nrbufs vs i check was bad, because we could have dropped the
  ipipe lock in-between. This causes us to potentially look at unknown
  buffers if we were racing with someone else reading this pipe.

Signed-off-by: Jens Axboe

[PATCH] splice: retrieve mapping after locking the page

2006-06-23T15:10:39+00:00

Otherwise we could be racing with truncate/mapping removal.

Problem found/fixed by Nick Piggin , logic rewritten
by me.

Signed-off-by: Jens Axboe

[PATCH] splice: redo page lookup if add_to_page_cache() returns -EEXIST

2006-05-04T04:55:12+00:00

This can happen quite easily, if several processes are trying to splice
the same file at the same time. It's not a failure, it just means someone
raced with us in allocating this file page. So just dump the allocated
page and relookup the original.

Signed-off-by: Jens Axboe