linux.git/fs/pstore, branch v6.10

pstore/zone: Don't clear memory twice

2024-03-09T20:33:22+00:00

There is no need to call memset(..., 0, ...) on memory allocated by
kcalloc(). It is already zeroed.

Remove the redundant call.

Signed-off-by: Christophe JAILLET 
Link: https://lore.kernel.org/r/fa2597400051c18c6ca11187b0e4b906729991b2.1709972649.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Kees Cook

pstore/zone: Add a null pointer check to the psz_kmsg_read

2024-02-22T18:37:22+00:00

kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: Kunwu Chan 
Link: https://lore.kernel.org/r/20240118100206.213928-1-chentao@kylinos.cn
Signed-off-by: Kees Cook

pstore/ram: Register to module device table

2024-02-22T18:37:21+00:00

Register the compatible for this module on the module device table so
it can be automatically loaded when a matching DT node is present,
allowing logging of panics and oopses without any intervention.

Signed-off-by: Nícolas F. R. A. Prado 
Reviewed-by: Kees Cook 
Reviewed-by: AngeloGioacchino Del Regno 
Link: https://lore.kernel.org/r/20240110210600.787703-2-nfraprado@collabora.com
Signed-off-by: Kees Cook

pstore: inode: Only d_invalidate() is needed

2024-02-22T18:37:21+00:00

Unloading a modular pstore backend with records in pstorefs would
trigger the dput() double-drop warning:

  WARNING: CPU: 0 PID: 2569 at fs/dcache.c:762 dput.part.0+0x3f3/0x410

Using the combo of d_drop()/dput() (as mentioned in
Documentation/filesystems/vfs.rst) isn't the right approach here, and
leads to the reference counting problem seen above. Use d_invalidate()
and update the code to not bother checking for error codes that can
never happen.

Suggested-by: Alexander Viro 
Fixes: 609e28bb139e ("pstore: Remove filesystem records when backend is unregistered")
Signed-off-by: Kees Cook 
---
Cc: "Guilherme G. Piccoli" 
Cc: Tony Luck 
Cc: linux-hardening@vger.kernel.org

pstore: inode: Use cleanup.h for struct pstore_private

2023-12-08T22:15:44+00:00

Simplify error path when "private" needs to be freed.

Cc: Guilherme G. Piccoli 
Cc: Tony Luck 
Cc:  
Link: https://lore.kernel.org/r/20231205182622.1329923-4-keescook@chromium.org
Signed-off-by: Kees Cook

pstore: inode: Use __free(pstore_iput) for inode allocations

2023-12-08T22:15:44+00:00

Simplify error path for failures where "inode" needs to be freed.

Cc: Guilherme G. Piccoli 
Cc: Tony Luck 
Cc:  
Link: https://lore.kernel.org/r/20231205182622.1329923-3-keescook@chromium.org
Signed-off-by: Kees Cook

pstore: inode: Convert mutex usage to guard(mutex)

2023-12-08T22:15:44+00:00

Replace open-coded mutex handling with cleanup.h guard(mutex) and
scoped_guard(mutex, ...).

Cc: Guilherme G. Piccoli 
Cc: Tony Luck 
Cc:  
Link: https://lore.kernel.org/r/20231205182622.1329923-2-keescook@chromium.org
Signed-off-by: Kees Cook

pstore: inode: Convert kfree() usage to __free(kfree)

2023-12-08T22:15:44+00:00

Mostly as an example to myself, replace a simple allocation pattern with
the automatic kfree cleanup features now exposed by cleanup.h.

Cc: Guilherme G. Piccoli 
Cc: Tony Luck 
Cc:  
Link: https://lore.kernel.org/r/20231205182622.1329923-1-keescook@chromium.org
Signed-off-by: Kees Cook

pstore: ram_core: fix possible overflow in persistent_ram_init_ecc()

2023-12-08T22:15:00+00:00

In persistent_ram_init_ecc(), on 64-bit arches DIV_ROUND_UP() will return
64-bit value since persistent_ram_zone::buffer_size has type size_t which
is derived from the 64-bit *unsigned long*, while the ecc_blocks variable
this value gets assigned to has (always 32-bit) *int* type.  Even if that
value fits into *int* type, an overflow is still possible when calculating
the size_t typed ecc_total variable further below since there's no cast to
any 64-bit type before multiplication.  Declaring the ecc_blocks variable
as *size_t* should fix this mess...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: 9cc05ad97c57 ("staging: android: persistent_ram: refactor ecc support")
Signed-off-by: Sergey Shtylyov 
Link: https://lore.kernel.org/r/20231105202936.25694-1-s.shtylyov@omp.ru
Signed-off-by: Kees Cook

pstore/ram: Fix crash when setting number of cpus to an odd number

2023-12-08T22:15:00+00:00

When the number of cpu cores is adjusted to 7 or other odd numbers,
the zone size will become an odd number.
The address of the zone will become:
    addr of zone0 = BASE
    addr of zone1 = BASE + zone_size
    addr of zone2 = BASE + zone_size*2
    ...
The address of zone1/3/5/7 will be mapped to non-alignment va.
Eventually crashes will occur when accessing these va.

So, use ALIGN_DOWN() to make sure the zone size is even
to avoid this bug.

Signed-off-by: Weichen Chen 
Reviewed-by: Matthias Brugger 
Tested-by: "Guilherme G. Piccoli" 
Link: https://lore.kernel.org/r/20230224023632.6840-1-weichen.chen@mediatek.com
Signed-off-by: Kees Cook