linux.git/fs/pstore, branch v4.11

fs/pstore: fs/squashfs: change usage of LZ4 to work with new LZ4 version

2017-02-25T01:46:57+00:00

Update fs/pstore and fs/squashfs to use the updated functions from the
new LZ4 module.

Link: http://lkml.kernel.org/r/1486321748-19085-5-git-send-email-4sschmid@informatik.uni-hamburg.de
Signed-off-by: Sven Schmidt <4sschmid@informatik.uni-hamburg.de>
Cc: Bongkyu Kim 
Cc: Rui Salvaterra 
Cc: Sergey Senozhatsky 
Cc: Greg Kroah-Hartman 
Cc: Herbert Xu 
Cc: David S. Miller 
Cc: Anton Vorontsov 
Cc: Colin Cross 
Cc: Kees Cook 
Cc: Tony Luck 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

pstore: Check for prz allocation in walker

2017-02-13T18:25:52+00:00

Instead of needing additional checks in callers for unallocated przs,
perform the check in the walker, which gives us a more universal way to
handle the situation.

Signed-off-by: Kees Cook

pstore: Correctly initialize spinlock and flags

2017-02-13T18:25:52+00:00

The ram backend wasn't always initializing its spinlock correctly. Since
it was coming from kzalloc memory, though, it was harmless on
architectures that initialize unlocked spinlocks to 0 (at least x86 and
ARM). This also fixes a possibly ignored flag setting too.

When running under CONFIG_DEBUG_SPINLOCK, the following Oops was visible:

[    0.760836] persistent_ram: found existing buffer, size 29988, start 29988
[    0.765112] persistent_ram: found existing buffer, size 30105, start 30105
[    0.769435] persistent_ram: found existing buffer, size 118542, start 118542
[    0.785960] persistent_ram: found existing buffer, size 0, start 0
[    0.786098] persistent_ram: found existing buffer, size 0, start 0
[    0.786131] pstore: using zlib compression
[    0.790716] BUG: spinlock bad magic on CPU#0, swapper/0/1
[    0.790729]  lock: 0xffffffc0d1ca9bb0, .magic: 00000000, .owner: /-1, .owner_cpu: 0
[    0.790742] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.10.0-rc2+ #913
[    0.790747] Hardware name: Google Kevin (DT)
[    0.790750] Call trace:
[    0.790768] [] dump_backtrace+0x0/0x2bc
[    0.790780] [] show_stack+0x20/0x28
[    0.790794] [] dump_stack+0xa4/0xcc
[    0.790809] [] spin_dump+0xe0/0xf0
[    0.790821] [] spin_bug+0x30/0x3c
[    0.790834] [] do_raw_spin_lock+0x50/0x1b8
[    0.790846] [] _raw_spin_lock_irqsave+0x54/0x6c
[    0.790862] [] buffer_size_add+0x48/0xcc
[    0.790875] [] persistent_ram_write+0x60/0x11c
[    0.790888] [] ramoops_pstore_write_buf+0xd4/0x2a4
[    0.790900] [] pstore_console_write+0xf0/0x134
[    0.790912] [] console_unlock+0x48c/0x5e8
[    0.790923] [] register_console+0x3b0/0x4d4
[    0.790935] [] pstore_register+0x1a8/0x234
[    0.790947] [] ramoops_probe+0x6b8/0x7d4
[    0.790961] [] platform_drv_probe+0x7c/0xd0
[    0.790972] [] driver_probe_device+0x1b4/0x3bc
[    0.790982] [] __device_attach_driver+0xc8/0xf4
[    0.790996] [] bus_for_each_drv+0xb4/0xe4
[    0.791006] [] __device_attach+0xd0/0x158
[    0.791016] [] device_initial_probe+0x24/0x30
[    0.791026] [] bus_probe_device+0x50/0xe4
[    0.791038] [] device_add+0x3a4/0x76c
[    0.791051] [] of_device_add+0x74/0x84
[    0.791062] [] of_platform_device_create_pdata+0xc0/0x100
[    0.791073] [] of_platform_device_create+0x34/0x40
[    0.791086] [] of_platform_default_populate_init+0x58/0x78
[    0.791097] [] do_one_initcall+0x88/0x160
[    0.791109] [] kernel_init_freeable+0x264/0x31c
[    0.791123] [] kernel_init+0x18/0x11c
[    0.791133] [] ret_from_fork+0x10/0x50
[    0.793717] console [pstore-1] enabled
[    0.797845] pstore: Registered ramoops as persistent store backend
[    0.804647] ramoops: attached 0x100000@0xf7edc000, ecc: 0/0

Fixes: 663deb47880f ("pstore: Allow prz to control need for locking")
Fixes: 109704492ef6 ("pstore: Make spinlock per zone instead of global")
Reported-by: Brian Norris 
Signed-off-by: Kees Cook

pstore: don't OOPS when there are no ftrace zones

2017-02-09T19:49:49+00:00

We'll OOPS in ramoops_get_next_prz() if the platform didn't ask for any
ftrace zones (i.e., cxt->fprzs will be NULL). Let's just skip this
entire FTRACE section if there's no 'fprzs'.

Regression seen on a coreboot/depthcharge-based Chromebook.

Fixes: 2fbea82bbb89 ("pstore: Merge per-CPU ftrace records into one")
Cc: Joel Fernandes 
Cc: Kees Cook 
Signed-off-by: Brian Norris 
Signed-off-by: Kees Cook

Merge tag 'pstore-v4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux

2016-12-13T17:16:11+00:00

Pull pstore updates from Kees Cook:
 "Improvements and fixes to pstore subsystem:

   - add additional checks for bad platform data

   - remove bounce buffer in console writer

   - protect read/unlink race with a mutex

   - correctly give up during dump locking failures

   - increase ftrace bandwidth by splitting ftrace buffers per CPU"

* tag 'pstore-v4.10-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux:
  ramoops: add pdata NULL check to ramoops_probe
  pstore: Convert console write to use ->write_buf
  pstore: Protect unlink with read_mutex
  pstore: Use global ftrace filters for function trace filtering
  ftrace: Provide API to use global filtering for ftrace ops
  pstore: Clarify context field przs as dprzs
  pstore: improve error report for failed setup
  pstore: Merge per-CPU ftrace records into one
  pstore: Add ftrace timestamp counter
  ramoops: Split ftrace buffer space into per-CPU zones
  pstore: Make ramoops_init_przs generic for other prz arrays
  pstore: Allow prz to control need for locking
  pstore: Warn on PSTORE_TYPE_PMSG using deprecated function
  pstore: Make spinlock per zone instead of global
  pstore: Actually give up during locking failure

ramoops: add pdata NULL check to ramoops_probe

2016-11-16T00:34:32+00:00

This adds a check for a NULL platform data, which should only be possible
if a driver incorrectly sets up a probe request without also having defined
the platform_data structure. This is based on a patch from Geliang Tang.

Signed-off-by: Kees Cook

pstore: Convert console write to use ->write_buf

2016-11-16T00:34:32+00:00

Maybe I'm missing something, but I don't know why it needs to copy the
input buffer to psinfo->buf and then write.  Instead we can write the
input buffer directly.  The only implementation that supports console
message (i.e. ramoops) already does it for ftrace messages.

For the upcoming virtio backend driver, it needs to protect psinfo->buf
overwritten from console messages.  If it could use ->write_buf method
instead of ->write, the problem will be solved easily.

Cc: Stefan Hajnoczi 
Signed-off-by: Namhyung Kim 
Signed-off-by: Kees Cook

pstore: Protect unlink with read_mutex

2016-11-16T00:34:31+00:00

When update_ms is set, pstore_get_records() will be called when there's
a new entry.  But unlink can be called at the same time and might
contend with the open-read-close loop.  Depending on the implementation
of platform driver, it may be safe or not.  But I think it'd be better
to protect those race in the first place.

Cc: Stefan Hajnoczi 
Signed-off-by: Namhyung Kim 
Signed-off-by: Kees Cook

pstore: Use global ftrace filters for function trace filtering

2016-11-16T00:34:30+00:00

Currently, pstore doesn't have any filters setup for function tracing.
This has the associated overhead and may not be useful for users looking
for tracing specific set of functions.

ftrace's regular function trace filtering is done writing to
tracing/set_ftrace_filter however this is not available if not requested.
In order to be able to use this feature, the support to request global
filtering introduced earlier in the series should be requested before
registering the ftrace ops. Here we do the same.

Signed-off-by: Joel Fernandes 
Signed-off-by: Kees Cook

pstore: Clarify context field przs as dprzs

2016-11-16T00:34:29+00:00

Since "przs" (persistent ram zones) is a general name in the code now, so
rename the Oops-dump zones to dprzs from przs.

Based on a patch from Nobuhiro Iwamatsu.

Signed-off-by: Kees Cook