linux.git/fs/proc/proc_tty.c, branch v2.6.30

proc tty: remove struct tty_operations::read_proc

2009-04-01T15:59:10+00:00

struct tty_operations::proc_fops took it's place and there is one less
create_proc_read_entry() user now!

Signed-off-by: Alexey Dobriyan 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc tty: add struct tty_operations::proc_fops

2009-04-01T15:59:08+00:00

Used for gradual switch of TTY drivers from using ->read_proc which helps
with gradual switch from ->read_proc for the whole tree.

As side effect, fix possible race condition when ->data initialized after
PDE is hooked into proc tree.

->proc_fops takes precedence over ->read_proc.

Signed-off-by: Alexey Dobriyan 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc 2/2: remove struct proc_dir_entry::owner

2009-03-30T21:14:44+00:00

Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
as correctly noted at bug #12454. Someone can lookup entry with NULL
->owner, thus not pinning enything, and release it later resulting
in module refcount underflow.

We can keep ->owner and supply it at registration time like ->proc_fops
and ->data.

But this leaves ->owner as easy-manipulative field (just one C assignment)
and somebody will forget to unpin previous/pin current module when
switching ->owner. ->proc_fops is declared as "const" which should give
some thoughts.

->read_proc/->write_proc were just fixed to not require ->owner for
protection.

rmmod'ed directories will be empty and return "." and ".." -- no harm.
And directories with tricky enough readdir and lookup shouldn't be modular.
We definitely don't want such modular code.

Removing ->owner will also make PDE smaller.

So, let's nuke it.

Kudos to Jeff Layton for reminding about this, let's say, oversight.

http://bugzilla.kernel.org/show_bug.cgi?id=12454

Signed-off-by: Alexey Dobriyan

tty: Ldisc revamp

2008-07-21T00:12:34+00:00

Move the line disciplines towards a conventional ->ops arrangement.  For
the moment the actual 'tty_ldisc' struct in the tty is kept as part of
the tty struct but this can then be changed if it turns out that when it
all settles down we want to refcount ldiscs separately to the tty.

Pull the ldisc code out of /proc and put it with our ldisc code.

Signed-off-by: Alan Cox 
Signed-off-by: Linus Torvalds

tty: The big operations rework

2008-04-30T15:29:47+00:00

- Operations are now a shared const function block as with most other Linux
  objects

- Introduce wrappers for some optional functions to get consistent behaviour

- Wrap put_char which used to be patched by the tty layer

- Document which functions are needed/optional

- Make put_char report success/fail

- Cache the driver->ops pointer in the tty as tty->ops

- Remove various surplus lock calls we no longer need

- Remove proc_write method as noted by Alexey Dobriyan

- Introduce some missing sanity checks where certain driver/ldisc
  combinations would oops as they didn't check needed methods were present

[akpm@linux-foundation.org: fix fs/compat_ioctl.c build]
[akpm@linux-foundation.org: fix isicom]
[akpm@linux-foundation.org: fix arch/ia64/hp/sim/simserial.c build]
[akpm@linux-foundation.org: fix kgdb]
Signed-off-by: Alan Cox 
Acked-by: Greg Kroah-Hartman 
Cc: Jason Wessel 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: convert /proc/tty/ldiscs to seq_file interface

2008-04-29T15:06:20+00:00

Note: THIS_MODULE and header addition aren't technically needed because
      this code is not modular, but let's keep it anyway because people
      can copy this code into modular code.

Signed-off-by: Alexey Dobriyan 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: switch to proc_create()

2008-04-29T15:06:17+00:00

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

procfs: constify function pointer tables

2008-02-08T17:22:38+00:00

Signed-off-by: Jan Engelhardt 
Acked-by: Geert Uytterhoeven 
Acked-by: Mike Frysinger 
Acked-By: David Howells 
Acked-by: Bryan Wu 
Acked-by: Jesper Nilsson 
Cc: 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

proc: simplify function prototypes

2008-02-08T17:22:23+00:00

Move code around so as to reduce the number of forward-declarations.

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

Make /proc/tty/drivers use seq_list_xxx helpers

2007-07-16T16:05:42+00:00

Simple and stupid like some previous ones.  Just use new API.

Signed-off-by: Pavel Emelianov 
Cc: Alan Cox 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds