linux.git/fs/pipe.c, branch v2.6.30

splice: add helpers for locking pipe inode

2009-04-15T10:10:12+00:00

There are lots of sequences like this, especially in splice code:

	if (pipe->inode)
		mutex_lock(&pipe->inode->i_mutex);
	/* do something */
	if (pipe->inode)
		mutex_unlock(&pipe->inode->i_mutex);

so introduce helpers which do the conditional locking and unlocking.
Also replace the inode_double_lock() call with a pipe_double_lock()
helper to avoid spreading the use of this functionality beyond the
pipe code.

This patch is just a cleanup, and should cause no behavioral changes.

Signed-off-by: Miklos Szeredi 
Signed-off-by: Jens Axboe

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6

2009-03-27T23:23:12+00:00

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6: (37 commits)
  fs: avoid I_NEW inodes
  Merge code for single and multiple-instance mounts
  Remove get_init_pts_sb()
  Move common mknod_ptmx() calls into caller
  Parse mount options just once and copy them to super block
  Unroll essentials of do_remount_sb() into devpts
  vfs: simple_set_mnt() should return void
  fs: move bdev code out of buffer.c
  constify dentry_operations: rest
  constify dentry_operations: configfs
  constify dentry_operations: sysfs
  constify dentry_operations: JFS
  constify dentry_operations: OCFS2
  constify dentry_operations: GFS2
  constify dentry_operations: FAT
  constify dentry_operations: FUSE
  constify dentry_operations: procfs
  constify dentry_operations: ecryptfs
  constify dentry_operations: CIFS
  constify dentry_operations: AFS
  ...

constify dentry_operations: rest

2009-03-27T18:44:03+00:00

Signed-off-by: Al Viro

do_pipe cleanup: drop its last user in arch/alpha/

2009-03-27T18:43:58+00:00

The last user of do_pipe is in arch/alpha/, after replacing it with
do_pipe_flags, the do_pipe can be totally dropped.

Signed-off-by: Cheng Renquan 
Acked-by: Richard Henderson 
Signed-off-by: Al Viro

Rationalize fasync return values

2009-03-16T14:34:35+00:00

Most fasync implementations do something like:

     return fasync_helper(...);

But fasync_helper() will return a positive value at times - a feature used
in at least one place.  Thus, a number of other drivers do:

     err = fasync_helper(...);
     if (err < 0)
             return err;
     return 0;

In the interests of consistency and more concise code, it makes sense to
map positive return values onto zero where ->fasync() is called.

Cc: Al Viro 
Signed-off-by: Jonathan Corbet

pipe_rdwr_fasync: fix the error handling to prevent the leak/crash

2009-03-12T23:20:23+00:00

If the second fasync_helper() fails, pipe_rdwr_fasync() returns the error
but leaves the file on ->fasync_readers.

This was always wrong, but since 233e70f4228e78eb2f80dc6650f65d3ae3dbf17c
"saner FASYNC handling on file close" we have the new problem.  Because in
this case setfl() doesn't set FASYNC bit, __fput() will not do
->fasync(0), and we leak fasync_struct with ->fa_file pointing to the
freed file.

Signed-off-by: Oleg Nesterov 
Cc: Al Viro 
Cc: Andi Kleen 
Cc: Jonathan Corbet 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

[CVE-2009-0029] System call wrappers part 33

2009-01-14T13:15:32+00:00

Signed-off-by: Heiko Carstens

[CVE-2009-0029] System call wrappers part 32

2009-01-14T13:15:31+00:00

Signed-off-by: Heiko Carstens

[CVE-2009-0029] Remove attribute((weak)) from sys_pipe/sys_pipe2

2009-01-14T13:15:15+00:00

Remove __attribute__((weak)) from common code sys_pipe implemantation.
IA64, ALPHA, SUPERH (32bit) and SPARC (32bit) have own implemantations
with the same name. Just rename them.
For sys_pipe2 there is no architecture specific implementation.

Cc: Richard Henderson 
Cc: David S. Miller 
Cc: Paul Mundt 
Cc: Tony Luck 
Signed-off-by: Heiko Carstens

sanitize audit_fd_pair()

2009-01-04T20:14:41+00:00

* no allocations
* return void

Signed-off-by: Al Viro