linux.git/fs/ntfs3, branch v6.8 Linux kernel source tree fs/ntfs3: fix build without CONFIG_NTFS3_LZX_XPRESS 2024-02-26T17:32:23+00:00 Mark O'Donovan shiftee@posteo.net 2024-02-21T10:43:58+00:00 c8e314624a1666ed2eec28549713021a8ec801e9 When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following build error: fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’ Signed-off-by: Mark O'Donovan <shiftee@posteo.net> Fixes: 4fd6c08a16d7 ("fs/ntfs3: Use i_size_read and i_size_write") Tested-by: Chris Clayton <chris2553@googlemail.com> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> 
When CONFIG_NTFS3_LZX_XPRESS is not set then we get the following build
error:

  fs/ntfs3/frecord.c:2460:16: error: unused variable ‘i_size’

Signed-off-by: Mark O'Donovan <shiftee@posteo.net>
Fixes: 4fd6c08a16d7 ("fs/ntfs3: Use i_size_read and i_size_write")
Tested-by: Chris Clayton <chris2553@googlemail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/ntfs3: Slightly simplify ntfs_inode_printk() 2024-01-29T09:05:09+00:00 Christophe JAILLET christophe.jaillet@wanadoo.fr 2023-11-10T19:59:22+00:00 622cd3daa8eae37359a6fd3c07c36d19f66606b5 The size passed to snprintf() includes the space for the trailing space. So there is no reason here not to use all the available space. So remove the -1 when computing 'name_len'. While at it, use the size of the array directly instead of the intermediate 'name_len' variable. snprintf() also guaranties that the buffer if NULL terminated, so there is no need to write an additional trailing NULL "To be sure". Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
The size passed to snprintf() includes the space for the trailing space.
So there is no reason here not to use all the available space.

So remove the -1 when computing 'name_len'.
While at it, use the size of the array directly instead of the intermediate
'name_len' variable.

snprintf() also guaranties that the buffer if NULL terminated, so there is
no need to write an additional trailing NULL "To be sure".

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Add ioctl operation for directories (FITRIM) 2024-01-29T09:05:09+00:00 Nekun nekokun@firemail.cc 2023-10-30T08:33:54+00:00 1f5fa4b3b85ceb43f1053290f0ade037b50e6297 While ntfs3 supports discards, FITRIM ioctl() command has defined only for regular files. This may confuse users trying to invoke `fstrim` utility with the directory argument (for example, call `fstrim <mountpoint>` which is the common practice). In this case, ioctl() returns -ENOTTY without any error messages in kernel ring buffer, this may be easily interpreted as no support for discards in ntfs3 driver. Currently only FITRIM command implemented in ntfs_ioctl() and passed inode used only for dereferencing NTFS superblock, so no need for separate ioctl() handler for directories, just add existing ntfs_ioctl() handler to ntfs_dir_operations. Signed-off-by: Nekun <nekokun@firemail.cc> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
While ntfs3 supports discards, FITRIM ioctl() command has defined
only for regular files. This may confuse users trying to invoke
`fstrim` utility with the directory argument (for example, call
`fstrim <mountpoint>` which is the common practice). In this case,
ioctl() returns -ENOTTY without any error messages in kernel ring
buffer, this may be easily interpreted as no support for discards
in ntfs3 driver.

Currently only FITRIM command implemented in ntfs_ioctl() and
passed inode used only for dereferencing NTFS superblock, so
no need for separate ioctl() handler for directories, just add
existing ntfs_ioctl() handler to ntfs_dir_operations.

Signed-off-by: Nekun <nekokun@firemail.cc>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Fix oob in ntfs_listxattr 2024-01-29T09:05:08+00:00 Edward Adam Davis eadavis@qq.com 2023-12-30T09:00:03+00:00 731ab1f9828800df871c5a7ab9ffe965317d3f15 The length of name cannot exceed the space occupied by ea. Reported-and-tested-by: syzbot+65e940cfb8f99a97aca7@syzkaller.appspotmail.com Signed-off-by: Edward Adam Davis <eadavis@qq.com> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
The length of name cannot exceed the space occupied by ea.

Reported-and-tested-by: syzbot+65e940cfb8f99a97aca7@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis@qq.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Fix an NULL dereference bug 2024-01-29T09:05:08+00:00 Dan Carpenter dan.carpenter@linaro.org 2023-10-17T14:04:39+00:00 b2dd7b953c25ffd5912dda17e980e7168bebcf6c The issue here is when this is called from ntfs_load_attr_list(). The "size" comes from le32_to_cpu(attr->res.data_size) so it can't overflow on a 64bit systems but on 32bit systems the "+ 1023" can overflow and the result is zero. This means that the kmalloc will succeed by returning the ZERO_SIZE_PTR and then the memcpy() will crash with an Oops on the next line. Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
The issue here is when this is called from ntfs_load_attr_list().  The
"size" comes from le32_to_cpu(attr->res.data_size) so it can't overflow
on a 64bit systems but on 32bit systems the "+ 1023" can overflow and
the result is zero.  This means that the kmalloc will succeed by
returning the ZERO_SIZE_PTR and then the memcpy() will crash with an
Oops on the next line.

Fixes: be71b5cba2e6 ("fs/ntfs3: Add attrib operations")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Update inode->i_size after success write into compressed file 2024-01-29T07:48:35+00:00 Konstantin Komarov almaz.alexandrovich@paragon-software.com 2024-01-29T07:30:09+00:00 d68968440b1a75dee05cfac7f368f1aa139e1911 Reported-by: Giovanni Santini <giovannisantini93@yahoo.it> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
Reported-by: Giovanni Santini <giovannisantini93@yahoo.it>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Fixed overflow check in mi_enum_attr() 2024-01-29T07:48:34+00:00 Konstantin Komarov almaz.alexandrovich@paragon-software.com 2024-01-26T08:14:31+00:00 652cfeb43d6b9aba5c7c4902bed7a7340df131fb Reported-by: Robert Morris <rtm@csail.mit.edu> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
Reported-by: Robert Morris <rtm@csail.mit.edu>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Correct function is_rst_area_valid 2024-01-29T07:48:34+00:00 Konstantin Komarov almaz.alexandrovich@paragon-software.com 2024-01-26T08:13:59+00:00 1b7dd28e14c4728ae1a815605ca33ffb4ce1b309 Reported-by: Robert Morris <rtm@csail.mit.edu> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
Reported-by: Robert Morris <rtm@csail.mit.edu>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Use i_size_read and i_size_write 2024-01-29T07:48:33+00:00 Konstantin Komarov almaz.alexandrovich@paragon-software.com 2024-01-26T08:12:38+00:00 4fd6c08a16d7f1ba10212c9ef7bc73218144b463 Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3: Prevent generic message "attempt to access beyond end of device" 2024-01-29T07:48:33+00:00 Konstantin Komarov almaz.alexandrovich@paragon-software.com 2024-01-26T08:03:21+00:00 5ca87d01eba7bdfe9536a157ca33c1455bb8d16c It used in test environment. Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com> 
It used in test environment.

Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>