linux.git/fs/notify/dnotify, branch v4.13

fsnotify: Move ->free_mark callback to fsnotify_ops

2017-04-10T15:37:36+00:00

Pointer to ->free_mark callback unnecessarily occupies one long in each
fsnotify_mark although they are the same for all marks from one
notification group. Move the callback pointer to fsnotify_ops.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Add group pointer in fsnotify_init_mark()

2017-04-10T15:37:36+00:00

Currently we initialize mark->group only in fsnotify_add_mark_lock().
However we will need to access fsnotify_ops of corresponding group from
fsnotify_put_mark() so we need mark->group initialized earlier. Do that
in fsnotify_init_mark() which has a consequence that once
fsnotify_init_mark() is called on a mark, the mark has to be destroyed
by fsnotify_put_mark().

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_find_{inode|vfsmount}_mark()

2017-04-10T15:37:36+00:00

These are very thin wrappers, just remove them. Drop
fs/notify/vfsmount_mark.c as it is empty now.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Remove fsnotify_set_mark_{,ignored_}mask_locked()

2017-04-10T15:37:36+00:00

These helpers are now only a simple assignment and just obfuscate
what is going on. Remove them.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Pass fsnotify_iter_info into handle_event handler

2017-04-10T15:37:36+00:00

Pass fsnotify_iter_info into ->handle_event() handler so that it can
release and reacquire SRCU lock via fsnotify_prepare_user_wait() and
fsnotify_finish_user_wait() functions.  These functions also make sure
current marks are appropriately pinned so that iteration protected by
srcu in fsnotify() stays safe.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Move locking into fsnotify_recalc_mask()

2017-04-10T15:37:35+00:00

Move locking of locks protecting a list of marks into
fsnotify_recalc_mask(). This reduces code churn in the following patch
which changes the lock protecting the list of marks.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: Move object pointer to fsnotify_mark_connector

2017-04-10T15:37:35+00:00

Move pointer to inode / vfsmount from mark itself to the
fsnotify_mark_connector structure. This is another step on the path
towards decoupling inode / vfsmount lifetime from notification mark
lifetime.

Reviewed-by: Miklos Szeredi 
Reviewed-by: Amir Goldstein 
Signed-off-by: Jan Kara

fsnotify: constify 'data' passed to ->handle_event()

2016-12-05T23:58:31+00:00

Signed-off-by: Al Viro

fsnotify: get rid of fsnotify_destroy_mark_locked()

2015-09-04T23:54:41+00:00

fsnotify_destroy_mark_locked() is subtle to use because it temporarily
releases group->mark_mutex.  To avoid future problems with this
function, split it into two.

fsnotify_detach_mark() is the part that needs group->mark_mutex and
fsnotify_free_mark() is the part that must be called outside of
group->mark_mutex.  This way it's much clearer what's going on and we
also avoid some pointless acquisitions of group->mark_mutex.

Signed-off-by: Jan Kara 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fsnotify: unify inode and mount marks handling

2014-12-13T20:42:53+00:00

There's a lot of common code in inode and mount marks handling.  Factor it
out to a common helper function.

Signed-off-by: Jan Kara 
Cc: Eric Paris 
Cc: Heinrich Schuchardt 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds