linux.git/fs/nilfs2/btnode.c, branch v6.11

nilfs2: handle inconsistent state in nilfs_btnode_create_block()

2024-07-26T21:33:10+00:00

Syzbot reported that a buffer state inconsistency was detected in
nilfs_btnode_create_block(), triggering a kernel bug.

It is not appropriate to treat this inconsistency as a bug; it can occur
if the argument block address (the buffer index of the newly created
block) is a virtual block number and has been reallocated due to
corruption of the bitmap used to manage its allocation state.

So, modify nilfs_btnode_create_block() and its callers to treat it as a
possible filesystem error, rather than triggering a kernel bug.

Link: https://lkml.kernel.org/r/20240725052007.4562-1-konishi.ryusuke@gmail.com
Fixes: a60be987d45d ("nilfs2: B-tree node cache")
Signed-off-by: Ryusuke Konishi 
Reported-by: syzbot+89cc4f2324ed37988b60@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=89cc4f2324ed37988b60
Cc: 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_page_bug() to nilfs_folio_bug()

2023-12-11T01:21:48+00:00

All callers have a folio now, so convert it.

Link: https://lkml.kernel.org/r/20231127143036.2425-18-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_btnode_abort_change_key to use a folio

2023-12-11T01:21:30+00:00

Saves one call to compound_head().

Link: https://lkml.kernel.org/r/20231114084436.2755-21-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_btnode_commit_change_key to use a folio

2023-12-11T01:21:30+00:00

Saves one call to compound_head().

Link: https://lkml.kernel.org/r/20231114084436.2755-20-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_btnode_prepare_change_key to use a folio

2023-12-11T01:21:30+00:00

Saves three calls to compound_head().

Link: https://lkml.kernel.org/r/20231114084436.2755-19-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_btnode_delete to use a folio

2023-12-11T01:21:30+00:00

Saves six calls to compound_head().

Link: https://lkml.kernel.org/r/20231114084436.2755-18-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_btnode_submit_block to use a folio

2023-12-11T01:21:29+00:00

Saves two calls to compound_head().

Link: https://lkml.kernel.org/r/20231114084436.2755-17-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: convert nilfs_btnode_create_block to use a folio

2023-12-11T01:21:29+00:00

Saves two calls to compound_head().

Link: https://lkml.kernel.org/r/20231114084436.2755-16-konishi.ryusuke@gmail.com
Signed-off-by: Matthew Wilcox (Oracle) 
Signed-off-by: Ryusuke Konishi 
Signed-off-by: Andrew Morton

nilfs2: fix incomplete buffer cleanup in nilfs_btnode_abort_change_key()

2023-06-12T18:31:49+00:00

A syzbot fault injection test reported that nilfs_btnode_create_block, a
helper function that allocates a new node block for b-trees, causes a
kernel BUG for disk images where the file system block size is smaller
than the page size.

This was due to unexpected flags on the newly allocated buffer head, and
it turned out to be because the buffer flags were not cleared by
nilfs_btnode_abort_change_key() after an error occurred during a b-tree
update operation and the buffer was later reused in that state.

Fix this issue by using nilfs_btnode_delete() to abandon the unused
preallocated buffer in nilfs_btnode_abort_change_key().

Link: https://lkml.kernel.org/r/20230513102428.10223-1-konishi.ryusuke@gmail.com
Signed-off-by: Ryusuke Konishi 
Reported-by: syzbot+b0a35a5c1f7e846d3b09@syzkaller.appspotmail.com
Closes: https://lkml.kernel.org/r/000000000000d1d6c205ebc4d512@google.com
Tested-by: Ryusuke Konishi 
Cc: 
Signed-off-by: Andrew Morton

nilfs2: replace obvious uses of b_page with b_folio

2023-01-19T01:12:41+00:00

These places just use b_page to get to the buffer's address_space or the
index of the page the buffer is in.

Link: https://lkml.kernel.org/r/20221215214402.3522366-11-willy@infradead.org
Signed-off-by: Matthew Wilcox (Oracle) 
Reviewed-by: Jan Kara 
Signed-off-by: Andrew Morton