linux.git/fs/nfsd, branch v3.17

nfsd4: fix corruption of NFSv4 read data

2014-09-30T19:57:04+00:00

The calculation of page_ptr here is wrong in the case the read doesn't
start at an offset that is a multiple of a page.

The result is that nfs4svc_encode_compoundres sets rq_next_page to a
value one too small, and then the loop in svc_free_res_pages may
incorrectly fail to clear a page pointer in rq_respages[].

Pages left in rq_respages[] are available for the next rpc request to
use, so xdr data may be written to that page, which may hold data still
waiting to be transmitted to the client or data in the page cache.

The observed result was silent data corruption seen on an NFSv4 client.

We tag this as "fixing" 05638dc73af2 because that commit exposed this
bug, though the incorrect calculation predates it.

Particular thanks to Andrea Arcangeli and David Gilbert for analysis and
testing.

Fixes: 05638dc73af2 "nfsd4: simplify server xdr->next_page use"
Cc: stable@vger.kernel.org
Reported-by: Andrea Arcangeli 
Tested-by: "Dr. David Alan Gilbert" 
Signed-off-by: J. Bruce Fields

nfsd4: fix rd_dircount enforcement

2014-09-08T16:02:03+00:00

Commit 3b299709091b "nfsd4: enforce rd_dircount" totally misunderstood
rd_dircount; it refers to total non-attribute bytes returned, not number
of directory entries returned.

Bring the code into agreement with RFC 3530 section 14.2.24.

Cc: stable@vger.kernel.org
Fixes: 3b299709091b "nfsd4: enforce rd_dircount"
Signed-off-by: J. Bruce Fields

Merge branch 'for-3.17' of git://linux-nfs.org/~bfields/linux

2014-08-09T21:31:18+00:00

Pull nfsd updates from Bruce Fields:
 "This includes a major rewrite of the NFSv4 state code, which has
  always depended on a single mutex.  As an example, open creates are no
  longer serialized, fixing a performance regression on NFSv3->NFSv4
  upgrades.  Thanks to Jeff, Trond, and Benny, and to Christoph for
  review.

  Also some RDMA fixes from Chuck Lever and Steve Wise, and
  miscellaneous fixes from Kinglong Mee and others"

* 'for-3.17' of git://linux-nfs.org/~bfields/linux: (167 commits)
  svcrdma: remove rdma_create_qp() failure recovery logic
  nfsd: add some comments to the nfsd4 object definitions
  nfsd: remove the client_mutex and the nfs4_lock/unlock_state wrappers
  nfsd: remove nfs4_lock_state: nfs4_state_shutdown_net
  nfsd: remove nfs4_lock_state: nfs4_laundromat
  nfsd: Remove nfs4_lock_state(): reclaim_complete()
  nfsd: Remove nfs4_lock_state(): setclientid, setclientid_confirm, renew
  nfsd: Remove nfs4_lock_state(): exchange_id, create/destroy_session()
  nfsd: Remove nfs4_lock_state(): nfsd4_open and nfsd4_open_confirm
  nfsd: Remove nfs4_lock_state(): nfsd4_delegreturn()
  nfsd: Remove nfs4_lock_state(): nfsd4_open_downgrade + nfsd4_close
  nfsd: Remove nfs4_lock_state(): nfsd4_lock/locku/lockt()
  nfsd: Remove nfs4_lock_state(): nfsd4_release_lockowner
  nfsd: Remove nfs4_lock_state(): nfsd4_test_stateid/nfsd4_free_stateid
  nfsd: Remove nfs4_lock_state(): nfs4_preprocess_stateid_op()
  nfsd: remove old fault injection infrastructure
  nfsd: add more granular locking to *_delegations fault injectors
  nfsd: add more granular locking to forget_openowners fault injector
  nfsd: add more granular locking to forget_locks fault injector
  nfsd: add a list_head arg to nfsd_foreach_client_lock
  ...

nfsd: add some comments to the nfsd4 object definitions

2014-08-05T20:09:20+00:00

Add some comments that describe what each of these objects is, and how
they related to one another.

Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

nfsd: remove the client_mutex and the nfs4_lock/unlock_state wrappers

2014-08-05T19:00:54+00:00

Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

nfsd: remove nfs4_lock_state: nfs4_state_shutdown_net

2014-08-05T14:55:20+00:00

Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

nfsd: remove nfs4_lock_state: nfs4_laundromat

2014-08-05T14:55:20+00:00

Signed-off-by: Jeff Layton 
Signed-off-by: J. Bruce Fields

nfsd: Remove nfs4_lock_state(): reclaim_complete()

2014-08-05T14:55:19+00:00

Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

nfsd: Remove nfs4_lock_state(): setclientid, setclientid_confirm, renew

2014-08-05T14:55:18+00:00

Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

nfsd: Remove nfs4_lock_state(): exchange_id, create/destroy_session()

2014-08-05T14:55:17+00:00

Also destroy_clientid and bind_conn_to_session.

Signed-off-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields