linux.git/fs/nfs, branch v5.3

NFS: Fix inode fileid checks in attribute revalidation code

2019-09-02T17:10:19+00:00

We want to throw out the attrbute if it refers to the mounted on fileid,
and not the real fileid. However we do not want to block cache consistency
updates from NFSv4 writes.

Reported-by: Murphy Zhou 
Fixes: 7e10cc25bfa0 ("NFS: Don't refresh attributes with mounted-on-file...")
Signed-off-by: Trond Myklebust

NFS: remove set but not used variable 'mapping'

2019-08-27T14:24:56+00:00

Fixes gcc '-Wunused-but-set-variable' warning:

fs/nfs/write.c: In function nfs_page_async_flush:
fs/nfs/write.c:609:24: warning: variable mapping set but not used [-Wunused-but-set-variable]

It is not use since commit aefb623c422e ("NFS: Fix
writepage(s) error handling to not report errors twice")

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
Signed-off-by: Trond Myklebust

NFSv2: Fix write regression

2019-08-27T14:24:56+00:00

Ensure we update the write result count on success, since the
RPC call itself does not do so.

Reported-by: Jan Stancek 
Reported-by: Naresh Kamboju 
Signed-off-by: Trond Myklebust 
Tested-by: Jan Stancek

NFSv2: Fix eof handling

2019-08-27T14:24:56+00:00

If we received a reply from the server with a zero length read and
no error, then that implies we are at eof.

Signed-off-by: Trond Myklebust

NFS: Fix writepage(s) error handling to not report errors twice

2019-08-26T19:31:29+00:00

If writepage()/writepages() saw an error, but handled it without
reporting it, we should not be re-reporting that error on exit.

Signed-off-by: Trond Myklebust

NFS: Fix spurious EIO read errors

2019-08-26T19:31:29+00:00

If the client attempts to read a page, but the read fails due to some
spurious error (e.g. an ACCESS error or a timeout, ...) then we need
to allow other processes to retry.
Also try to report errors correctly when doing a synchronous readpage.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Don't time out requests on hard mounts

2019-08-26T19:31:29+00:00

If the mount is hard, we should ignore the 'io_maxretrans' module
parameter so that we always keep retrying.

Signed-off-by: Trond Myklebust

Revert "NFSv4/flexfiles: Abort I/O early if the layout segment was invalidated"

2019-08-26T19:31:29+00:00

This reverts commit a79f194aa4879e9baad118c3f8bb2ca24dbef765.
The mechanism for aborting I/O is racy, since we are not guaranteed that
the request is asleep while we're changing both task->tk_status and
task->tk_action.

Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org # v5.1

pNFS/flexfiles: Turn off soft RPC calls

2019-08-26T19:31:29+00:00

The pNFS/flexfiles I/O requests are sent with the SOFTCONN flag set, so
they automatically time out if the connection breaks. It should
therefore not be necessary to have the soft flag set in addition.

Fixes: 5f01d9539496 ("nfs41: create NFSv3 DS connection if specified")
Signed-off-by: Trond Myklebust

NFS: On fatal writeback errors, we need to call nfs_inode_remove_request()

2019-08-19T12:56:04+00:00

If the writeback error is fatal, we need to remove the tracking structures
(i.e. the nfs_page) from the inode.

Fixes: 6fbda89b257f ("NFS: Replace custom error reporting mechanism...")
Signed-off-by: Trond Myklebust