linux.git/fs/nfs, branch v4.5

NFSv4.x/pnfs: Fix a race between layoutget and bulk recalls

2016-02-22T22:46:34+00:00

Replace another case where the layout 'plh_block_lgets' can trigger
infinite loops in send_layoutget().

Signed-off-by: Trond Myklebust

NFSv4.x/pnfs: Fix a race between layoutget and pnfs_destroy_layout

2016-02-22T22:34:59+00:00

If the server reboots while there is a layoutget outstanding, then
the call to pnfs_choose_layoutget_stateid() will fail with an EAGAIN
error, which causes an infinite loop in send_layoutget(). The reason
why we never break out of the loop is that the layout 'plh_block_lgets'
field is never cleared.

Fix is to replace plh_block_lgets with NFS_LAYOUT_INVALID_STID, which
can be reset after a new layoutget.

Fixes: ab7d763e477c5 ("pNFS: Ensure nfs4_layoutget_prepare returns...")
Signed-off-by: Trond Myklebust

pnfs/blocklayout: fix a memeory leak when using,vmalloc_to_page

2016-02-17T16:44:45+00:00

unreferenced object 0xffffc90000abf000 (size 16900):
  comm "fsync02", pid 15765, jiffies 4297431627 (age 423.772s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 a0 c2 19 00 88 ff ff  ................
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [] kmemleak_alloc+0x4e/0xb0
    [] __vmalloc_node_range+0x231/0x280
    [] __vmalloc+0x4a/0x50
    [] ext_tree_prepare_commit+0x231/0x2e0 [blocklayoutdriver]
    [] bl_prepare_layoutcommit+0xe/0x10 [blocklayoutdriver]
    [] pnfs_layoutcommit_inode+0x29c/0x330 [nfsv4]
    [] pnfs_generic_sync+0x13/0x20 [nfsv4]
    [] nfs4_file_fsync+0x58/0x150 [nfsv4]
    [] vfs_fsync_range+0x4b/0xb0
    [] do_fsync+0x3d/0x70
    [] SyS_fsync+0x10/0x20
    [] entry_SYSCALL_64_fastpath+0x12/0x76
    [] 0xffffffffffffffff

v2, add missing include header

Signed-off-by: Kinglong Mee 
Signed-off-by: Trond Myklebust

nfs4: fix stateid handling for the NFS v4.2 operations

2016-02-17T16:38:07+00:00

The newly added NFS v4.2 operations (ALLOCATE, DEALLOCATE, SEEK and CLONE)
use a helper called nfs42_set_rw_stateid to select a stateid that is sent
to the server.  But they don't set the inode and state fields in the
nfs4_exception structure, and this don't partake in the stateid recovery
protocol.  Because of this they will simply return errors insted of trying
to recover a stateid when the server return a BAD_STATEID error.

Additionally CLONE has the problem that it operates on two files and thus
two stateids, and thus needs to call the exception handler twice to
recover stateids.

While we're at it stop grabbing an addititional reference to the open
context in all these operations - having the file open guarantees that
the open context won't go away.

All this can be produces with the generic/168 and generic/170 tests in
xfstests which stress the CLONE stateid handling.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

NFSv4: Fix a dentry leak on alias use

2016-02-17T16:35:25+00:00

In the case where d_add_unique() finds an appropriate alias to use it will
have already incremented the reference count.  An additional dget() to swap
the open context's dentry is unnecessary and will leak a reference.

Signed-off-by: Benjamin Coddington 
Fixes: 275bb307865a3 ("NFSv4: Move dentry instantiation into the NFSv4-...")
Cc: stable@vger.kernel.org # 3.10+
Signed-off-by: Trond Myklebust

pNFS: Always set NFS_LAYOUT_RETURN_REQUESTED with lo->plh_return_iomode

2016-02-15T18:03:30+00:00

When setting the layout return mode, we must always also set the
NFS_LAYOUT_RETURN_REQUESTED flag to ensure that we send a layoutreturn.
Otherwise pnfs_error_mark_layout_for_return() could set the mode, but
fail to send the layoutreturn because another is already in flight.

Signed-off-by: Trond Myklebust

pNFS: Fix pnfs_mark_matching_lsegs_return()

2016-02-15T17:56:01+00:00

We don't need to schedule a layoutreturn if the layout segment can
be freed immediately.

Signed-off-by: Trond Myklebust

NFS: Cleanup - rename NFS_LAYOUT_RETURN_BEFORE_CLOSE

2016-01-28T01:40:05+00:00

NFS_LAYOUT_RETURN_BEFORE_CLOSE is being used to signal that a
layoutreturn is needed, either due to a layout recall or to a
layout error. Rename it to NFS_LAYOUT_RETURN_REQUESTED in order
to clarify its purpose.

Signed-off-by: Trond Myklebust

pNFS: Fix missing layoutreturn calls

2016-01-27T04:12:11+00:00

The layoutreturn code currently relies on pnfs_put_lseg() to initiate the
RPC call when conditions are right. A problem arises when we want to
free the layout segment from inside an inode->i_lock section (e.g. in
pnfs_clear_request_commit()), since we cannot sleep.

The workaround is to move the actual call to pnfs_send_layoutreturn()
to pnfs_put_layout_hdr(), which doesn't have this restriction.

Signed-off-by: Trond Myklebust

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2016-01-23T20:24:56+00:00

Pull final vfs updates from Al Viro:

 - The ->i_mutex wrappers (with small prereq in lustre)

 - a fix for too early freeing of symlink bodies on shmem (they need to
   be RCU-delayed) (-stable fodder)

 - followup to dedupe stuff merged this cycle

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs:
  vfs: abort dedupe loop if fatal signals are pending
  make sure that freeing shmem fast symlinks is RCU-delayed
  wrappers for ->i_mutex access
  lustre: remove unused declaration