linux.git/fs/nfs, branch v4.10

pNFS: Fix a reference leak in _pnfs_return_layout

2017-01-26T20:50:41+00:00

IF NFS_LAYOUT_RETURN_REQUESTED is not set, then we currently exit
without freeing the list of invalidated layout segments, leading
to a reference leak.

Reported-by: Olga Kornievskaia 
Fixes: 24408f5282 ("pNFS: Fix bugs in _pnfs_return_layout")
Signed-off-by: Trond Myklebust

nfs: Fix "Don't increment lock sequence ID after NFS4ERR_MOVED"

2017-01-26T20:25:03+00:00

Lock sequence IDs are bumped in decode_lock by calling
nfs_increment_seqid(). nfs_increment_sequid() does not use the
seqid_mutating_err() function fixed in commit 059aa7348241 ("Don't
increment lock sequence ID after NFS4ERR_MOVED").

Fixes: 059aa7348241 ("Don't increment lock sequence ID after ...")
Signed-off-by: Chuck Lever 
Tested-by: Xuan Qi 
Cc: stable@vger.kernel.org # v3.7+
Signed-off-by: Trond Myklebust

NFSv4.0: always send mode in SETATTR after EXCLUSIVE4

2017-01-24T17:52:34+00:00

Some nfsv4.0 servers may return a mode for the verifier following an open
with EXCLUSIVE4 createmode, but this does not mean the client should skip
setting the mode in the following SETATTR.  It should only do that for
EXCLUSIVE4_1 or UNGAURDED createmode.

Fixes: 5334c5bdac92 ("NFS: Send attributes in OPEN request for NFS4_CREATE_EXCLUSIVE4_1")
Signed-off-by: Benjamin Coddington 
Cc: stable@vger.kernel.org # v4.3+
Signed-off-by: Trond Myklebust

NFSv4.1: Fix a deadlock in layoutget

2017-01-24T03:44:12+00:00

We cannot call nfs4_handle_exception() without first ensuring that the
slot has been freed. If not, we end up deadlocking with the process
waiting for recovery to complete, and recovery waiting for the slot
table to drain.

Fixes: 2e80dbe7ac51 ("NFSv4.1: Close callback races for OPEN, LAYOUTGET...")
Cc: stable@vger.kernel.org # v4.8+
Signed-off-by: Trond Myklebust

NFSv4: Fix client recovery when server reboots multiple times

2017-01-13T18:31:32+00:00

If the server reboots multiple times, the client should rely on the
server to tell it that it cannot reclaim state as per section 9.6.3.4
in RFC7530 and section 8.4.2.1 in RFC5661.
Currently, the client is being to conservative, and is assuming that
if the server reboots while state recovery is in progress, then it must
ignore state that was not recovered before the reboot.

Signed-off-by: Trond Myklebust

NFSv4: update_changeattr should update the attribute timestamp

2017-01-12T20:51:19+00:00

Otherwise, the attribute cache remains marked as being expired.

Signed-off-by: Trond Myklebust

NFSv4: Don't call update_changeattr() unless the unlink is successful

2017-01-12T20:51:18+00:00

If the unlink wasn't successful, then the directory has presumably not
changed.

Signed-off-by: Trond Myklebust

NFSv4: Don't apply change_info4 twice on rename within a directory

2017-01-12T20:51:18+00:00

If a file is renamed, but stays in the same directory, we will still receive
2 change_info4 structures describing the change to that directory, but we
only want to apply it once.

Signed-off-by: Trond Myklebust

NFSv4: Call update_changeattr() from _nfs4_proc_open only if a file was created

2017-01-12T20:51:17+00:00

We don't want to invalidate the directory attribute and data cache unless we
know that a file was created, or the change attribute differs from the one
in our cache.

Signed-off-by: Trond Myklebust

nfs: Don't take a reference on fl->fl_file for LOCK operation

2017-01-12T17:51:29+00:00

I have reports of a crash that look like __fput() was called twice for
a NFSv4.0 file.  It seems possible that the state manager could try to
reclaim a lock and take a reference on the fl->fl_file at the same time the
file is being released if, during the close(), a signal interrupts the wait
for outstanding IO while removing locks which then skips the removal
of that lock.

Since 83bfff23e9ed ("nfs4: have do_vfs_lock take an inode pointer") has
removed the need to traverse fl->fl_file->f_inode in nfs4_lock_done(),
taking that reference is no longer necessary.

Signed-off-by: Benjamin Coddington 
Reviewed-by: Jeff Layton 
Signed-off-by: Trond Myklebust