linux.git/fs/nfs, branch v3.11

NFSv4: Fix up nfs4_proc_lookup_mountpoint

2013-08-08T00:47:26+00:00

Currently, we do not check the return value of client = rpc_clone_client(),
nor do we shut down the resulting cloned rpc_clnt in the case where a
NFS4ERR_WRONGSEC has caused nfs4_proc_lookup_common() to replace the
original value of 'client' (causing a memory leak).

Fix both issues and simplify the code by moving the call to
rpc_clone_client() until after nfs4_proc_lookup_common() has
done its business.

Reported-by: Andy Adamson 
Signed-off-by: Trond Myklebust

NFS: Remove unnecessary call to nfs_setsecurity in nfs_fhget()

2013-08-07T21:07:41+00:00

We only need to call it on the creation of the inode.

Reported-by: Julia Lawall 
Cc: Steve Dickson 
Cc: Dave Quigley 
Signed-off-by: Trond Myklebust

NFSv4: Fix the sync mount option for nfs4 mounts

2013-08-07T21:07:41+00:00

The sync mount option stopped working for NFSv4 mounts after commit
c02d7adf8c5429727a98bad1d039bccad4c61c50 (NFSv4: Replace nfs4_path_walk() with
FS path lookup in a private namespace).  If MS_SYNCHRONOUS is set in the
super_block that we're cloning from, then it should be set in the new
super_block as well.

Signed-off-by: Scott Mayhew 
Signed-off-by: Trond Myklebust

NFS: Fix writeback performance issue on cache invalidation

2013-08-07T21:07:40+00:00

If a cache invalidation is triggered, and we happen to have a lot of
writebacks cached at the time, then the call to invalidate_inode_pages2()
will end up calling ->launder_page() on each and every dirty page in order
to sync its contents to disk, thus defeating write coalescing.
The following patch ensures that we try to sync the inode to disk before
calling invalidate_inode_pages2() so that we do the writeback as efficiently
as possible.

Reported-by: William Dauchy 
Reported-by: Pascal Bouchareine 
Signed-off-by: Trond Myklebust 
Tested-by: William Dauchy 
Reviewed-by: Jeff Layton

NFSv4: Fix brainfart in attribute length calculation

2013-07-23T21:24:59+00:00

The calculation of the attribute length was 4 bytes off.

Signed-off-by: Trond Myklebust 
Tested-by: Andre Heider 
Reported-and-tested-by: Henrik Rydberg 
Signed-off-by: Linus Torvalds

NFSv4: Fix a regression against the FreeBSD server

2013-07-17T20:54:46+00:00

Technically, the Linux client is allowed by the NFSv4 spec to send
3 word bitmaps as part of an OPEN request. However, this causes the
current FreeBSD server to return NFS4ERR_ATTRNOTSUPP errors.

Fix the regression by making the Linux client use a 2 word bitmap unless
doing NFSv4.2 with labeled NFS.

Signed-off-by: Trond Myklebust

NFS: Allow nfs_updatepage to extend a write under additional circumstances

2013-07-09T23:32:50+00:00

Currently nfs_updatepage allows a write to be extended to cover a full
page only if we don't have a byte range lock lock on the file... but if
we have a write delegation on the file or if we have the whole file
locked for writing then we should be allowed to extend the write as
well.

Signed-off-by: Scott Mayhew 
[Trond: fix up call to nfs_have_delegation()]
Signed-off-by: Trond Myklebust

NFS: Make nfs_readdir revalidate less often

2013-07-09T21:17:07+00:00

Make nfs_readdir revalidate only when we're at the beginning of the directory or
if the cached attributes have expired.

Signed-off-by: Scott Mayhew 
Signed-off-by: Trond Myklebust

NFS: Make nfs_attribute_cache_expired() non-static

2013-07-09T21:17:07+00:00

NFS: Make nfs_attribute_cache_expired() non-static so we can call it from
nfs_readdir().

Signed-off-by: Scott Mayhew 
Signed-off-by: Trond Myklebust

nfs: set verifier on existing dentries in nfs_prime_dcache

2013-07-09T21:16:39+00:00

nfs_prime_dcache currently only sets the verifier when it doesn't
initially a matching dentry in the dcache. Set the verifier in the case
where we do find a dentry in the dcache. This ensures that we don't
have to look up the dentry again if we want to use it after a readdir.

Cc: Scott Mayhew 
Signed-off-by: Jeff Layton 
Signed-off-by: Trond Myklebust