linux.git/fs/nfs/write.c, branch v6.16

nfs: use writeback_iter directly

2025-05-28T21:17:13+00:00

Stop using write_cache_pages and use writeback_iter directly.  This
removes an indirect call per written folio and makes the code easier
to follow.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Anna Schumaker

nfs: refactor nfs_do_writepage

2025-05-28T21:17:13+00:00

Use early returns wherever possible to simplify the code.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Anna Schumaker

nfs: don't return AOP_WRITEPAGE_ACTIVATE from nfs_do_writepage

2025-05-28T21:17:13+00:00

nfs_do_writepage is a successful return that requires the caller to
unlock the folio.  Using it here requires special casing both in
nfs_do_writepage and nfs_writepages_callback and leaves a land mine in
nfs_wb_folio in case it ever set the flag.  Remove it and just
unconditionally unlock in nfs_writepages_callback.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Anna Schumaker

nfs: fold nfs_page_async_flush into nfs_do_writepage

2025-05-28T21:17:13+00:00

Fold nfs_page_async_flush into its only caller to clean up the code a
bit.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Anna Schumaker

nfs: Add missing release on error in nfs_lock_and_join_requests()

2025-04-02T13:53:16+00:00

Call nfs_release_request() on this error path before returning.

Fixes: c3f2235782c3 ("nfs: fold nfs_folio_find_and_lock_request into nfs_lock_and_join_requests")
Signed-off-by: Dan Carpenter 
Link: https://lore.kernel.org/r/3aaaa3d5-1c8a-41e4-98c7-717801ddd171@stanley.mountain
Signed-off-by: Trond Myklebust

nfs: cache all open LOCALIO nfsd_file(s) in client

2025-01-14T22:04:05+00:00

This commit switches from leaning heavily on NFSD's filecache (in
terms of GC'd nfsd_files) back to caching nfsd_files in the
client. A later commit will add the callback mechanism needed to
allow NFSD to force the NFS client to cleanup all cached nfsd_files.

Add nfs_fh_localio_init() and 'struct nfs_fh_localio' to cache opened
nfsd_file(s) (both a RO and RW nfsd_file is able to be opened and
cached for a given nfs_fh).

Update nfs_local_open_fh() to cache the nfsd_file once it is opened
using __nfs_local_open_fh().

Introduce nfs_close_local_fh() to clear the cached open nfsd_files and
call nfs_to_nfsd_file_put_local().

Refcounting is such that:
- nfs_local_open_fh() is paired with nfs_close_local_fh().
- __nfs_local_open_fh() is paired with nfs_to_nfsd_file_put_local().
- nfs_local_file_get() is paired with nfs_local_file_put().

Signed-off-by: Mike Snitzer 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

Revert "nfs: don't reuse partially completed requests in nfs_lock_and_join_requests"

2024-11-18T14:42:03+00:00

This reverts commit b571cfcb9dcac187c6d967987792d37cb0688610.

This patch appears to assume that if one request is complete, then the
others will complete too before unlocking. That is not a valid
assumption, since other requests could hit a non-fatal error or a short
write that would cause them not to complete.

Reported-by: Igor Raits 
Link: https://bugzilla.kernel.org/show_bug.cgi?id=219508
Fixes: b571cfcb9dca ("nfs: don't reuse partially completed requests in nfs_lock_and_join_requests")
Signed-off-by: Trond Myklebust

Revert "fs: nfs: fix missing refcnt by replacing folio_set_private by folio_attach_private"

2024-11-10T02:38:39+00:00

This reverts commit 03e02b94171b1985dd0aa184296fe94425b855a3.

As was pointed out during code review, there is no need to use
folio_attach_private()/folio_detach_private() when a refcount to the
folio is already carried by the struct nfs_page.

Signed-off-by: Trond Myklebust

nfs: enable localio for non-pNFS IO

2024-09-23T19:03:30+00:00

Try a local open of the file being written to, and if it succeeds,
then use localio to issue IO.

Signed-off-by: Trond Myklebust 
Signed-off-by: Mike Snitzer 
Reviewed-by: NeilBrown 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

nfs: add LOCALIO support

2024-09-23T19:03:30+00:00

Add client support for bypassing NFS for localhost reads, writes, and
commits. This is only useful when the client and the server are
running on the same host.

nfs_local_probe() is stubbed out, later commits will enable client and
server handshake via a Linux-only LOCALIO auxiliary RPC protocol.

This has dynamic binding with the nfsd module (via nfs_localio module
which is part of nfs_common). LOCALIO will only work if nfsd is
already loaded.

The "localio_enabled" nfs kernel module parameter can be used to
disable and enable the ability to use LOCALIO support.

CONFIG_NFS_LOCALIO enables NFS client support for LOCALIO.

Lastly, LOCALIO uses an nfsd_file to initiate all IO. To make proper
use of nfsd_file (and nfsd's filecache) its lifetime (duration before
nfsd_file_put is called) must extend until after commit, read and
write operations. So rather than immediately drop the nfsd_file
reference in nfs_local_open_fh(), that doesn't happen until
nfs_local_pgio_release() for read/write and not until
nfs_local_release_commit_data() for commit. The same applies to the
reference held on nfsd's nn->nfsd_serv. Both objects' lifetimes and
associated references are managed through calls to
nfs_to->nfsd_file_put_local().

Signed-off-by: Weston Andros Adamson 
Signed-off-by: Trond Myklebust 
Co-developed-by: Mike Snitzer 
Signed-off-by: Mike Snitzer 
Signed-off-by: NeilBrown  # nfs_open_local_fh
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker