linux.git/fs/nfs/write.c, branch v2.6.35

NFS: Fix a typo in include/linux/nfs_fs.h

2010-08-01T22:10:01+00:00

nfs_commit_inode() needs to be defined irrespectively of whether or not
we are supporting NFSv3 and NFSv4.

Allow the compiler to optimise away code in the NFSv2-only case by
converting it into an inlined stub function.

Reported-and-tested-by: Ingo Molnar 
Signed-off-by: Trond Myklebust 
Signed-off-by: Linus Torvalds

NFS: Ensure that writepage respects the nonblock flag

2010-07-30T19:38:56+00:00

Signed-off-by: Trond Myklebust

NFS: kswapd must not block in nfs_release_page

2010-07-30T19:38:42+00:00

See https://bugzilla.kernel.org/show_bug.cgi?id=16056

If other processes are blocked waiting for kswapd to free up some memory so
that they can make progress, then we cannot allow kswapd to block on those
processes.

Signed-off-by: Trond Myklebust 
Cc: stable@kernel.org

NFS: Fix another nfs_wb_page() deadlock

2010-05-26T12:43:53+00:00

J.R. Okajima reports that the call to sync_inode() in nfs_wb_page() can
deadlock with other writeback flush calls. It boils down to the fact
that we cannot ever call writeback_single_inode() while holding a page
lock (even if we do set nr_to_write to zero) since another process may
already be waiting in the call to do_writepages(), and so will deny us
the I_SYNC lock.

Signed-off-by: Trond Myklebust

NFS: Ensure that we mark the inode as dirty if we exit early from commit

2010-05-26T12:43:52+00:00

If we exit from nfs_commit_inode() without ensuring that the COMMIT rpc
call has been completed, we must re-mark the inode as dirty. Otherwise,
future calls to sync_inode() with the WB_SYNC_ALL flag set will fail to
ensure that the data is on the disk.

Signed-off-by: Trond Myklebust

NFS: Ensure that nfs_wb_page() waits for Pg_writeback to clear

2010-04-27T22:33:54+00:00

Neil Brown reports that he is seeing the BUG_ON(ret == 0) trigger in
nfs_page_async_flush. According to the trace in
     https://bugzilla.novell.com/show_bug.cgi?id=599628
the problem appears to be due to nfs_wb_page() not waiting for the
PG_writeback flag to clear.

There is a ditto problem in nfs_wb_page_cancel()

Signed-off-by: Trond Myklebust

NFS: Fix an unstable write data integrity race

2010-04-22T19:35:57+00:00

Commit 2c61be0a9478258f77b66208a0c4b1f5f8161c3c (NFS: Ensure that the WRITE
and COMMIT RPC calls are always uninterruptible) exposed a race on file
close. In order to ensure correct close-to-open behaviour, we want to wait
for all outstanding background commit operations to complete.

This patch adds an inode flag that indicates if a commit operation is under
way, and provides a mechanism to allow ->write_inode() to wait for its
completion if this is a data integrity flush.

Signed-off-by: Trond Myklebust

NFS: Ensure that the WRITE and COMMIT RPC calls are always uninterruptible

2010-04-09T23:54:50+00:00

We always want to ensure that WRITE and COMMIT completes, whether or not
the user presses ^C. Do this by making the call asynchronous, and allowing
the user to do an interruptible wait for rpc_task completion.

Signed-off-by: Trond Myklebust

NFS: Fix a race with the new commit code

2010-04-09T23:08:17+00:00

This patch fixes a race which occurs due to the fact that we release the
PG_writeback flag while still holding the nfs_page locked.

Signed-off-by: Trond Myklebust

NFS: Ensure that writeback_single_inode() calls write_inode() when syncing

2010-04-09T23:08:17+00:00

Since writeback_single_inode() checks the inode->i_state flags _before_ it
flushes out the data, we need to ensure that the I_DIRTY_DATASYNC flag is
already set. Otherwise we risk not seeing a call to write_inode(), which
again means that we break fsync() et al...

Signed-off-by: Trond Myklebust