linux.git/fs/nfs/write.c, branch v2.6.26

NFS: nfs_updatepage(): don't mark page as dirty if an error occurred

2008-06-23T21:09:07+00:00

Signed-off-by: Trond Myklebust

nfs: fix race in nfs_dirty_request

2008-05-16T16:43:23+00:00

When called from nfs_flush_incompatible, the req is not locked, so
req->wb_page might be set to NULL before it is used by PageWriteback.

Signed-off-by: Fred Isaman 
Signed-off-by: Benny Halevy 
Signed-off-by: Trond Myklebust

NFS: Ensure that rpc_run_task() errors are propagated back to the caller

2008-04-19T20:53:08+00:00

Signed-off-by: Trond Myklebust

NFS: Ensure that the write code cleans up properly when rpc_run_task() fails

2008-04-19T20:53:05+00:00

Signed-off-by: Trond Myklebust

NFS: Fix nfs_wb_page() to always exit with an error or a clean page

2008-04-19T20:52:58+00:00

It is possible for nfs_wb_page() to sometimes exit with 0 return value, yet
the page is left in a dirty state.
For instance in the case where the server rebooted, and the COMMIT request
failed, then all the previously "clean" pages which were cached by the
server, but were not guaranteed to have been writted out to disk,
have to be redirtied and resent to the server.
The fix is to have nfs_wb_page_priority() check that the page is clean
before it exits...

This fixes a condition that triggers the BUG_ON(PagePrivate(page)) in
nfs_create_request() when we're in the nfs_readpage() path.

Also eliminate a redundant BUG_ON(!PageLocked(page)) while we're at it. It
turns out that clear_page_dirty_for_io() has the exact same test.

Signed-off-by: Trond Myklebust

nfs: nfs_redirty_request

2008-03-19T21:59:56+00:00

Both flush functions have the same error handling routine.  Pull
it out as a function.

Signed-off-by: Fred Isaman 
Signed-off-by: Trond Myklebust

Merge branch 'hotfixes' into devel

2008-03-19T21:59:44+00:00

nfs: don't ignore return value from nfs_pageio_add_request

2008-03-19T21:59:02+00:00

Ignoring the return value from nfs_pageio_add_request can cause deadlocks.

In read path:
  call nfs_pageio_add_request from readpage_async_filler
  assume at this point that there are requests already in desc, that
    can't be merged with the current request.
  so nfs_pageio_doio is fired up to clear out desc.
  assume something goes wrong in setting up the io, so desc->pg_error is set.
  This causes nfs_pageio_add_request to return 0, *WITHOUT* adding the original
    request.
  BUT, since return code is ignored, readpage_async_filler assumes it has
    been added, and does nothing further, leaving page locked.
  do_generic_mapping_read will eventually call lock_page, resulting in deadlock

In write path:
  page is marked dirty by generic_perform_write
  nfs_writepages is called
  call nfs_pageio_add_request from nfs_page_async_flush
  assume at this point that there are requests already in desc, that
    can't be merged with the current request.
  so nfs_pageio_doio is fired up to clear out desc.
  assume something goes wrong in setting up the io, so desc->pg_error is set.
  This causes nfs_page_async_flush to return 0, *WITHOUT* adding the original
    request, yet marking the request as locked (PG_BUSY) and in writeback,
    clearing dirty marks.
  The next time a write is done to the page, deadlock will result as
    nfs_write_end calls nfs_update_request

Signed-off-by: Fred Isaman 
Signed-off-by: Trond Myklebust

NFS: Fix an f_mode/f_flags confusion in fs/nfs/write.c

2008-03-07T19:33:40+00:00

O_SYNC is stored in filp->f_flags.
Thanks to Al Viro for pointing out the bug.

Signed-off-by: Trond Myklebust

Merge branch 'cleanups' into next

2008-02-29T07:48:05+00:00