linux.git/fs/nfs/flexfilelayout, branch v6.16

NFSv4/flexfiles: Fix handling of NFS level errors in I/O

2025-06-26T17:46:44+00:00

Allow the flexfiles error handling to recognise NFS level errors (as
opposed to RPC level errors) and handle them separately. The main
motivator is the NFSERR_PERM errors that get returned if the NFS client
connects to the data server through a port number that is lower than
1024. In that case, the client should disconnect and retry a READ on a
different data server, or it should retry a WRITE after reconnecting.

Reviewed-by: Tigran Mkrtchyan 
Fixes: d67ae825a59d ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

flexfiles/pNFS: update stats on NFS4ERR_DELAY for v4.1 DSes

2025-05-28T21:17:14+00:00

On NFS4ERR_DELAY nfs slient updates its stats, but misses for
flexfiles v4.1 DSes.

Signed-off-by: Tigran Mkrtchyan 
Signed-off-by: Anna Schumaker

NFS: always probe for LOCALIO support asynchronously

2025-05-28T21:17:13+00:00

It was reported that NFS client mounts of AWS Elastic File System
(EFS) volumes is slow, this is because the AWS firewall disallows
LOCALIO (because it doesn't consider the use of NFS_LOCALIO_PROGRAM
valid), see: https://bugzilla.redhat.com/show_bug.cgi?id=2335129

Switch to performing the LOCALIO probe asynchronously to address the
potential for the NFS LOCALIO protocol being disallowed and/or slowed
by the remote server's response.

While at it, fix nfs_local_probe_async() to always take/put a
reference on the nfs_client that is using the LOCALIO protocol.
Also, unexport the nfs_local_probe() symbol and make it private to
fs/nfs/localio.c

This change has the side-effect of initially issuing reads, writes and
commits over the wire via SUNRPC until the LOCALIO probe completes.

Suggested-by: Jeff Layton  # to always probe async
Fixes: 76d4cb6345da ("nfs: probe for LOCALIO when v4 client reconnects to server")
Cc: stable@vger.kernel.org # 6.14+
Signed-off-by: Mike Snitzer 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

nfs: don't share pNFS DS connections between net namespaces

2025-04-28T03:25:44+00:00

Currently, different NFS clients can share the same DS connections, even
when they are in different net namespaces. If a containerized client
creates a DS connection, another container can find and use it. When the
first client exits, the connection will close which can lead to stalls
in other clients.

Add a net namespace pointer to struct nfs4_pnfs_ds, and compare those
value to the caller's netns in _data_server_lookup_locked() when
searching for a nfs4_pnfs_ds to match.

Reported-by: Omar Sandoval 
Reported-by: Sargun Dillon 
Closes: https://lore.kernel.org/linux-nfs/Z_ArpQC_vREh_hEA@telecaster/
Tested-by: Sargun Dillon 
Signed-off-by: Jeff Layton 
Reviewed-by: Benjamin Coddington 
Link: https://lore.kernel.org/r/20250410-nfs-ds-netns-v2-1-f80b7979ba80@kernel.org
Signed-off-by: Trond Myklebust

pNFS/flexfiles: Record the RPC errors in the I/O tracepoints

2025-04-28T03:25:44+00:00

When debugging I/O issues, we want to see not just the NFS level errors,
but also the RPC level problems, so record both in the tracepoints.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Report ENETDOWN as a connection error

2025-03-21T16:44:26+00:00

If the client should see an ENETDOWN when trying to connect to the data
server, it might still be able to talk to the metadata server through
another NIC. If so, report the error.

Signed-off-by: Trond Myklebust 
Reviewed-by: Jeff Layton 
Tested-by: Jeff Layton 
Acked-by: Chuck Lever

pNFS/flexfiles: Treat ENETUNREACH errors as fatal in containers

2025-03-21T16:44:24+00:00

Propagate the NFS_MOUNT_NETUNREACH_FATAL flag to work with the pNFS
flexfiles client. In these circumstances, the client needs to treat the
ENETDOWN and ENETUNREACH errors as fatal, and should abandon the
attempted I/O.

Signed-off-by: Trond Myklebust 
Reviewed-by: Jeff Layton 
Tested-by: Jeff Layton 
Acked-by: Chuck Lever

pnfs/flexfiles: retry getting layout segment for reads

2025-01-22T19:26:46+00:00

If ff_layout_pg_get_read()'s attempt to get a layout segment results
in -EAGAIN have ff_layout_pg_init_read() retry it after sleeping.

If "softerr" mount is used, use 'io_maxretrans' to limit the number of
attempts to get a layout segment.

This fixes a long-standing issue of O_DIRECT reads failing with
-EAGAIN (11) when using flexfiles Client Side Mirroring (CSM).

Cc: stable@vger.kernel.org
Signed-off-by: Mike Snitzer 
Signed-off-by: Anna Schumaker

nfs: cache all open LOCALIO nfsd_file(s) in client

2025-01-14T22:04:05+00:00

This commit switches from leaning heavily on NFSD's filecache (in
terms of GC'd nfsd_files) back to caching nfsd_files in the
client. A later commit will add the callback mechanism needed to
allow NFSD to force the NFS client to cleanup all cached nfsd_files.

Add nfs_fh_localio_init() and 'struct nfs_fh_localio' to cache opened
nfsd_file(s) (both a RO and RW nfsd_file is able to be opened and
cached for a given nfs_fh).

Update nfs_local_open_fh() to cache the nfsd_file once it is opened
using __nfs_local_open_fh().

Introduce nfs_close_local_fh() to clear the cached open nfsd_files and
call nfs_to_nfsd_file_put_local().

Refcounting is such that:
- nfs_local_open_fh() is paired with nfs_close_local_fh().
- __nfs_local_open_fh() is paired with nfs_to_nfsd_file_put_local().
- nfs_local_file_get() is paired with nfs_local_file_put().

Signed-off-by: Mike Snitzer 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

pnfs/flexfiles: enable localio support

2024-09-23T19:03:30+00:00

If the DS is local to this client use localio to write the data.

Signed-off-by: Trond Myklebust 
Signed-off-by: Mike Snitzer 
Reviewed-by: NeilBrown 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker