linux.git/fs/nfs/flexfilelayout, branch v5.9

pNFS/flexfiles: Be consistent about mirror index types

2020-09-18T13:25:33+00:00

A mirror index is always of type u32.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Ensure we initialise the mirror bsizes correctly on read

2020-09-18T13:21:10+00:00

While it is true that reading from an unmirrored source always uses
index 0, that is no longer true for mirrored sources when we fail over.

Fixes: 563c53e73b8b ("NFS: Fix flexfiles read failover")
Signed-off-by: Trond Myklebust

treewide: Use fallthrough pseudo-keyword

2020-08-23T22:36:59+00:00

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through

Signed-off-by: Gustavo A. R. Silva

NFS: Fix flexfiles read failover

2020-08-12T15:20:29+00:00

The current mirrored read failover code is correctly resetting the mirror
index between failed reads, however it is not able to actually flip the
RPC call over to the next RPC client.
The end result is that we keep resending the RPC call to the same client
over and over.

The fix is to use the pnfs_read_resend_pnfs() mechanism to schedule a
new RPC call, but we need to add the ability to pass in a mirror
index so that we always retry the next mirror in the list.

Fixes: 166bd5b889ac ("pNFS/flexfiles: Fix layoutstats handling during read failovers")
Signed-off-by: Trond Myklebust

pNFS/flexfiles: The mirror count could depend on the layout segment range

2020-07-13T03:49:55+00:00

Make sure we specify the layout segment range when calculating the
mirror count. In theory, that number could depend on the range to
which we're writing.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Clean up redundant calls to pnfs_put_lseg()

2020-07-13T03:49:55+00:00

Both nfs_pageio_reset_read_mds() and nfs_pageio_reset_write_mds()
do call pnfs_generic_pg_cleanup() for us.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Fix list corruption if the mirror count changes

2020-06-26T12:43:14+00:00

If the mirror count changes in the new layout we pick up inside
ff_layout_pg_init_write(), then we can end up adding the
request to the wrong mirror and corrupting the mirror->pg_list.

Fixes: d600ad1f2bdb ("NFS41: pop some layoutget errors to application")
Cc: stable@vger.kernel.org
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

pNFS/flexfiles: Specify the layout segment range in LAYOUTGET

2020-03-27T20:34:35+00:00

Move from requesting only full file layout segments, to requesting
layout segments that match our I/O size. This means the server is
still free to return a full file layout, but we will no longer
error out if it does not.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: remove requirement for whole file layouts

2020-03-27T20:34:35+00:00

Remove the requirement that the server always sends whole file
layouts.

Signed-off-by: Trond Myklebust

pNFS/flexfiles: Check the layout segment range before doing I/O

2020-03-27T20:34:35+00:00

When starting to read or write with a layout segment, check that the
range matches our request.

Signed-off-by: Trond Myklebust