linux.git/fs/nfs/flexfilelayout/flexfilelayoutdev.c, branch v6.16

NFS: always probe for LOCALIO support asynchronously

2025-05-28T21:17:13+00:00

It was reported that NFS client mounts of AWS Elastic File System
(EFS) volumes is slow, this is because the AWS firewall disallows
LOCALIO (because it doesn't consider the use of NFS_LOCALIO_PROGRAM
valid), see: https://bugzilla.redhat.com/show_bug.cgi?id=2335129

Switch to performing the LOCALIO probe asynchronously to address the
potential for the NFS LOCALIO protocol being disallowed and/or slowed
by the remote server's response.

While at it, fix nfs_local_probe_async() to always take/put a
reference on the nfs_client that is using the LOCALIO protocol.
Also, unexport the nfs_local_probe() symbol and make it private to
fs/nfs/localio.c

This change has the side-effect of initially issuing reads, writes and
commits over the wire via SUNRPC until the LOCALIO probe completes.

Suggested-by: Jeff Layton  # to always probe async
Fixes: 76d4cb6345da ("nfs: probe for LOCALIO when v4 client reconnects to server")
Cc: stable@vger.kernel.org # 6.14+
Signed-off-by: Mike Snitzer 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

nfs: don't share pNFS DS connections between net namespaces

2025-04-28T03:25:44+00:00

Currently, different NFS clients can share the same DS connections, even
when they are in different net namespaces. If a containerized client
creates a DS connection, another container can find and use it. When the
first client exits, the connection will close which can lead to stalls
in other clients.

Add a net namespace pointer to struct nfs4_pnfs_ds, and compare those
value to the caller's netns in _data_server_lookup_locked() when
searching for a nfs4_pnfs_ds to match.

Reported-by: Omar Sandoval 
Reported-by: Sargun Dillon 
Closes: https://lore.kernel.org/linux-nfs/Z_ArpQC_vREh_hEA@telecaster/
Tested-by: Sargun Dillon 
Signed-off-by: Jeff Layton 
Reviewed-by: Benjamin Coddington 
Link: https://lore.kernel.org/r/20250410-nfs-ds-netns-v2-1-f80b7979ba80@kernel.org
Signed-off-by: Trond Myklebust

pnfs/flexfiles: enable localio support

2024-09-23T19:03:30+00:00

If the DS is local to this client use localio to write the data.

Signed-off-by: Trond Myklebust 
Signed-off-by: Mike Snitzer 
Reviewed-by: NeilBrown 
Reviewed-by: Jeff Layton 
Signed-off-by: Anna Schumaker

NFS: Allow setting rsize / wsize to a multiple of PAGE_SIZE

2022-07-12T14:53:10+00:00

Previously, we required this to value to be a power of 2 for UDP related
reasons. This patch keeps the power of 2 rule for UDP but allows more
flexibility for TCP and RDMA.

Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust

pnfs/flexfiles: Fix misplaced barrier in nfs4_ff_layout_prepare_ds

2021-10-04T03:00:50+00:00

_nfs4_pnfs_v3/v4_ds_connect do
   some work
   smp_wmb
   ds->ds_clp = clp;

And nfs4_ff_layout_prepare_ds currently does
   smp_rmb
   if(ds->ds_clp)
      ...

This patch places the smp_rmb after the if. This ensures that following
reads only happen once nfs4_ff_layout_prepare_ds has checked that data
has been properly initialized.

Fixes: d67ae825a59d6 ("pnfs/flexfiles: Add the FlexFile Layout Driver")
Signed-off-by: Baptiste Lepers 
Signed-off-by: Trond Myklebust

SUNRPC: Add xdr_set_scratch_page() and xdr_reset_scratch_buffer()

2020-11-30T19:46:35+00:00

Clean up: De-duplicate some frequently-used code.

Signed-off-by: Chuck Lever

pnfs/flexfiles: Fix PTR_ERR() dereferences in ff_layout_track_ds_error

2019-07-18T18:43:52+00:00

mirror->mirror_ds can be NULL if uninitialised, but can contain
a PTR_ERR() if call to GETDEVICEINFO failed.

Fixes: 65990d1afbd2 ("pNFS/flexfiles: Fix a deadlock on LAYOUTGET")
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org # 4.10+

NFS/flexfiles: Use the correct TCP timeout for flexfiles I/O

2019-06-28T15:48:52+00:00

Fix a typo where we're confusing the default TCP retrans value
(NFS_DEF_TCP_RETRANS) for the default TCP timeout value.

Fixes: 15d03055cf39f ("pNFS/flexfiles: Set reasonable default ...")
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFS/flexfiles: Clean up mirror DS initialisation

2019-03-02T03:37:39+00:00

Get rid of the redundant parameter and rename the function
ff_layout_mirror_valid() to ff_layout_init_mirror_ds() for clarity.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Remove dead code in ff_layout_mirror_valid()

2019-03-02T03:37:38+00:00

nfs4_ff_alloc_deviceid_node() guarantees that if mirror->mirror_ds is
a valid pointer, then so is mirror->mirror_ds->ds.

Signed-off-by: Trond Myklebust