linux.git/fs/nfs/flexfilelayout/flexfilelayoutdev.c, branch v5.3

pnfs/flexfiles: Fix PTR_ERR() dereferences in ff_layout_track_ds_error

2019-07-18T18:43:52+00:00

mirror->mirror_ds can be NULL if uninitialised, but can contain
a PTR_ERR() if call to GETDEVICEINFO failed.

Fixes: 65990d1afbd2 ("pNFS/flexfiles: Fix a deadlock on LAYOUTGET")
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org # 4.10+

NFS/flexfiles: Use the correct TCP timeout for flexfiles I/O

2019-06-28T15:48:52+00:00

Fix a typo where we're confusing the default TCP retrans value
(NFS_DEF_TCP_RETRANS) for the default TCP timeout value.

Fixes: 15d03055cf39f ("pNFS/flexfiles: Set reasonable default ...")
Cc: stable@vger.kernel.org # 4.8+
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFS/flexfiles: Clean up mirror DS initialisation

2019-03-02T03:37:39+00:00

Get rid of the redundant parameter and rename the function
ff_layout_mirror_valid() to ff_layout_init_mirror_ds() for clarity.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Remove dead code in ff_layout_mirror_valid()

2019-03-02T03:37:38+00:00

nfs4_ff_alloc_deviceid_node() guarantees that if mirror->mirror_ds is
a valid pointer, then so is mirror->mirror_ds->ds.

Signed-off-by: Trond Myklebust

NFS/flexfile: Simplify nfs4_ff_layout_select_ds_stateid()

2019-03-02T03:37:38+00:00

Pass in a pointer to the mirror rather than forcing another
array access.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Simplify ff_layout_get_ds_cred()

2019-03-02T03:37:38+00:00

Pass in a pointer to the mirror rather than forcing another
array access.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Simplify nfs4_ff_find_or_create_ds_client()

2019-03-02T03:37:38+00:00

Pass in a pointer to the mirror rather than forcing another
array access.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Simplify nfs4_ff_layout_select_ds_fh()

2019-03-02T03:37:38+00:00

Pass in a pointer to the mirror rather than having to retrieve it from
the array and then verify the resulting pointer.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Don't invalidate DS deviceids for being unresponsive

2019-03-02T03:37:38+00:00

If the DS is unresponsive, we want to just mark it as such, while
reporting the errors. If the server later returns the same deviceid
in a new layout, then we don't want to have to look it up again.

Signed-off-by: Trond Myklebust

NFS/flexfiles: Avoid unnecessary layout invalidations

2019-03-02T03:37:37+00:00

In ff_layout_mirror_valid() we may not want to invalidate the layout
segment despite the call to GETDEVICEINFO failing. The reason is that
a read may still be able to make progress on another mirror.

So instead we let the caller (in this case nfs4_ff_layout_prepare_ds())
decide whether or not it needs to invalidate.

Signed-off-by: Trond Myklebust