linux.git/fs/nfs/callback_proc.c, branch v6.9

NFSv4.1: if referring calls are complete, trust the stateid argument

2024-01-04T15:47:56+00:00

If the server is recalling a layout, and sends us a list of referring
calls that we can see are complete, then we should just trust that the
stateid argument is correct, even if the sequence id doesn't match the
one we hold.

Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4: Track the number of referring calls in struct cb_process_state

2024-01-04T15:47:56+00:00

When the server gives us a set of referring calls, to tell us that the
NFSv4.1 callback needs to be ordered with respect to those calls, then
we may want to make that information available to the operations. In
certain cases, it may allow them to optimise their behaviour due to the
extra knowledge.

Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

nfs: convert to new timestamp accessors

2023-10-18T12:08:23+00:00

Convert to using the new inode timestamp accessor functions.

Signed-off-by: Jeff Layton 
Link: https://lore.kernel.org/r/20231004185347.80880-49-jlayton@kernel.org
Signed-off-by: Christian Brauner

nfs: convert to ctime accessor functions

2023-07-24T08:30:01+00:00

In later patches, we're going to change how the inode's ctime field is
used. Switch to using accessor functions instead of raw accesses of
inode->i_ctime.

Signed-off-by: Jeff Layton 
Reviewed-by: Jan Kara 
Message-Id: <20230705190309.579783-55-jlayton@kernel.org>
Signed-off-by: Christian Brauner

pNFS: Avoid a live lock condition in pnfs_update_layout()

2022-06-06T15:53:55+00:00

If we're about to send the first layoutget for an empty layout, we want
to make sure that we drain out the existing pending layoutget calls
first. The reason is that these layouts may have been already implicitly
returned to the server by a recall to which the client gave a
NFS4ERR_NOMATCHING_LAYOUT response.

The problem is that wait_var_event_killable() could in principle see the
plh_outstanding count go back to '1' when the first process to wake up
starts sending a new layoutget. If it fails to get a layout, then this
loop can continue ad infinitum...

Fixes: 0b77f97a7e42 ("NFSv4/pnfs: Fix layoutget behaviour after invalidation")
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4/pNFS: Fix another issue with a list iterator pointing to the head

2022-03-28T12:36:34+00:00

In nfs4_callback_devicenotify(), if we don't find a matching entry for
the deviceid, we're left with a pointer to 'struct nfs_server' that
actually points to the list of super blocks associated with our struct
nfs_client.
Furthermore, even if we have a valid pointer, nothing pins the super
block, and so the struct nfs_server could end up getting freed while
we're using it.

Since all we want is a pointer to the struct pnfs_layoutdriver_type,
let's skip all the iteration over super blocks, and just use APIs to
find the layout driver directly.

Reported-by: Xiaomeng Tong 
Fixes: 1be5683b03a7 ("pnfs: CB_NOTIFY_DEVICEID")
Signed-off-by: Trond Myklebust

NFSv4.2/copyoffload: Convert GFP_NOFS to GFP_KERNEL

2022-02-25T23:50:12+00:00

There doesn't seem to be any reason why the copy offload code can't use
GFP_KERNEL. It can't get called by direct reclaim.

Signed-off-by: Trond Myklebust

NFSv4.1: Fix uninitialised variable in devicenotify

2022-01-06T19:00:20+00:00

When decode_devicenotify_args() exits with no entries, we need to
ensure that the struct cb_devicenotifyargs is initialised to
{ 0, NULL } in order to avoid problems in
nfs4_callback_devicenotify().

Reported-by: 
Signed-off-by: Trond Myklebust 
Signed-off-by: Anna Schumaker

NFSv4.2 add tracepoint to CB_OFFLOAD

2021-11-04T23:43:30+00:00

Add a tracepoint to the CB_OFFLOAD operation.

Signed-off-by: Olga Kornievskaia 
Signed-off-by: Trond Myklebust

NFSv4.x: Don't return NFS4ERR_NOMATCHING_LAYOUT if we're unmounting

2021-04-16T12:50:21+00:00

If the NFS super block is being unmounted, then we currently may end up
telling the server that we've forgotten the layout while it is actually
still in use by the client.
In that case, just assume that the client will soon return the layout
anyway, and so return NFS4ERR_DELAY in response to the layout recall.

Fixes: 58ac3e59235f ("NFSv4/pnfs: Clean up nfs_layout_find_inode()")
Signed-off-by: Trond Myklebust