linux.git/fs/nfs/callback_proc.c, branch v4.12

NFSv4: Fix an rcu lock leak

2017-05-08T13:27:59+00:00

The intention in the original patch was to release the lock when
we put the inode, however something got screwed up.

Reported-by: Jason Yan 
Fixes: 7b410d9ce460f ("pNFS: Delay getting the layout header in..")
Cc: stable@vger.kernel.org # v4.10+
Signed-off-by: Trond Myklebust

NFS: Remove extra dprintk()s from callback_proc.c

2017-04-20T17:39:32+00:00

Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust

NFS: Clean up nfs4_callback_layoutrecall()

2017-04-20T17:39:32+00:00

In addition to removing the dprintk(), this patch also initializes "res"
to the default return value instead of doing this through an else
condition.

Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust

NFS: Clean up do_callback_layoutrecall()

2017-04-20T17:39:32+00:00

Removing the dprintk()s lets us simplify the function by removing the
else condition entirely and returning the status of
initiate_{file,bulk}_draining() directly.

Signed-off-by: Anna Schumaker 
Signed-off-by: Trond Myklebust

pNFS: Delay getting the layout header in CB_LAYOUTRECALL handlers

2016-12-01T22:21:42+00:00

Instead of grabbing the layout, we want to get the inode so that we
can reduce races between layoutget and layoutrecall when the server
does not support call referring.

Signed-off-by: Trond Myklebust

nfs: allow blocking locks to be awoken by lock callbacks

2016-09-22T19:54:27+00:00

Add a waitqueue head to the client structure. Have clients set a wait
on that queue prior to requesting a lock from the server. If the lock
is blocked, then we can use that to wait for wakeups.

Note that we do need to do this "manually" since we need to set the
wait on the waitqueue prior to requesting the lock, but requesting a
lock can involve activities that can block.

However, only do that for NFSv4.1 locks, either by compiling out
all of the waitqueue handling when CONFIG_NFS_V4_1 is disabled, or
skipping all of it at runtime if we're dealing with v4.0, or v4.1
servers that don't send lock callbacks.

Note too that even when we expect to get a lock callback, RFC5661
section 20.11.4 is pretty clear that we still need to poll for them,
so we do still sleep on a timeout. We do however always poll at the
longest interval in that case.

Signed-off-by: Jeff Layton 
[Anna: nfs4_retry_setlk() "status" should default to -ERESTARTSYS]
Signed-off-by: Anna Schumaker

nfs: add handling for CB_NOTIFY_LOCK in client

2016-09-22T17:56:04+00:00

For now, the callback doesn't do anything. Support for that will be
added in later patches.

Signed-off-by: Jeff Layton 
Signed-off-by: Anna Schumaker

NFSv4.1: Remove obsolete and incorrrect assignment in nfs4_callback_sequence

2016-08-28T18:23:27+00:00

Signed-off-by: Trond Myklebust

NFSv4.1: Delay callback processing when there are referring triples

2016-08-28T18:23:26+00:00

If CB_SEQUENCE tells us that the processing of this request depends on
the completion of one or more referring triples (see RFC 5661 Section
2.10.6.3), delay the callback processing until after the RPC requests
being referred to have completed.
If we end up delaying for more than 1/2 second, then fall back to
returning NFS4ERR_DELAY in reply to the callback.

Signed-off-by: Trond Myklebust

NFSv4.1: Fix Oopsable condition in server callback races

2016-08-28T18:23:22+00:00

The slot table hasn't been an array since v3.7. Ensure that we
use nfs4_lookup_slot() to access the slot correctly.

Fixes: 87dda67e7386 ("NFSv4.1: Allow SEQUENCE to resize the slot table...")
Signed-off-by: Trond Myklebust 
Cc: stable@vger.kernel.org # v3.8+