linux.git/fs/nfs/blocklayout/dev.c, branch v4.9

Fix NULL pointer dereference in bl_free_device().

2016-07-22T19:14:21+00:00

When bl_parse_deviceid() fails in bl_alloc_deviceid_node() on
blkdev_get_by_*() step we get an pnfs_block_dev struct that is
uninitialized except for bdev field which is set to whatever error
blkdev_get_by_*() returns.  bl_free_device() then tries to call
blkdev_put() if bdev is not 0 resulting in a wrong pointer dereference.

Fixing this by setting bdev in struct pnfs_block_dev only if we didn't
get an error from blkdev_get_by_*().

Signed-off-by: Artem Savkov 
Reviewed-by: Benjamin Coddington 
Signed-off-by: Trond Myklebust

nfs/blocklayout: Check max uuids and devices before decoding

2016-07-15T19:51:11+00:00

Avoid nfs return uuids/devices larger than maximum.

Signed-off-by: Kinglong Mee 
Signed-off-by: Trond Myklebust

nfs/blocklayout: Make sure calculate signature length aligned

2016-07-15T19:51:11+00:00

Avoid a bad nfs server return an unaligned length of signature.

Signed-off-by: Kinglong Mee 
Signed-off-by: Trond Myklebust

nfs/blocklayout: support RH/Fedora dm-mpath device nodes

2016-07-15T19:46:08+00:00

Instead of reusing the wwn-* names for multipath devices nodes RHEL and
Fedora introduce new dm-mpath-uuid-* nodes with a slightly different
naming scheme.  Try these names first to ensure we always get a
multipath-capable device if it exists.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

nfs/blocklayout: refactor open-by-wwn

2016-07-15T19:46:08+00:00

The current code works with the standard udev/systemd names, but we'll have
to add another method in the next patch.  Refactor it into a separate helper
to make room for the new variant.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

nfs/blocklayout: use proper fmode for opening block devices

2016-07-15T19:46:08+00:00

This was fixed for the original block layout code a while ago, but also
needs to be fixed for the SCSI layout path.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

nfs/blocklayout: add SCSI layout support

2016-03-18T15:38:17+00:00

This is a trivial extension to the block layout driver to support the
new SCSI layouts draft.  There are three changes:

 - device identifcation through the SCSI VPD page.  This allows us to
   directly use the udev generated persistent device names instead of
   requiring an expensive lookup by crawling every block device node
   in /dev and reading a signature for it.
 - use of SCSI persistent reservations to protect device access and
   allow for robust fencing.  On the client sides this just means
   registering and unregistering a server supplied key.
 - an optimized LAYOUTCOMMIT payload that doesn't send unessecary
   fields to the server.

Signed-off-by: Christoph Hellwig 
Acked-by: Trond Myklebust 
Signed-off-by: J. Bruce Fields

pnfs/blocklayout: pass proper file mode to blkdev_get/put

2015-08-17T18:22:49+00:00

We generally want to read and write to a block device that's used by
the pNFS block layout client (and even if it's read only the server
has no way of telling us).  Add FMODE_WRITE to the mode argument
so that we don't incorrectly tell the block driver that we want a
read-only open.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

pnfs/blocklayout: reject too long signatures

2015-08-17T18:22:49+00:00

Instead of overwriting kernel memory reject too long signatures.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Trond Myklebust

NFSv4.1: Convert pNFS deviceid to use kfree_rcu()

2015-03-27T16:32:24+00:00

Use of synchronize_rcu() when unmounting and potentially freeing a lot
of deviceids is problematic. There really is no reason why we can't just
use kfree_rcu() here.

Signed-off-by: Trond Myklebust