linux.git/fs/namespace.c, branch v2.6.33

do_add_mount() should sanitize mnt_flags

2010-01-16T18:07:36+00:00

MNT_WRITE_HOLD shouldn't leak into new vfsmount and neither
should MNT_SHARED (the latter will be set properly, along with
the rest of shared-subtree data structures)

Signed-off-by: Al Viro

mnt_flags fixes in do_remount()

2010-01-16T18:01:26+00:00

* need vfsmount_lock over modifying it
* need to preserve MNT_SHARED/MNT_UNBINDABLE

Signed-off-by: Al Viro

attach_recursive_mnt() needs to hold vfsmount_lock over set_mnt_shared()

2010-01-16T17:57:40+00:00

race in mnt_flags update

Signed-off-by: Al Viro

may_umount() needs namespace_sem

2010-01-16T17:56:08+00:00

otherwise it races with clone_mnt() changing mnt_share/mnt_slaves

Signed-off-by: Al Viro

Revert "fix mismerge with Trond's stuff (create_mnt_ns() export is gone now)"

2009-12-17T20:51:05+00:00

This reverts commit e9496ff46a20a8592fdc7bdaaf41b45eb808d310. Quoth Al:

 "it's dependent on a lot of other stuff not currently in mainline
  and badly broken with current fs/namespace.c.  Sorry, badly
  out-of-order cherry-pick from old queue.

  PS: there's a large pending series reworking the refcounting and
  lifetime rules for vfsmounts that will, among other things, allow to
  rip a subtree away _without_ dissolving connections in it, to be
  garbage-collected when all active references are gone.  It's
  considerably saner wrt "is the subtree busy" logics, but it's nowhere
  near being ready for merge at the moment; this changeset is one of the
  things becoming possible with that sucker, but it certainly shouldn't
  have been picked during this cycle.  My apologies..."

Noticed-by: Eric Paris 
Requested-by: Al Viro 
Signed-off-by: Linus Torvalds

fix mismerge with Trond's stuff (create_mnt_ns() export is gone now)

2009-12-16T17:16:44+00:00

Signed-off-by: Al Viro

LSM: Pass original mount flags to security_sb_mount().

2009-10-11T23:56:03+00:00

This patch allows LSM modules to determine based on original mount flags
passed to mount(). A LSM module can get masked mount flags (if needed) by

	flags &= ~(MS_NOSUID | MS_NOEXEC | MS_NODEV | MS_ACTIVE |
		   MS_NOATIME | MS_NODIRATIME | MS_RELATIME| MS_KERNMOUNT |
		   MS_STRICTATIME);

Signed-off-by: Tetsuo Handa 
Signed-off-by: James Morris

fs: fix overflow in sys_mount() for in-kernel calls

2009-09-24T12:40:15+00:00

sys_mount() reads/copies a whole page for its "type" parameter.  When
do_mount_root() passes a kernel address that points to an object which is
smaller than a whole page, copy_mount_options() will happily go past this
memory object, possibly dereferencing "wild" pointers that could be in any
state (hence the kmemcheck warning, which shows that parts of the next
page are not even allocated).

(The likelihood of something going wrong here is pretty low -- first of
all this only applies to kernel calls to sys_mount(), which are mostly
found in the boot code.  Secondly, I guess if the page was not mapped,
exact_copy_from_user() _would_ in fact handle it correctly because of its
access_ok(), etc.  checks.)

But it is much nicer to avoid the dubious reads altogether, by stopping as
soon as we find a NUL byte.  Is there a good reason why we can't do
something like this, using the already existing strndup_from_user()?

[akpm@linux-foundation.org: make copy_mount_string() static]
[AV: fix compat mount breakage, which involves undoing akpm's change above]

Reported-by: Ingo Molnar 
Signed-off-by: Vegard Nossum 
Cc: Al Viro 
Cc: Pekka Enberg 
Signed-off-by: Andrew Morton 
Signed-off-by: al

vfs: mnt_want_write_file(): fix special file handling

2009-08-07T17:39:56+00:00

I suspect that mnt_want_write_file() may have wrong assumption.  I think
mnt_want_write_file() is assuming it increments ->mnt_writers if
(file->f_mode & FMODE_WRITE).  But, if it's special_file(), it is false?

Signed-off-by: OGAWA Hirofumi 
Acked-by: Dave Hansen 
Cc: Al Viro 
Cc: Nick Piggin 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

headers: mnt_namespace.h redux

2009-07-08T16:31:56+00:00

Fix various silly problems wrt mnt_namespace.h:

 - exit_mnt_ns() isn't used, remove it
 - done that, sched.h and nsproxy.h inclusions aren't needed
 - mount.h inclusion was need for vfsmount_lock, but no longer
 - remove mnt_namespace.h inclusion from files which don't use anything
   from mnt_namespace.h

Signed-off-by: Alexey Dobriyan 
Signed-off-by: Linus Torvalds