linux.git/fs/namei.c, branch v4.1

path_openat(): fix double fput()

2015-05-09T04:12:48+00:00

path_openat() jumps to the wrong place after do_tmpfile() - it has
already done path_cleanup() (as part of path_lookupat() called by
do_tmpfile()), so doing that again can lead to double fput().

Cc: stable@vger.kernel.org	# v3.11+
Signed-off-by: Al Viro

namei: d_is_negative() should be checked before ->d_seq validation

2015-05-09T04:12:35+00:00

Fetching ->d_inode, verifying ->d_seq and finding d_is_negative() to
be true does *not* mean that inode we'd fetched had been NULL - that
holds only while ->d_seq is still unchanged.

Shift d_is_negative() checks into lookup_fast() prior to ->d_seq
verification.

Reported-by: Steven Rostedt 
Tested-by: Steven Rostedt 
Signed-off-by: Al Viro

RCU pathwalk breakage when running into a symlink overmounting something

2015-04-24T19:52:14+00:00

Calling unlazy_walk() in walk_component() and do_last() when we find
a symlink that needs to be followed doesn't acquire a reference to vfsmount.
That's fine when the symlink is on the same vfsmount as the parent directory
(which is almost always the case), but it's not always true - one _can_
manage to bind a symlink on top of something.  And in such cases we end up
with excessive mntput().

Cc: stable@vger.kernel.org # since 2.6.39
Signed-off-by: Al Viro

VFS: Make pathwalk use d_is_reg() rather than S_ISREG()

2015-04-15T19:05:30+00:00

Make pathwalk use d_is_reg() rather than S_ISREG() to determine whether to
honour O_TRUNC.  Since this occurs after complete_walk(), the dentry type
field cannot change and the inode pointer cannot change as we hold a ref on
the dentry, so this should be safe.

Signed-off-by: David Howells 
Signed-off-by: Al Viro

VFS: Combine inode checks with d_is_negative() and d_is_positive() in pathwalk

2015-04-15T19:05:29+00:00

Where we have:

    	if (!dentry->d_inode || d_is_negative(dentry)) {

type constructions in pathwalk we should be able to eliminate the check of
d_inode and rely solely on the result of d_is_negative() or d_is_positive().

What we do have to take care to do is to read d_inode after calling a
d_is_xxx() typecheck function to get the barriering right.

Signed-off-by: David Howells 
Signed-off-by: Al Viro

remove incorrect comment in lookup_one_len()

2015-04-12T02:24:30+00:00

Signed-off-by: Al Viro

namei.c: fold do_path_lookup() into both callers

2015-04-12T02:24:30+00:00

Signed-off-by: Al Viro

kill struct filename.separate

2015-04-12T02:21:24+00:00

just make const char iname[] the last member and compare name->name with
name->iname instead of checking name->separate

We need to make sure that out-of-line name doesn't end up allocated adjacent
to struct filename refering to it; fortunately, it's easy to achieve - just
allocate that struct filename with one byte in ->iname[], so that ->iname[0]
will be inside the same object and thus have an address different from that
of out-of-line name [spotted by Boqun Feng ]

Signed-off-by: Al Viro

switch path_init() to struct filename

2015-03-24T21:19:16+00:00

Signed-off-by: Al Viro

switch path_mountpoint() to struct filename

2015-03-24T21:19:15+00:00

Signed-off-by: Al Viro