linux.git/fs/logfs/segment.c, branch v3.10 Linux kernel source tree logfs: destroy the reserved inodes while unmounting 2012-04-02T03:50:33+00:00 Prasad Joshi prasadjoshi.linux@gmail.com 2012-03-09T00:57:12+00:00 d2dcd9083f101584e029cbd4f0e1a4e573170d43 We were assuming that the evict_inode() would never be called on reserved inodes. However, (after the commit 8e22c1a4e logfs: get rid of magical inodes) while unmounting the file system, in put_super, we call iput() on all of the reserved inodes. The following simple test used to cause a kernel panic on LogFS: 1. Mount a LogFS file system on /mnt 2. Create a file $ touch /mnt/a 3. Try to unmount the FS $ umount /mnt The simple fix would be to drop the assumption and properly destroy the reserved inodes. Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com> 
We were assuming that the evict_inode() would never be called on
reserved inodes. However, (after the commit 8e22c1a4e logfs: get rid
of magical inodes) while unmounting the file system, in put_super, we
call iput() on all of the reserved inodes.

The following simple test used to cause a kernel panic on LogFS:

1. Mount a LogFS file system on /mnt

2. Create a file
   $ touch /mnt/a

3. Try to unmount the FS
   $ umount /mnt

The simple fix would be to drop the assumption and properly destroy
the reserved inodes.

Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
logfs: remove the second argument of k[un]map_atomic() 2012-03-20T13:48:24+00:00 Cong Wang amwang@redhat.com 2011-11-25T15:14:31+00:00 50bc9b65b6e32f146c3c9812a9d62fe7ff518b5a Signed-off-by: Cong Wang <amwang@redhat.com> 
Signed-off-by: Cong Wang <amwang@redhat.com>
logfs: Free areas before calling generic_shutdown_super() 2012-01-28T06:12:39+00:00 Joern Engel joern@logfs.org 2011-08-05T09:18:19+00:00 1bcceaff8cbe5e5698ccf1015c9a938aa72718c4 Or hit an assertion in map_invalidatepage() instead. Signed-off-by: Joern Engel <joern@logfs.org> 
Or hit an assertion in map_invalidatepage() instead.

Signed-off-by: Joern Engel <joern@logfs.org>
logfs: update page reference count for pined pages 2012-01-28T05:53:10+00:00 Prasad Joshi prasadjoshi.linux@gmail.com 2011-11-26T05:30:47+00:00 96150606e2fb82d242c9e4a414e4e922849f7bf7 LogFS sets PG_private flag to indicate a pined page. We assumed that marking a page as private is enough to ensure its existence. But instead it is necessary to hold a reference count to the page. The change resolves the following BUG BUG: Bad page state in process flush-253:16 pfn:6a6d0 page flags: 0x100000000000808(uptodate|private) Suggested-and-Acked-by: Joern Engel <joern@logfs.org> Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com> 
LogFS sets PG_private flag to indicate a pined page. We assumed that
marking a page as private is enough to ensure its existence. But
instead it is necessary to hold a reference count to the page.

The change resolves the following BUG

BUG: Bad page state in process flush-253:16  pfn:6a6d0
page flags: 0x100000000000808(uptodate|private)

Suggested-and-Acked-by: Joern Engel <joern@logfs.org>
Signed-off-by: Prasad Joshi <prasadjoshi.linux@gmail.com>
logfs: get rid of magical inodes 2010-08-09T20:48:26+00:00 Al Viro viro@zeniv.linux.org.uk 2010-06-07T16:22:31+00:00 8e22c1a4e429e9facf309c7e7a03ba9cdfd7b106 ordering problems at ->kill_sb() time are solved by doing iput() of these suckers in ->put_super() Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> 
ordering problems at ->kill_sb() time are solved by doing iput()
of these suckers in ->put_super()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
logfs: survive logfs_buf_recover read errors 2010-05-04T17:37:04+00:00 Joern Engel joern@logfs.org 2010-05-03T18:54:34+00:00 20503664b008e17976bff1fdbc693c77ebd6f6c9 Refusing to mount beats a kernel crash. Signed-off-by: Joern Engel <joern@logfs.org> 
Refusing to mount beats a kernel crash.

Signed-off-by: Joern Engel <joern@logfs.org>
Merge git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs 2010-04-21T19:31:12+00:00 Linus Torvalds torvalds@linux-foundation.org 2010-04-21T19:31:12+00:00 255f41c59558a346d65a2012420a7573e36dc584 * git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs: [LogFS] Split large truncated into smaller chunks [LogFS] Set s_bdi [LogFS] Prevent mempool_destroy NULL pointer dereference [LogFS] Move assertion [LogFS] Plug 8 byte information leak [LogFS] Prevent memory corruption on large deletes [LogFS] Remove unused method Fix trivial conflict with added header includes in fs/logfs/super.c 
* git://git.kernel.org/pub/scm/linux/kernel/git/joern/logfs:
  [LogFS] Split large truncated into smaller chunks
  [LogFS] Set s_bdi
  [LogFS] Prevent mempool_destroy NULL pointer dereference
  [LogFS] Move assertion
  [LogFS] Plug 8 byte information leak
  [LogFS] Prevent memory corruption on large deletes
  [LogFS] Remove unused method

Fix trivial conflict with added header includes in fs/logfs/super.c
[LogFS] Prevent mempool_destroy NULL pointer dereference 2010-04-15T06:03:57+00:00 Joern Engel joern@logfs.org 2010-04-15T06:03:57+00:00 1f1b0008e8dd1930d6e89522c70f4a438374302a It would probably be better to just accept NULL pointers in mempool_destroy(). But for the current -rc series let's keep things simple. This patch was lost in the cracks for a while. Kevin Cernekee <cernekee@gmail.com> had to rediscover the problem and send a similar patch because of it. :( Signed-off-by: Joern Engel <joern@logfs.org> 
It would probably be better to just accept NULL pointers in
mempool_destroy().  But for the current -rc series let's keep things
simple.

This patch was lost in the cracks for a while.
Kevin Cernekee <cernekee@gmail.com> had to rediscover the problem and
send a similar patch because of it. :(

Signed-off-by: Joern Engel <joern@logfs.org>
Merge branch 'master' into export-slabh 2010-04-05T02:37:28+00:00 Tejun Heo tj@kernel.org 2010-04-05T02:37:28+00:00 336f5899d287f06d8329e208fc14ce50f7ec9698 






[LogFS] Remove unused method
2010-03-30T16:25:17+00:00

Joern Engel
joern@logfs.org

2010-03-30T16:25:17+00:00

e05c378f4973674a16d5b9636f2310cf88aca5f2

All callers are long gone.

Signed-off-by: Joern Engel <joern@logfs.org>





All callers are long gone.

Signed-off-by: Joern Engel <joern@logfs.org>