linux.git/fs/lockd/host.c, branch v2.6.28

NLM: client-side nlm_lookup_host() should avoid matching on srcaddr

2008-11-24T19:29:07+00:00

Since commit c98451bd, the loop in nlm_lookup_host() unconditionally
compares the host's h_srcaddr field to the incoming source address.
For client-side nlm_host entries, both are always AF_UNSPEC, so this
check is unnecessary.

Since commit 781b61a6, which added support for AF_INET6 addresses to
nlm_cmp_addr(), nlm_cmp_addr() now returns FALSE for AF_UNSPEC
addresses, which causes nlm_lookup_host() to create a fresh nlm_host
entry every time it is called on the client.

These extra entries will eventually expire once the server is
unmounted, so the impact of this regression, introduced with lockd
IPv6 support in 2.6.28, should be minor.

We could fix this by adding an arm in nlm_cmp_addr() for AF_UNSPEC
addresses, but really, nlm_lookup_host() shouldn't be matching on the
srcaddr field for client-side nlm_host lookups.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Adjust nlmsvc_lookup_host() to accomodate AF_INET6 addresses

2008-10-03T21:02:35+00:00

Fix up nlmsvc_lookup_host() to pass AF_INET6 source addresses to
nlm_lookup_host().

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Adjust nlmclnt_lookup_host() signature to accomodate non-AF_INET

2008-10-03T21:02:34+00:00

Pass a struct sockaddr * and a length to nlmclnt_lookup_host() to
accomodate non-AF_INET family addresses.

As a side benefit, eliminate the hostname_len argument, as the hostname
is always NUL-terminated.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Support non-AF_INET addresses in nlm_lookup_host()

2008-10-03T21:01:57+00:00

Use struct sockaddr * and length in nlm_lookup_host_info to all callers
to pass in either AF_INET or AF_INET6 addresses.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

NLM: Convert nlm_lookup_host() to use a single argument

2008-10-03T20:58:23+00:00

The nlm_lookup_host() function already has a large number of arguments,
and I'm about to add a few more.  As a clean up, convert the function
to use a single data structure argument.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Update nsm_find() to support non-AF_INET addresses

2008-09-29T22:13:39+00:00

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Combine __nsm_find() and nsm_find().

2008-09-29T22:13:39+00:00

Clean up: Having two separate functions doesn't add clarity, so
eliminate one of them.  Use contemporary kernel coding conventions
where appropriate.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Support AF_INET6 when hashing addresses in nlm_lookup_host

2008-09-29T22:13:39+00:00

Adopt an approach similar to the RPC server's auth cache (from Aurelien
Charbon and Brian Haley).

Note nlm_lookup_host()'s existing IP address hash function has the same
issue with correctness on little-endian systems as the original IPv4 auth
cache hash function, so I've also updated it with a hash function similar
to the new auth cache hash function.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

lockd: Teach nlm_cmp_addr() to support AF_INET6 addresses

2008-09-29T22:13:39+00:00

Update the nlm_cmp_addr() helper to support AF_INET6 as well as AF_INET
addresses.  New version takes two "struct sockaddr *" arguments instead of
"struct sockaddr_in *" arguments.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields

NSM: Use sockaddr_storage for sm_addr field

2008-09-29T22:13:39+00:00

To store larger addresses in the nsm_handle structure, make sm_addr a
sockaddr_storage.

Signed-off-by: Chuck Lever 
Signed-off-by: J. Bruce Fields