linux.git/fs/ksmbd, branch v5.19

vfs: fix copy_file_range() regression in cross-fs copies

2022-06-30T22:16:38+00:00

A regression has been reported by Nicolas Boichat, found while using the
copy_file_range syscall to copy a tracefs file.

Before commit 5dae222a5ff0 ("vfs: allow copy_file_range to copy across
devices") the kernel would return -EXDEV to userspace when trying to
copy a file across different filesystems.  After this commit, the
syscall doesn't fail anymore and instead returns zero (zero bytes
copied), as this file's content is generated on-the-fly and thus reports
a size of zero.

Another regression has been reported by He Zhe - the assertion of
WARN_ON_ONCE(ret == -EOPNOTSUPP) can be triggered from userspace when
copying from a sysfs file whose read operation may return -EOPNOTSUPP.

Since we do not have test coverage for copy_file_range() between any two
types of filesystems, the best way to avoid these sort of issues in the
future is for the kernel to be more picky about filesystems that are
allowed to do copy_file_range().

This patch restores some cross-filesystem copy restrictions that existed
prior to commit 5dae222a5ff0 ("vfs: allow copy_file_range to copy across
devices"), namely, cross-sb copy is not allowed for filesystems that do
not implement ->copy_file_range().

Filesystems that do implement ->copy_file_range() have full control of
the result - if this method returns an error, the error is returned to
the user.  Before this change this was only true for fs that did not
implement the ->remap_file_range() operation (i.e.  nfsv3).

Filesystems that do not implement ->copy_file_range() still fall-back to
the generic_copy_file_range() implementation when the copy is within the
same sb.  This helps the kernel can maintain a more consistent story
about which filesystems support copy_file_range().

nfsd and ksmbd servers are modified to fall-back to the
generic_copy_file_range() implementation in case vfs_copy_file_range()
fails with -EOPNOTSUPP or -EXDEV, which preserves behavior of
server-side-copy.

fall-back to generic_copy_file_range() is not implemented for the smb
operation FSCTL_DUPLICATE_EXTENTS_TO_FILE, which is arguably a correct
change of behavior.

Fixes: 5dae222a5ff0 ("vfs: allow copy_file_range to copy across devices")
Link: https://lore.kernel.org/linux-fsdevel/20210212044405.4120619-1-drinkcat@chromium.org/
Link: https://lore.kernel.org/linux-fsdevel/CANMq1KDZuxir2LM5jOTm0xx+BnvW=ZmpsG47CyHFJwnw7zSX6Q@mail.gmail.com/
Link: https://lore.kernel.org/linux-fsdevel/20210126135012.1.If45b7cdc3ff707bc1efa17f5366057d60603c45f@changeid/
Link: https://lore.kernel.org/linux-fsdevel/20210630161320.29006-1-lhenriques@suse.de/
Reported-by: Nicolas Boichat 
Reported-by: kernel test robot 
Signed-off-by: Luis Henriques 
Fixes: 64bf5ff58dff ("vfs: no fallback for ->copy_file_range")
Link: https://lore.kernel.org/linux-fsdevel/20f17f64-88cb-4e80-07c1-85cb96c83619@windriver.com/
Reported-by: He Zhe 
Tested-by: Namjae Jeon 
Tested-by: Luis Henriques 
Signed-off-by: Amir Goldstein 
Signed-off-by: Linus Torvalds

ksmbd: use vfs_llseek instead of dereferencing NULL

2022-06-26T00:52:49+00:00

By not checking whether llseek is NULL, this might jump to NULL. Also,
it doesn't check FMODE_LSEEK. Fix this by using vfs_llseek(), which
always does the right thing.

Fixes: f44158485826 ("cifsd: add file operations")
Cc: stable@vger.kernel.org
Cc: linux-cifs@vger.kernel.org
Cc: Ronnie Sahlberg 
Cc: Hyunchul Lee 
Cc: Sergey Senozhatsky 
Reviewed-by: Namjae Jeon 
Acked-by: Al Viro 
Signed-off-by: Jason A. Donenfeld 
Signed-off-by: Steve French

ksmbd: check invalid FileOffset and BeyondFinalZero in FSCTL_ZERO_DATA

2022-06-24T04:30:46+00:00

FileOffset should not be greater than BeyondFinalZero in FSCTL_ZERO_DATA.
And don't call ksmbd_vfs_zero_data() if length is zero.

Cc: stable@vger.kernel.org
Reviewed-by: Hyunchul Lee 
Signed-off-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: set the range of bytes to zero without extending file size in FSCTL_ZERO_DATA

2022-06-24T04:30:46+00:00

generic/091, 263 test failed since commit f66f8b94e7f2 ("cifs: when
extending a file with falloc we should make files not-sparse").
FSCTL_ZERO_DATA sets the range of bytes to zero without extending file
size. The VFS_FALLOCATE_FL_KEEP_SIZE flag should be used even on
non-sparse files.

Cc: stable@vger.kernel.org
Reviewed-by: Hyunchul Lee 
Signed-off-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: remove duplicate flag set in smb2_write

2022-06-24T04:30:46+00:00

The writethrough flag is set again if is_rdma_channel is false.

Signed-off-by: Hyunchul Lee 
Acked-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: smbd: Remove useless license text when SPDX-License-Identifier is already used

2022-06-11T16:18:26+00:00

An SPDX-License-Identifier is already in place. There is no need to
duplicate part of the corresponding license.

Signed-off-by: Christophe JAILLET 
Acked-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: use SOCK_NONBLOCK type for kernel_accept()

2022-06-11T16:18:26+00:00

I found that normally it is O_NONBLOCK but there are different value
for some arch.

/include/linux/net.h:
#ifndef SOCK_NONBLOCK
#define SOCK_NONBLOCK   O_NONBLOCK
#endif

/arch/alpha/include/asm/socket.h:
#define SOCK_NONBLOCK   0x40000000

Use SOCK_NONBLOCK instead of O_NONBLOCK for kernel_accept().

Suggested-by: David Howells 
Signed-off-by: Namjae Jeon 
Reviewed-by: Hyunchul Lee 
Signed-off-by: Steve French

ksmbd: smbd: relax the count of sges required

2022-05-28T02:31:20+00:00

Remove the condition that the count of sges
must be greater than or equal to
SMB_DIRECT_MAX_SEND_SGES(8).
Because ksmbd needs sges only for SMB direct
header, SMB2 transform header, SMB2 response,
and optional payload.

Signed-off-by: Hyunchul Lee 
Acked-by: Namjae Jeon 
Reviewed-by: Tom Talpey 
Signed-off-by: Steve French

ksmbd: fix outstanding credits related bugs

2022-05-21T20:01:43+00:00

outstanding credits must be initialized to 0,
because it means the sum of credits consumed by
in-flight requests.
And outstanding credits must be compared with
total credits in smb2_validate_credit_charge(),
because total credits are the sum of credits
granted by ksmbd.

This patch fix the following error,
while frametest with Windows clients:

Limits exceeding the maximum allowable outstanding requests,
given : 128, pending : 8065

Fixes: b589f5db6d4a ("ksmbd: limits exceeding the maximum allowable outstanding requests")
Cc: stable@vger.kernel.org
Signed-off-by: Hyunchul Lee 
Reported-by: Yufan Chen 
Tested-by: Yufan Chen 
Acked-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: smbd: fix connection dropped issue

2022-05-21T20:01:43+00:00

When there are bursty connection requests,
RDMA connection event handler is deferred and
Negotiation requests are received even if
connection status is NEW.

To handle it, set the status to CONNECTED
if Negotiation requests are received.

Reported-by: Yufan Chen 
Signed-off-by: Hyunchul Lee 
Tested-by: Yufan Chen 
Acked-by: Namjae Jeon 
Signed-off-by: Steve French