linux.git/fs/ksmbd, branch v5.16

ksmbd: disable SMB2_GLOBAL_CAP_ENCRYPTION for SMB 3.1.1

2021-12-18T01:19:45+00:00

According to the official Microsoft MS-SMB2 document section 3.3.5.4, this
flag should be used only for 3.0 and 3.0.2 dialects. Setting it for 3.1.1
is a violation of the specification.

This causes my Windows 10 client to detect an anomaly in the negotiation,
and disable encryption entirely despite being explicitly enabled in ksmbd,
causing all data transfers to go in plain text.

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Namjae Jeon 
Signed-off-by: Marcos Del Sol Vives 
Signed-off-by: Steve French

ksmbd: fix uninitialized symbol 'pntsd_size'

2021-12-16T18:36:49+00:00

No check for if "rc" is an error code for build_sec_desc().
This can cause problems with using uninitialized pntsd_size.

Fixes: e2f34481b24d ("cifsd: add server-side procedures for SMB3")
Cc: stable@vger.kernel.org # v5.15
Reported-by: Dan Carpenter 
Signed-off-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: fix error code in ndr_read_int32()

2021-12-16T18:36:49+00:00

This is a failure path and it should return -EINVAL instead of success.
Otherwise it could result in the caller using uninitialized memory.

Fixes: 303fff2b8c77 ("ksmbd: add validation for ndr read/write functions")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Namjae Jeon 
Signed-off-by: Dan Carpenter 
Signed-off-by: Steve French

ksmbd: fix memleak in get_file_stream_info()

2021-11-25T06:09:26+00:00

Fix memleak in get_file_stream_info()

Fixes: 34061d6b76a4 ("ksmbd: validate OutputBufferLength of QUERY_DIR, QUERY_INFO, IOCTL requests")
Cc: stable@vger.kernel.org # v5.15
Reported-by: Coverity Scan 
Acked-by: Hyunchul Lee 
Signed-off-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: contain default data stream even if xattr is empty

2021-11-25T06:09:26+00:00

If xattr is not supported like exfat or fat, ksmbd server doesn't
contain default data stream in FILE_STREAM_INFORMATION response. It will
cause ppt or doc file update issue if local filesystem is such as ones.
This patch move goto statement to contain it.

Fixes: 9f6323311c70 ("ksmbd: add default data stream name in FILE_STREAM_INFORMATION")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Hyunchul Lee 
Signed-off-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: downgrade addition info error msg to debug in smb2_get_info_sec()

2021-11-25T06:09:26+00:00

While file transfer through windows client, This error flood message
happen. This flood message will cause performance degradation and
misunderstand server has problem.

Fixes: e294f78d3478 ("ksmbd: allow PROTECTED_DACL_SECINFO and UNPROTECTED_DACL_SECINFO addition information in smb2 set info security")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Hyunchul Lee 
Signed-off-by: Namjae Jeon 
Signed-off-by: Steve French

ksmbd: Fix an error handling path in 'smb2_sess_setup()'

2021-11-25T06:09:26+00:00

All the error handling paths of 'smb2_sess_setup()' end to 'out_err'.

All but the new error handling path added by the commit given in the Fixes
tag below.

Fix this error handling path and branch to 'out_err' as well.

Fixes: 0d994cd482ee ("ksmbd: add buffer validation in session setup")
Cc: stable@vger.kernel.org # v5.15
Acked-by: Namjae Jeon 
Signed-off-by: Christophe JAILLET 
Signed-off-by: Steve French

ksmbd: Use the SMB3_Create definitions from the shared

2021-11-12T01:22:58+00:00

Acked-by: Namjae Jeon 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

ksmbd: Move more definitions into the shared area

2021-11-12T01:22:58+00:00

Move SMB2_SessionSetup, SMB2_Close, SMB2_Read, SMB2_Write and
SMB2_ChangeNotify commands into smbfs_common/smb2pdu.h

Acked-by: Namjae Jeon 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French

ksmbd: use the common definitions for NEGOTIATE_PROTOCOL

2021-11-12T01:22:58+00:00

Acked-by: Namjae Jeon 
Signed-off-by: Ronnie Sahlberg 
Signed-off-by: Steve French