linux.git/fs/jffs2/readinode.c, branch v5.2

jffs2: fix use-after-free on symlink traversal

2019-04-01T04:31:02+00:00

free the symlink body after the same RCU delay we have for freeing the
struct inode itself, so that traversal during RCU pathwalk wouldn't step
into freed memory.

Signed-off-by: Al Viro

jffs2: fix spelling mistake: "requestied" -> "requested"

2017-04-19T18:35:55+00:00

trivial fix to spelling mistake in JFFS2_ERROR message

Signed-off-by: Colin Ian King 
[Brian: also fix 'an' -> 'a']
Signed-off-by: Brian Norris

vfs: make the string hashes salt the hash

2016-06-11T03:21:46+00:00

We always mixed in the parent pointer into the dentry name hash, but we
did it late at lookup time.  It turns out that we can simplify that
lookup-time action by salting the hash with the parent pointer early
instead of late.

A few other users of our string hashes also wanted to mix in their own
pointers into the hash, and those are updated to use the same mechanism.

Hash users that don't have any particular initial salt can just use the
NULL pointer as a no-salt.

Cc: Vegard Nossum 
Cc: George Spelvin 
Cc: Al Viro 
Signed-off-by: Linus Torvalds

jffs2: fix a memleak in read_direntry()

2015-10-04T21:30:50+00:00

Need to free the memory allocated for 'fd' if failed to read all
of the remainder name.

Signed-off-by: Wei Fang 
Signed-off-by: Brian Norris

jffs2: fix unbalanced locking

2015-05-07T23:20:53+00:00

Li Zefan reported an unbalanced locking issue, found by his
internal debugging feature on runtime. The particular case he was
looking at doesn't lead to a deadlock, as the structure that this lock
is embedded in is freed on error. But we should straighten out the error
handling.

Because several callers of jffs2_do_read_inode_internal() /
jffs2_do_read_inode() already handle the locking/unlocking and inode
clearing at their own level, let's just push any unlocks/clearing down
to the caller. This consistency is much easier to verify.

Reported-by: Li Zefan 
Cc: David Woodhouse 
Cc: Artem Bityutskiy 
Cc: Andrew Morton 
Signed-off-by: Brian Norris

jffs2: Drop bogus if in comment

2014-11-29T02:23:44+00:00

Signed-off-by: Geert Uytterhoeven 
Cc: David Woodhouse 
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Brian Norris

fs/jffs2: use rbtree postorder iteration helper instead of opencoding

2014-01-24T00:37:03+00:00

Use rbtree_postorder_for_each_entry_safe() to destroy the rbtree instead
of opencoding an alternate postorder iteration that modifies the tree

Signed-off-by: Cody P Schafer 
Cc: Michel Lespinasse 
Cc: Jan Kara 
Cc: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rbtree: move some implementation details from rbtree.h to rbtree.c

2012-10-09T07:22:32+00:00

rbtree users must use the documented APIs to manipulate the tree
structure.  Low-level helpers to manipulate node colors and parenthood are
not part of that API, so move them to lib/rbtree.c

[dwmw2@infradead.org: fix jffs2 build issue due to renamed __rb_parent_color field]
Signed-off-by: Michel Lespinasse 
Cc: Andrea Arcangeli 
Acked-by: David Woodhouse 
Cc: Rik van Riel 
Cc: Peter Zijlstra 
Cc: Daniel Santos 
Cc: Jens Axboe 
Cc: "Eric W. Biederman" 
Signed-off-by: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

jffs2: allow to complete xattr integrity check on first GC scan

2012-05-14T04:32:36+00:00

Unlike file data integrity the xattr data integrity was not checked
before some explicit access to the attribute was made.

This could leave in the system a number of corrupted extended attributes
which will be detected only at access time and possibly at a very late
time compared to the time the corruption actually happened.

This patch adds the ability to check for extended attribute integrity
on first GC scan pass (similar to file data integrity check). This allows
for all present attributes to be completly verified before any use of them.

In order to work correctly this patch also needs the patch allowing
JFFS2 to discriminate between recoverable and non recoverable errors
on extended attributes.

Signed-off-by: Jean-Christophe DUBOIS 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: refactor csize usage in jffs2_do_read_inode_internal()

2012-05-14T04:08:57+00:00

Replace the verbose `je32_to_cpu(latest_node->csize)' with a shorter
`csize'.

Signed-off-by: Xi Wang 
Cc: Artem Bityutskiy 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse