linux.git/fs/jffs2/readinode.c, branch v4.2

jffs2: fix unbalanced locking

2015-05-07T23:20:53+00:00

Li Zefan reported an unbalanced locking issue, found by his
internal debugging feature on runtime. The particular case he was
looking at doesn't lead to a deadlock, as the structure that this lock
is embedded in is freed on error. But we should straighten out the error
handling.

Because several callers of jffs2_do_read_inode_internal() /
jffs2_do_read_inode() already handle the locking/unlocking and inode
clearing at their own level, let's just push any unlocks/clearing down
to the caller. This consistency is much easier to verify.

Reported-by: Li Zefan 
Cc: David Woodhouse 
Cc: Artem Bityutskiy 
Cc: Andrew Morton 
Signed-off-by: Brian Norris

jffs2: Drop bogus if in comment

2014-11-29T02:23:44+00:00

Signed-off-by: Geert Uytterhoeven 
Cc: David Woodhouse 
Cc: linux-mtd@lists.infradead.org
Signed-off-by: Brian Norris

fs/jffs2: use rbtree postorder iteration helper instead of opencoding

2014-01-24T00:37:03+00:00

Use rbtree_postorder_for_each_entry_safe() to destroy the rbtree instead
of opencoding an alternate postorder iteration that modifies the tree

Signed-off-by: Cody P Schafer 
Cc: Michel Lespinasse 
Cc: Jan Kara 
Cc: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

rbtree: move some implementation details from rbtree.h to rbtree.c

2012-10-09T07:22:32+00:00

rbtree users must use the documented APIs to manipulate the tree
structure.  Low-level helpers to manipulate node colors and parenthood are
not part of that API, so move them to lib/rbtree.c

[dwmw2@infradead.org: fix jffs2 build issue due to renamed __rb_parent_color field]
Signed-off-by: Michel Lespinasse 
Cc: Andrea Arcangeli 
Acked-by: David Woodhouse 
Cc: Rik van Riel 
Cc: Peter Zijlstra 
Cc: Daniel Santos 
Cc: Jens Axboe 
Cc: "Eric W. Biederman" 
Signed-off-by: David Woodhouse 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

jffs2: allow to complete xattr integrity check on first GC scan

2012-05-14T04:32:36+00:00

Unlike file data integrity the xattr data integrity was not checked
before some explicit access to the attribute was made.

This could leave in the system a number of corrupted extended attributes
which will be detected only at access time and possibly at a very late
time compared to the time the corruption actually happened.

This patch adds the ability to check for extended attribute integrity
on first GC scan pass (similar to file data integrity check). This allows
for all present attributes to be completly verified before any use of them.

In order to work correctly this patch also needs the patch allowing
JFFS2 to discriminate between recoverable and non recoverable errors
on extended attributes.

Signed-off-by: Jean-Christophe DUBOIS 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: refactor csize usage in jffs2_do_read_inode_internal()

2012-05-14T04:08:57+00:00

Replace the verbose `je32_to_cpu(latest_node->csize)' with a shorter
`csize'.

Signed-off-by: Xi Wang 
Cc: Artem Bityutskiy 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: validate symlink size in jffs2_do_read_inode_internal()

2012-05-14T04:05:15+00:00

`csize' is read from disk and thus needs validation.  Otherwise a bogus
value 0xffffffff would turn the subsequent kmalloc(csize + 1, ...) into
kmalloc(0, ...), leading to out-of-bounds write.

This patch limits `csize' to JFFS2_MAX_NAME_LEN, which is also used
in jffs2_symlink().

Artem: we actually validate csize by checking CRC, so this 0xFFs cannot
come from empty flash region. But I guess an attacker could feed JFFS2
an image with random csize value, including 0xFFs.

Signed-off-by: Xi Wang 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: Use pr_fmt and remove jffs: from formats

2012-03-26T23:40:19+00:00

Use pr_fmt to prefix KBUILD_MODNAME to appropriate logging messages.

Remove now unnecessary internal prefixes from formats.

Signed-off-by: Joe Perches 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: do use mtd->point directly

2012-01-09T18:26:09+00:00

Remove direct usage of the "mtd->point" function pointer. Instead,
test the mtd_point() return code for '-EOPNOTSUPP'.

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

mtd: introduce mtd_unpoint interface

2012-01-09T18:25:17+00:00

Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse