linux.git/fs/jffs2/file.c, branch v4.2

make new_sync_{read,write}() static

2015-04-12T02:29:40+00:00

All places outside of core VFS that checked ->read and ->write for being NULL or
called the methods directly are gone now, so NULL {read,write} with non-NULL
{read,write}_iter will do the right thing in all cases.

Signed-off-by: Al Viro

write_iter variants of {__,}generic_file_aio_write()

2014-05-06T21:38:00+00:00

Signed-off-by: Al Viro

switch simple generic_file_aio_read() users to ->read_iter()

2014-05-06T21:37:55+00:00

Signed-off-by: Al Viro

jffs2: use generic posix ACL infrastructure

2014-01-26T04:58:20+00:00

Also don't bother to set up a .get_acl method for symlinks as we do not
support access control (ACLs or even mode bits) for symlinks in Linux.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

jffs2: Fix lock acquisition order bug in jffs2_write_begin

2012-11-09T15:02:50+00:00

jffs2_write_begin() first acquires the page lock, then f->sem. This
causes an AB-BA deadlock with jffs2_garbage_collect_live(), which first
acquires f->sem, then the page lock:

jffs2_garbage_collect_live
    mutex_lock(&f->sem)                         (A)
    jffs2_garbage_collect_dnode
        jffs2_gc_fetch_page
            read_cache_page_async
                do_read_cache_page
                    lock_page(page)             (B)

jffs2_write_begin
    grab_cache_page_write_begin
        find_lock_page
            lock_page(page)                     (B)
    mutex_lock(&f->sem)                         (A)

We fix this by restructuring jffs2_write_begin() to take f->sem before
the page lock. However, we make sure that f->sem is not held when
calling jffs2_reserve_space(), as this is not permitted by the locking
rules.

The deadlock above was observed multiple times on an SoC with a dual
ARMv7 (Cortex-A9), running the long-term 3.4.11 kernel; it occurred
when using scp to copy files from a host system to the ARM target
system. The fix was heavily tested on the same target system.

Cc: stable@vger.kernel.org
Signed-off-by: Thomas Betker 
Acked-by: Joakim Tjernlund 
Signed-off-by: Artem Bityutskiy

userns: Convert jffs2 to use kuid and kgid where appropriate

2012-09-21T10:13:33+00:00

- General routine uid/gid conversion work
- When storing posix acls treat ACL_USER and ACL_GROUP separately
  so I can call from_kuid or from_kgid as appropriate.
- When reading posix acls treat ACL_USER and ACL_GROUP separately
  so I can call make_kuid or make_kgid as appropriate.

Cc: David Woodhouse 
Signed-off-by: Eric W. Biederman

jffs2: Use pr_fmt and remove jffs: from formats

2012-03-26T23:40:19+00:00

Use pr_fmt to prefix KBUILD_MODNAME to appropriate logging messages.

Remove now unnecessary internal prefixes from formats.

Signed-off-by: Joe Perches 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

jffs2: Convert most D1/D2 macros to jffs2_dbg

2012-03-26T23:39:24+00:00

D1 and D2 macros are mostly uses to emit debugging messages.

Convert the logging uses of D1 & D2 to jffs2_dbg(level, fmt, ...)
to be a bit more consistent style with the rest of the kernel.

All jffs2_dbg output is now at KERN_DEBUG where some of
the previous uses were emitted at various KERN_s.

Signed-off-by: Joe Perches 
Signed-off-by: Artem Bityutskiy 
Signed-off-by: David Woodhouse

fs: take the ACL checks to common code

2011-07-25T18:30:23+00:00

Replace the ->check_acl method with a ->get_acl method that simply reads an
ACL from disk after having a cache miss.  This means we can replace the ACL
checking boilerplate code with a single implementation in namei.c.

Signed-off-by: Christoph Hellwig 
Signed-off-by: Al Viro

fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers

2011-07-21T00:47:59+00:00

Btrfs needs to be able to control how filemap_write_and_wait_range() is called
in fsync to make it less of a painful operation, so push down taking i_mutex and
the calling of filemap_write_and_wait() down into the ->fsync() handlers.  Some
file systems can drop taking the i_mutex altogether it seems, like ext3 and
ocfs2.  For correctness sake I just pushed everything down in all cases to make
sure that we keep the current behavior the same for everybody, and then each
individual fs maintainer can make up their mind about what to do from there.
Thanks,

Acked-by: Jan Kara 
Signed-off-by: Josef Bacik 
Signed-off-by: Al Viro