linux.git/fs/jbd, branch v2.6.33

jbd: jbd-debug and jbd2-debug should be writable

2009-12-23T12:44:13+00:00

jbd-debug and jbd2-debug is currently read-only (S_IRUGO), which is not
correct. Make it writable so that we can start debuging.

Signed-off-by: Yin Kangkai 
Reviewed-by: Aneesh Kumar K.V 
Signed-off-by: Andrew Morton 
Signed-off-by: Jan Kara

Revert "task_struct: make journal_info conditional"

2009-12-17T21:23:24+00:00

This reverts commit e4c570c4cb7a95dbfafa3d016d2739bf3fdfe319, as
requested by Alexey:

 "I think I gave a good enough arguments to not merge it.
  To iterate:
   * patch makes impossible to start using ext3 on EXT3_FS=n kernels
     without reboot.
   * this is done only for one pointer on task_struct"

  None of config options which define task_struct are tristate directly
  or effectively."

Requested-by: Alexey Dobriyan 
Acked-by: Andrew Morton 
Signed-off-by: Linus Torvalds

task_struct: make journal_info conditional

2009-12-15T16:53:27+00:00

journal_info in task_struct is used in journaling file system only.  So
introduce CONFIG_FS_JOURNAL_INFO and make it conditional.

Signed-off-by: Hiroshi Shimamoto 
Cc: Chris Mason 
Cc: "Theodore Ts'o" 
Cc: Steven Whitehouse 
Cc: KONISHI Ryusuke 
Signed-off-by: Andrew Morton 
Signed-off-by: Linus Torvalds

fs/jbd: Export log_start_commit to fix ext3 build.

2009-11-12T09:24:12+00:00

This fixes:
ERROR: "log_start_commit" [fs/ext3/ext3.ko] undefined!

Signed-off-by: Stefan Schmidt

JBD/JBD2: free j_wbuf if journal init fails.

2009-11-11T14:24:14+00:00

If journal init fails, we need to free j_wbuf.

Cc: Andrew Morton 
Cc: Jan Kara 
Signed-off-by: Tao Ma 
Signed-off-by: Jan Kara

jbd: Annotate transaction start also for journal_restart()

2009-09-16T15:44:10+00:00

lockdep annotation for a transaction start has been at the end of
journal_start(). But a transaction is also started from journal_restart(). Move
the lockdep annotation to start_this_handle() which covers both cases.

Signed-off-by: Jan Kara

jbd: Journal block numbers can ever be only 32-bit use unsigned int for them

2009-09-16T15:44:10+00:00

It does not make sense to store block number for journal as unsigned long
since they can be only 32-bit (because of on-disk format limitation). So
change in-memory structures and variables to use unsigned int instead.

Signed-off-by: Jan Kara

JBD: round commit timer up to avoid uncommitted transaction

2009-09-16T15:44:10+00:00

Fix jiffie rounding in jbd commit timer setup code.  Rounding down could cause
the timer to be fired before the corresponding transaction has expired.  That
transaction can stay not committed forever if no new transaction is created or
explicit sync/umount happens.

Signed-off-by: Andreas Dilger 
Signed-off-by: Jan Kara

jbd: fix race between write_metadata_buffer and get_write_access

2009-07-21T09:54:42+00:00

The function journal_write_metadata_buffer() calls jbd_unlock_bh_state(bh_in)
too early; this could potentially allow another thread to call get_write_access
on the buffer head, modify the data, and dirty it, and allowing the wrong data
to be written into the journal.  Fortunately, if we lose this race, the only
time this will actually cause filesystem corruption is if there is a system
crash or other unclean shutdown of the system before the next commit can take
place.

Signed-off-by: dingdinghua 
Acked-by: "Theodore Ts'o" 
Signed-off-by: Jan Kara

jbd: Fix a race between checkpointing code and journal_get_write_access()

2009-07-15T19:30:07+00:00

The following race can happen:

  CPU1                          CPU2
                                checkpointing code checks the buffer, adds
                                  it to an array for writeback
do_get_write_access()
  ...
  lock_buffer()
  unlock_buffer()
                                  flush_batch() submits the buffer for IO
  __jbd_journal_file_buffer()

  So a buffer under writeout is returned from do_get_write_access(). Since
the filesystem code relies on the fact that journaled buffers cannot be
written out, it does not take the buffer lock and so it can modify buffer
while it is under writeout. That can lead to a filesystem corruption
if we crash at the right moment. The similar problem can happen with
the journal_get_create_access() path.
  We fix the problem by clearing the buffer dirty bit under buffer_lock
even if the buffer is on BJ_None list. Actually, we clear the dirty bit
regardless the list the buffer is in and warn about the fact if
the buffer is already journalled.

Thanks for spotting the problem goes to dingdinghua .

Reported-by: dingdinghua 
Signed-off-by: Jan Kara